All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 00/11] drm/i915: Simplify handling of modifiers
Date: Wed, 13 Oct 2021 22:41:49 +0300	[thread overview]
Message-ID: <9367eab7-1947-53e8-67f1-a7015c9f491c@gmail.com> (raw)
In-Reply-To: <20211007203517.3364336-1-imre.deak@intel.com>

Set look all ok to me, including v2 patches.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 7.10.2021 23.35, Imre Deak wrote:
> This patchset adds a descriptor table for all modifiers used by i915,
> which deduplicates the listing of supported modifiers during plane
> initialization and during checking for a modifier support on a plane.
> This also simplifies getting some modifier attributes like checking
> if a plane is a CCS modifier. The motivation is to make it easier to
> add and maintain new CCS modifier sets, which will be needed for at
> least ADL-P and another upcoming platform.
> 
> Tested with igt/kms_plane,kms_ccs on CHV,HSW,TGL,ADLP.
> 
> The patches are also avaiable at:
> https://github.com/ideak/linux/commits/modifier-descriptors
> 
> Imre Deak (11):
>    drm/i915: Add a table with a descriptor for all i915 modifiers
>    drm/i915: Move intel_get_format_info() to intel_fb.c
>    drm/i915: Add tiling attribute to the modifier descriptor
>    drm/i915: Simplify the modifier check for interlaced scanout support
>    drm/i915: Unexport is_semiplanar_uv_plane()
>    drm/i915: Move intel_format_info_is_yuv_semiplanar() to intel_fb.c
>    drm/i915: Add a platform independent way to get the RC CCS CC plane
>    drm/i915: Handle CCS CC planes separately from CCS control planes
>    drm/i915: Add a platform independent way to check for CCS control
>      planes
>    drm/i915: Move is_ccs_modifier() to intel_fb.c
>    drm/i915: Add functions to check for RC CCS CC and MC CCS modifiers
> 
>   .../gpu/drm/i915/display/intel_atomic_plane.c |   1 +
>   drivers/gpu/drm/i915/display/intel_cursor.c   |  19 +-
>   drivers/gpu/drm/i915/display/intel_display.c  | 150 +----
>   drivers/gpu/drm/i915/display/intel_display.h  |   4 -
>   .../drm/i915/display/intel_display_types.h    |  17 -
>   drivers/gpu/drm/i915/display/intel_fb.c       | 536 ++++++++++++++++--
>   drivers/gpu/drm/i915/display/intel_fb.h       |  25 +-
>   drivers/gpu/drm/i915/display/intel_sprite.c   |  35 +-
>   drivers/gpu/drm/i915/display/skl_scaler.c     |   1 +
>   .../drm/i915/display/skl_universal_plane.c    | 165 +-----
>   drivers/gpu/drm/i915/i915_drv.h               |   3 +
>   drivers/gpu/drm/i915/intel_pm.c               |   1 +
>   12 files changed, 569 insertions(+), 388 deletions(-)
> 


      parent reply	other threads:[~2021-10-13 19:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 20:35 [Intel-gfx] [PATCH 00/11] drm/i915: Simplify handling of modifiers Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers Imre Deak
2021-10-07 21:10   ` Ville Syrjälä
2021-10-07 21:26     ` Imre Deak
2021-10-07 21:32       ` Ville Syrjälä
2021-10-07 22:00         ` Imre Deak
2021-10-08  9:41           ` Ville Syrjälä
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-13 20:14     ` Ville Syrjälä
2021-10-13 21:01       ` Imre Deak
2021-10-13 21:34         ` Ville Syrjälä
2021-10-13 20:40     ` Ville Syrjälä
2021-10-14 10:07       ` Imre Deak
2021-10-14 14:07   ` [Intel-gfx] [PATCH " Jani Nikula
2021-10-14 14:16     ` Jani Nikula
2021-10-14 15:03     ` Imre Deak
2021-10-14 15:48       ` Jani Nikula
2021-10-07 20:35 ` [Intel-gfx] [PATCH 02/11] drm/i915: Move intel_get_format_info() to intel_fb.c Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-13 20:17     ` Ville Syrjälä
2021-10-13 21:06       ` Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 03/11] drm/i915: Add tiling attribute to the modifier descriptor Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-13 20:18   ` [Intel-gfx] [PATCH " Ville Syrjälä
2021-10-13 21:08     ` Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 04/11] drm/i915: Simplify the modifier check for interlaced scanout support Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 05/11] drm/i915: Unexport is_semiplanar_uv_plane() Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 06/11] drm/i915: Move intel_format_info_is_yuv_semiplanar() to intel_fb.c Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 07/11] drm/i915: Add a platform independent way to get the RC CCS CC plane Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 08/11] drm/i915: Handle CCS CC planes separately from CCS control planes Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 09/11] drm/i915: Add a platform independent way to check for " Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-13 20:27   ` [Intel-gfx] [PATCH " Ville Syrjälä
2021-10-13 20:45     ` Ville Syrjälä
2021-10-13 21:32       ` Imre Deak
2021-10-13 21:54         ` Ville Syrjälä
2021-10-13 22:28           ` Imre Deak
2021-10-13 22:38             ` Ville Syrjälä
2021-10-14 10:10               ` Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 10/11] drm/i915: Move is_ccs_modifier() to intel_fb.c Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-07 20:35 ` [Intel-gfx] [PATCH 11/11] drm/i915: Add functions to check for RC CCS CC and MC CCS modifiers Imre Deak
2021-10-08  0:19   ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-07 21:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Simplify handling of modifiers Patchwork
2021-10-07 21:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-10-07 21:50 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-10-08  0:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Simplify handling of modifiers (rev9) Patchwork
2021-10-08  0:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-10-08  1:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-08  2:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-13 19:41 ` Juha-Pekka Heikkila [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9367eab7-1947-53e8-67f1-a7015c9f491c@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.