From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CD295394 for ; Fri, 18 Mar 2022 22:48:23 +0000 (UTC) Received: from [IPv6:::1] ([IPv6:2601:646:8600:40c1:8f0c:2533:51ff:d719]) (authenticated bits=0) by mail.zytor.com (8.17.1/8.15.2) with ESMTPSA id 22IMltGC1012727 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Fri, 18 Mar 2022 15:47:56 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 22IMltGC1012727 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2022030301; t=1647643676; bh=eQmUnf4BQ6Am5omHpUeOWcJu4ubjTaOa1UmiRCl9H4A=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=FjhPFIrk+8dUdZPRs95FCMKlxROzpjTBqlqt1yqa4v1OWFiKnD4uXULa4YjMf/1Yd jIcsOz4fu2fiJJzZuEyv5DAiWz+fnYMetgYZRq9ZJBSJzYLJvsJZMLvq++A3TcYmTL a4QWVdrWQFloz4VuA1nDVPOS2H8iN5Y3RBgI8NxOJ7kjK2uFKvpm2WQPWYWETmVBt2 A33qv13r63/moq+OBS04JKvyzYsEifUhTMnxbCBeHz2uqpBeW2bZdd2GdUvdSDWv0R PjEQvAANiuXAZhr7Rjy9FGqM9EM1cLqeJ3I98K6cvo/7NFARUVLXlGpBDk97GJLP0S YvF6UXcUsoc5w== Date: Fri, 18 Mar 2022 15:47:49 -0700 From: "H. Peter Anvin" To: David Laight , "'Segher Boessenkool'" , Linus Torvalds CC: Andy Lutomirski , Andrew Cooper , Nick Desaulniers , Bill Wendling , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Nathan Chancellor , Juergen Gross , Peter Zijlstra , "llvm@lists.linux.dev" , LKML , linux-toolchains Subject: RE: [PATCH v5] x86: use builtins to read eflags User-Agent: K-9 Mail for Android In-Reply-To: References: <83b33afc-8502-0065-60bc-3a91528632d8@kernel.org> <20220318220901.GS614@gate.crashing.org> Message-ID: <93EDA96C-0EAD-4C40-ABEA-28C8BF76A9F9@zytor.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On March 18, 2022 3:36:48 PM PDT, David Laight wrote: >From: Segher Boessenkool >> Sent: 18 March 2022 22:09 >=2E=2E=2E >> It generally is a very good idea to >> have a redzone though, without it you pay much more than necessary for >> frame setup and teardown in leaf functions (similar to some of what the >> misnamed "shrink-wrapping" optimisation does, but the two are mostly >> independent, the benefits add up)=2E > >Are there really leaf functions that need to spill data to stack >where the cost of setting up a stack frame is significant? > >I'd have thought that was relatively rare=2E > > David > >- >Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1= 1PT, UK >Registration No: 1397386 (Wales) > > Yes=2E