From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E5EC433FE for ; Sat, 19 Nov 2022 17:42:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owRqQ-0000Bq-IK; Sat, 19 Nov 2022 12:41:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owRqO-0000Ap-R4; Sat, 19 Nov 2022 12:41:32 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owRqM-0007wt-VM; Sat, 19 Nov 2022 12:41:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1668879687; bh=C8K9/vkFVctdtBSu2XoXRafqURPFkbueNFbYl1tUOvQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Tw8Hu0v4WMOMxilW8Ak7TwW+yuuk07fHrpdsfEha8JOvMcQLh5FNB3vmgzWupHI3Q p9CVF8bxWySK1tHhUq9NcZjAE3fEWzeQ4kho2UmnkSkByMyXPr8zoEDUgzFMjdz9p+ 4pXgAn8CNO8MWk/lQs07gqdGtspU5L5z9yYWbhG0htsll+GCQEDi+0qNmOrOg9+WaF 4dTKQnVMNNjmuXoWlXZ6PBFL1UZylvRxJTlqR8GFbklwDR2XoQNhMOwVKAjsX2s3m7 al/FphLoOp5cGPD2lmdpGiJTF3gswIGXoVTWqR3F5E17lRpkQLopJZIfavaPXNQTNn nONpMGp7Vfs6A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.115.96.141]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsHs0-1pCc9M3mfq-00th4y; Sat, 19 Nov 2022 18:41:26 +0100 Message-ID: <93e91610-86fe-4700-f143-d6b599d37521@gmx.de> Date: Sat, 19 Nov 2022 18:41:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH qemu.git v2 5/9] hw/timer/imx_epit: do not persist CR.SWR bit To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org References: <166783932395.3279.1096141058484230644-0@git.sr.ht> <166783932395.3279.1096141058484230644-5@git.sr.ht> Content-Language: de-DE From: Axel Heider In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pwtknh/T6Ug1Sd8+ufwKZMKyN3ke74snq+0FTH+O4QL8T9dgSyW 0KSZMWN9jgu9ZD19lMmo2kFukCFA4+IvuK2vJ3cZvYaetmkuHg6O9c32Z+qabv00aqTtGXg ZLKTr4Nz94AsrkPJuShFcJqcNV8znK/D2AZpA83OJ2GcgUtUdrt1jk7hewiwGDiW+c7WbGv vI81nR4R5EjetYkmo6cAg== UI-OutboundReport: notjunk:1;M01:P0:8OpYL410iuA=;THiAjQpDrkPBMCZBqFC8Hr2DxHQ XfHdr9xnWMxZmu7NW1cRshckeNyB+01zb/ESyrivkFnOoxLTzD1zCkM7+SmudAt2o6ZtepP// Co94A/54CHCLKMWKkIsWpewgttfz6MKf833FBRqaFrES2gVyVKe1klkI7ThjbHQ8hsonsdGqu FqEM3wWvfKLWt/Z0djiBT0SjQ6Fu0asPjBA5hp7kEwC56cCurN2cgm0EMkR7QSJcWnXf2/DJR kAnw2yBxpBxpTbvtP4jZlQaJxqzXeHyCO3VQozwFUqT4PcVaqdrmzupUgUNdQicrLKo/0353z 2xeNZxM67tlxFWt75ARD0DNEu8jcgh3x8KztQwrB6L/8ezN090m7gXkXLxCdKWY+1nxnWfRT9 YyoP15ANo1LEK+nYvorVQlOhpBzNsp3LefnNtGnIM9nj1ZUtKGcMjeNswShGFyTviqL2MJoeK 10OswUsFnQHDQNUS1AJzPn+7C8ni3TTGgt7vEdGkwdi4CvPGeqv5qOZEUqEZ2/3ihJe5eO7nv B4brHfz2gCIYgXFpl2B0IpG3CMfMaf1lG2hI4SPZju4d/K9attWPxQPU2PxtWcSbHOhxn9T9H rDqFh7BMeclo4+PNuLyFZofrZvz4jrRobo9FbZPlazugJcDD0ng6KUy40hm1X52/U/Yrc3Q49 2tzBtOiOCoEHU3tYHSIY5VrTKa7Dm3Re2dJ+OPRvjN6Me/u0d6A+AToj940LSY7GJGJMxIXpd VqDdhTbUbG5lHuK8EP5S55x/oYsnPsS7FCTddUa3UKJfIZIHl4qnA8k5ei3etd0zGs82eksMz hRBqWxLLseuhK+GyCTXUg8PatwlZ3qV+E+oqAUZ5Hb+A+fK2xxJsanCoFL5IyXx/vvV9tjT16 QWKNEd1igkSL2JYHmiA13BG0rhdiafa7wNxDDTykr25yUogCNfOJ+8cyeexTXjkQBSJEqkbl9 Gr9xSA== Received-SPF: pass client-ip=212.227.15.18; envelope-from=axelheider@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org >> >> From: Axel Heider >> Signed-off-by: Axel Heider >> --- >> hw/timer/imx_epit.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c >> index 5315d9633e..6af460946f 100644 >> --- a/hw/timer/imx_epit.c >> +++ b/hw/timer/imx_epit.c >> @@ -191,8 +191,9 @@ static void imx_epit_write(void *opaque, hwaddr off= set, uint64_t value, >> case 0: /* CR */ >> >> oldcr =3D s->cr; >> - s->cr =3D value & 0x03ffffff; >> - if (s->cr & CR_SWR) { >> + /* SWR bit is never persisted, it clears itself once reset is = done */ >> + s->cr =3D (value & ~CR_SWR) & 0x03ffffff; >> + if (value & CR_SWR) { >> /* handle the reset */ >> imx_epit_reset(DEVICE(s)); >> /* >> > > There's a comment just below here that says "can we just 'break' > in this case?". That's there because last time we had to touch > this device we didn't have enough specific knowledge of the hardware > or test cases so we made a refactor that left the code with the same > probably-incorrect behaviour it had before the refactor. But, since > you're working on this device anyway: can we simply add the "break" > after imx_epit_reset() ? > > If we can just say "if CR_SWR is set then the device resets like > a hardware reset", then this all simplifies out a lot and this > patch isn't necessary at all. (imx_epit_reset() clears the CR_SWR bit.) > I'm fairly sure we ought to be able to do that, and the missing 'break' > was just a bug... You are right, this patch is not needed. Actually, the refactoring in the other patches in this series makes this quite obvious then anyway. And you comment fully holds, eventually all the setup is skipped in case of a reset. I will drop this patch from the set. Thanks for the review. Axel