Re: [kvm-unit-tests PATCH 4/5] scripts/arch-run: fix qemu binary search failure path

From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, kvm@vger.kernel.org
Cc: Drew Jones <drjones@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 4/5] scripts/arch-run: fix qemu binary search failure path
Date: Wed, 28 Jun 2017 22:46:27 +0200	[thread overview]
Message-ID: <95109d90-f139-e292-aff4-bb60c9569407@redhat.com> (raw)
In-Reply-To: <20170628200857.1718-5-rkrcmar@redhat.com>

On 28/06/2017 22:08, Radim Krčmář wrote:
> Doing exit from a subshell won't exit the main shell, so arch-run will
> try to continue without a working QEMU if search_qemu_binary() failed.

Should it be "exit $?"?

Apart from this looks good.  I can do the change.

Paolo

> Also fix error message from search_qemu_binary().
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> I was thinking about using `set -e` instead, so the "return 2" from
> search_qemu_binary() would stop the script without the explicit exit.
> It required just four changes to make the script work (resulting in
> better diffstat), but would likely complicate future development.
> 
> The second alternative would be to call just "search_qemu_binary" and
> set the qemu variable from it.  This would allow "exit 2" from
> search_qemu_binary() to also exit arch/run, but side-effects on
> variables seem worse than the first alternative ...
> ---