From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1271DC433E0 for ; Sun, 27 Dec 2020 16:43:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AD2A2250F for ; Sun, 27 Dec 2020 16:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AD2A2250F Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktZ8k-0001zr-HF for qemu-devel@archiver.kernel.org; Sun, 27 Dec 2020 11:43:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZ7q-0001A3-6f for qemu-devel@nongnu.org; Sun, 27 Dec 2020 11:42:34 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:24188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZ7o-0003rS-Ll for qemu-devel@nongnu.org; Sun, 27 Dec 2020 11:42:34 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 82F41746552; Sun, 27 Dec 2020 17:42:31 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 554EB74646C; Sun, 27 Dec 2020 17:42:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 5380D74645B; Sun, 27 Dec 2020 17:42:31 +0100 (CET) Date: Sun, 27 Dec 2020 17:42:31 +0100 (CET) To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH 09/12] vt82c686: Convert debug printf to trace points In-Reply-To: <7d9d823d-d75b-c586-218a-e40de35d8b6d@amsat.org> Message-ID: <96aefaf1-1b8e-7da7-cf1-2e49a98b3cd5@eik.bme.hu> References: <7d9d823d-d75b-c586-218a-e40de35d8b6d@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-705507364-1609087351=:84491" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: BALATON Zoltan From: BALATON Zoltan via This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-705507364-1609087351=:84491 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote: > On 12/27/20 2:10 AM, BALATON Zoltan via wrote: >> Signed-off-by: BALATON Zoltan >> --- >> hw/isa/trace-events | 6 ++++++ >> hw/isa/vt82c686.c | 51 +++++++++++++-------------------------------- >> 2 files changed, 21 insertions(+), 36 deletions(-) > ... > >> switch (superio_conf->index) { >> case 0x00 ... 0xdf: >> case 0xe4: >> case 0xe5: >> + case 0xe6 ... 0xe8: /* Should set base port of parallel and serial */ >> case 0xe9 ... 0xed: >> case 0xf3: >> case 0xf5: >> @@ -74,18 +68,6 @@ static void superio_ioport_writeb(void *opaque, hwaddr addr, uint64_t data, >> case 0xfd ... 0xff: >> can_write = false; >> break; >> - case 0xe7: >> - if ((data & 0xff) != 0xfe) { >> - DPRINTF("change uart 1 base. unsupported yet\n"); >> - can_write = false; >> - } >> - break; >> - case 0xe8: >> - if ((data & 0xff) != 0xbe) { >> - DPRINTF("change uart 2 base. unsupported yet\n"); >> - can_write = false; >> - } >> - break; >> default: >> break; > > This hunk belong to a different patch (does not match the patch > description). In a way does, in that it removes two DPRINTFs instead of converting them. Maybe I should mention this in the commit message or could make it a separate patch but don't know if that's worth it. Regards, BALATON Zoltan --3866299591-705507364-1609087351=:84491--