From: Phillip Wood <phillip.wood123@gmail.com>
To: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34
Date: Mon, 4 Apr 2022 21:39:03 +0100 [thread overview]
Message-ID: <975e203d-6bd3-f5ea-c21b-3e7518a04bb9@gmail.com> (raw)
In-Reply-To: <20220304133702.26706-1-gitter.spiros@gmail.com>
On 04/03/2022 13:37, Elia Pinto wrote:
> In glibc >= 2.34 MALLOC_CHECK_ and MALLOC_PERTURB_ environment
> variables have been replaced by GLIBC_TUNABLES. Also the new
> glibc requires that you preload a library called libc_malloc_debug.so
> to get these features.
>
> Using the ordinary glibc system variable detect if this is glibc >= 2.34 and
> use GLIBC_TUNABLES and the new library.
>
> This patch was inspired by a Richard W.M. Jones ndbkit patch
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> This is the third version of the patch.
>
> Compared to the second version[1], the code is further simplified,
> eliminating a case statement and modifying a string statement.
>
> [1] https://www.spinics.net/lists/git/msg433917.html
>
> t/test-lib.sh | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 9af5fb7674..4d10646015 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -550,9 +550,25 @@ else
> setup_malloc_check () {
> MALLOC_CHECK_=3 MALLOC_PERTURB_=165
> export MALLOC_CHECK_ MALLOC_PERTURB_
> + if _GLIBC_VERSION=$(getconf GNU_LIBC_VERSION 2>/dev/null) &&
> + _GLIBC_VERSION=${_GLIBC_VERSION#"glibc "} &&
> + expr 2.34 \<= "$_GLIBC_VERSION" >/dev/null
> + then
> + g=
> + LD_PRELOAD="libc_malloc_debug.so.0"
When compiling with "SANITIZE = address,leak" this use of LD_PRELOAD
makes the tests fail with
==9750==ASan runtime does not come first in initial library list; you
should either link runtime to your application or manually preload it
with LD_PRELOAD.
because libc_malloc_debug.so is being loaded before libasan.so. If I set
TEST_NO_MALLOC_CHECK=1 when I run the tests then ASAN does not complain
but it would be nicer if I did not have to do that. I'm confused as to
why the CI leak tests are running fine - am I missing something with my
setup?
Best Wishes
Phillip
next prev parent reply other threads:[~2022-04-04 21:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:37 [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34 Elia Pinto
2022-03-04 19:59 ` Junio C Hamano
2022-03-08 11:33 ` [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check Carlo Marcelo Arenas Belón
2022-03-08 23:55 ` Eric Sunshine
2022-03-08 23:58 ` Eric Sunshine
2022-03-09 0:05 ` Eric Sunshine
2022-03-09 17:47 ` Junio C Hamano
2022-03-09 20:07 ` Ævar Arnfjörð Bjarmason
2022-03-11 23:06 ` Eric Sunshine
2022-03-12 10:38 ` Ævar Arnfjörð Bjarmason
2022-03-13 2:20 ` Junio C Hamano
2022-03-13 2:37 ` Carlo Arenas
2022-03-13 7:34 ` Junio C Hamano
2022-03-11 23:02 ` Eric Sunshine
2022-03-13 19:02 ` Elia Pinto
2022-04-04 20:39 ` Phillip Wood [this message]
2022-04-05 10:03 ` Making the tests ~2.5x faster (was: [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34) Ævar Arnfjörð Bjarmason
2022-04-05 13:36 ` Phillip Wood
2022-04-05 19:59 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975e203d-6bd3-f5ea-c21b-3e7518a04bb9@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.