All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aravindh Puthiyaparambil (aravindp)" <aravindp@cisco.com>
To: Tamas Lengyel <tamas.lengyel@zentific.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Issues regarding "mem_access: Add helper API to setup ring and enable mem_access"
Date: Mon, 30 Jun 2014 22:31:32 +0000	[thread overview]
Message-ID: <97A500D504438F4ABC02EBA81613CC633185EDF5@xmb-aln-x02.cisco.com> (raw)
In-Reply-To: CAErYnshnYY8+NXpR3LidX41G+nC78Xadyhrb6_1UtyPioxG5mw@mail.gmail.com

>>	> I agree with your criticism, TBH.  Aravindh/Ian, can we rename this
>>	> function ?
>>
>>	I have no objection to some other name.
>
>How about xc_enable_mem_event()? If that is fine, I will submit a patch.
>
>>A question regarding renaming the xc_mem_event_enable function. The
>>public xenctrl.h clearly says
>>
>>/**
>> * mem_event operations. Internal use only.
>> */
>>
>>There are only three of these, xc_mem_event_control,
>>xc_mem_event_memop and xc_mem_event_enable. Wouldn't it make
>more
>>sense to just exclude these functions from the public header and move
>them
>>to xc_private.h? Why have internal functions in the public header?
>
>I too think these can be moved to the xc_private.h. IanC / IanJ, what are your
>thoughts on doing this?

Forgot to add that if this move is done then I am assuming the rename is not required. Correct?

Thanks,
Aravindh

  parent reply	other threads:[~2014-06-30 22:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 16:31 Issues regarding "mem_access: Add helper API to setup ring and enable mem_access" Tamas Lengyel
2014-06-27 15:20 ` Ian Campbell
2014-06-30 12:06   ` Tamas Lengyel
2014-06-30 12:42     ` Ian Jackson
2014-06-30 12:44       ` Ian Campbell
2014-06-30 13:07         ` Andrew Cooper
2014-06-30 13:09           ` Ian Campbell
2014-06-30 13:10             ` Andrew Cooper
2014-06-30 14:12               ` Jan Beulich
2014-06-30 14:19                 ` Andrew Cooper
2014-06-30 14:49         ` Tamas Lengyel
2014-06-30 22:14           ` Aravindh Puthiyaparambil (aravindp)
2014-06-30 22:31           ` Aravindh Puthiyaparambil (aravindp) [this message]
2014-07-02 11:54             ` Tamas Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97A500D504438F4ABC02EBA81613CC633185EDF5@xmb-aln-x02.cisco.com \
    --to=aravindp@cisco.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=tamas.lengyel@zentific.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.