All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Intel Linux Wireless <linuxwifi@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] iwlwifi: dvm: no need to check return value of debugfs_create functions
Date: Fri, 05 Jul 2019 11:37:56 +0300	[thread overview]
Message-ID: <9899896581ccedda453d0e81430b76f8fc8b4bb1.camel@intel.com> (raw)
In-Reply-To: <20190612142658.12792-3-gregkh@linuxfoundation.org>

On Wed, 2019-06-12 at 16:26 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  This driver was saving the debugfs file away to be
> removed at a later time.  However, the 80211 core would delete the whole
> directory that the debugfs files are created in, after it asks the
> driver to do the deletion, so just rely on the 80211 core to do all of
> the cleanup for us, making us not need to keep a pointer to the dentries
> around at all.
> 
> This cleans up the structure of the driver data a bit and makes the code
> a tiny bit smaller.
> 
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: Intel Linux Wireless <linuxwifi@intel.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

Thanks, Greg! I applied this to our internal tree and it will reach the
mainline following our normal upstreaming process.

--
Cheers,
Luca.


  reply	other threads:[~2019-07-05  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 14:26 [PATCH 1/5] iwlegacy: 3945: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 14:26 ` [PATCH 2/5] iwlegacy: 4965: " Greg Kroah-Hartman
2019-06-12 14:26 ` [PATCH 3/5] iwlwifi: dvm: " Greg Kroah-Hartman
2019-07-05  8:37   ` Luciano Coelho [this message]
2019-06-12 14:26 ` [PATCH 4/5] iwlwifi: mvm: remove unused .remove_sta_debugfs callback Greg Kroah-Hartman
2019-07-05  8:38   ` Luciano Coelho
2019-06-12 14:26 ` [PATCH 5/5] mac80211: remove unused and unneeded remove_sta_debugfs callback Greg Kroah-Hartman
2019-06-25  5:08 ` [PATCH 1/5] iwlegacy: 3945: no need to check return value of debugfs_create functions Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9899896581ccedda453d0e81430b76f8fc8b4bb1.camel@intel.com \
    --to=luciano.coelho@intel.com \
    --cc=davem@davemloft.net \
    --cc=emmanuel.grumbach@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.