From: Thomas Huth <thuth@redhat.com>
To: Patrick Venture <venture@google.com>, lvivier@redhat.com
Cc: hskinnemoen@google.com, kfting@nuvoton.com, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, Hao Wu <wuhaotsh@google.com>
Subject: Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC
Date: Mon, 19 Sep 2022 14:44:36 +0200 [thread overview]
Message-ID: <98b23697-00ec-2952-31c1-258419bd5440@redhat.com> (raw)
In-Reply-To: <20220906163138.2831353-1-venture@google.com>
On 06/09/2022 18.31, Patrick Venture wrote:
> The register tests walks all the registers to verify they are initially
> 0 when appropriate. However, if the MAC address is set in the register
> space, this should not be checked against 0.
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Change-Id: I02426e39bdab33ceedd42c49d233e8680d4ec058
What's that change-id good for?
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> tests/qtest/npcm7xx_emc-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c
> index 7c435ac915..207d8515b7 100644
> --- a/tests/qtest/npcm7xx_emc-test.c
> +++ b/tests/qtest/npcm7xx_emc-test.c
> @@ -378,7 +378,8 @@ static void test_init(gconstpointer test_data)
>
> #undef CHECK_REG
>
> - for (i = 0; i < NUM_CAMML_REGS; ++i) {
> + /* Skip over the MAC address registers, which is BASE+0 */
> + for (i = 1; i < NUM_CAMML_REGS; ++i) {
> g_assert_cmpuint(emc_read(qts, mod, REG_CAMM_BASE + i * 2), ==,
> 0);
> g_assert_cmpuint(emc_read(qts, mod, REG_CAML_BASE + i * 2), ==,
Basically ack, but one question: Where should that non-zero MAC address come
from / when did you hit a problem here? If QEMU is started without any mac
settings at all (like it is done here), the register never contains a
non-zero value, does it?
Thomas
next prev parent reply other threads:[~2022-09-19 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:31 [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC Patrick Venture
2022-09-19 12:44 ` Thomas Huth [this message]
2022-09-19 22:37 ` Patrick Venture
2022-09-20 7:00 ` Thomas Huth
2022-10-06 17:58 ` Patrick Venture
2022-10-06 17:59 ` Patrick Venture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b23697-00ec-2952-31c1-258419bd5440@redhat.com \
--to=thuth@redhat.com \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=lvivier@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.