From: Max Reitz <mreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD
Date: Mon, 20 Jan 2020 15:36:05 +0100 [thread overview]
Message-ID: <99340090-0575-9b4e-4156-dac823e34be3@redhat.com> (raw)
In-Reply-To: <20191202101039.8981-4-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]
On 02.12.19 11:10, Thomas Huth wrote:
> In the long term, we might want to add test 183 to the "auto" group
> (but it still fails occasionally, so we cannot do that yet). However,
> when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd
> target, it currently always fails with an "Timeout waiting for return
> on handle 0" error.
>
> Let's mark it as supported only on systems where the test is working
> fine (i.e. Linux, FreeBSD and NetBSD).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/183 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183
> index bced83fae0..0bbae13647 100755
> --- a/tests/qemu-iotests/183
> +++ b/tests/qemu-iotests/183
> @@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.filter
> . ./common.qemu
>
> +_supported_os Linux FreeBSD NetBSD
I don’t suppose you have data on OpenBSD?
(And maybe it would be best to let _unsupported_os just check whether
$HOSTOS contains any of these strings (ideally in a case-insensitive
way) instead of checking for equality, but that’s for another series to
decide.)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-20 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:10 [PATCH v4 0/6] Enable more iotests during "make check-block" Thomas Huth
2019-12-02 10:10 ` [PATCH v4 1/6] iotests: remove 'linux' from default supported platforms Thomas Huth
2019-12-02 10:10 ` [PATCH v4 2/6] iotests: Test 041 only works on certain systems Thomas Huth
2020-01-20 14:31 ` Max Reitz
2019-12-02 10:10 ` [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD Thomas Huth
2020-01-20 14:36 ` Max Reitz [this message]
2020-01-20 16:01 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127 Thomas Huth
2020-01-20 14:47 ` Max Reitz
2019-12-02 10:10 ` [PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk Thomas Huth
2020-01-20 14:50 ` Max Reitz
2020-01-20 16:05 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage Thomas Huth
2020-01-20 14:51 ` Max Reitz
2020-01-20 14:52 ` [PATCH v4 0/6] Enable more iotests during "make check-block" Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99340090-0575-9b4e-4156-dac823e34be3@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.