Re: [PATCH mptcp-next 0/9] Refactor mptcp_join.sh

[Matthieu Baerts <matthieu.baerts@tessares.net>]

Hi Mat, Paolo,

On 10/02/2022 01:22, Mat Martineau wrote:
> On Wed, 9 Feb 2022, Matthieu Baerts wrote:
> 
>> I started this series to be able to launch a specific test without
>> having to modify the script to comment tests from the subgroup I didn't
>> want to validate when trying to reproduce a specific issue in a loop.
>> That's what we can find in patch 3/9.
>>
>> While at it, I:
>> - fixed one issue with the options (patch 1/9)
>> - stop if an option doesn't exist (patch 2/9)
>> - removed unused vars (patch 4/9)
>> - delay some actions to the first test not to do them if no test is
>>  launched (patches 5-6/9)
>>
>> But after having seen all modified lines, why stopping there? So I:
>> - clarify local vs global variables to avoid Bash's classical pitfall
>>  (patch 7/9)
>> - fixed all issues reported by ShellCheck except one (patch 8-9/9)
>>
>> These last 3 patches (+ patch 3/9) will create a lot of conflicts. If
>> we are OK with them, probably best not to wait to long before applying
>> them to avoid big rebases.
> 
> I think 1, 2, 4, 5, and 6 look good for the export branch now:
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Thank you for the reviews!

I just applied these 5 patches to our tree with your RvB tag (and fixed
s/KSFT_SKIP/ksft_skip/g I left by mistake when splitting commits).

- 1e4cd0e4eae7: selftests: mptcp: join: allow running -cCi
- 251e4354c1c0: selftests: mptcp: join: exit after usage()
- 7e59a8ad9b44: selftests: mptcp: join: remove unused vars
- 739ef6848c45: selftests: mptcp: join: create tmp files only if needed
- 50c4db8022d3: selftests: mptcp: join: check for tools only if needed
- Results: 178780fe8241..dd0f23150c09

I will look at the other patches from this series later.

Builds and tests are now in progress:



https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220211T173324

https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net