From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106AbdC1QUt (ORCPT ); Tue, 28 Mar 2017 12:20:49 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:63370 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbdC1QUq (ORCPT ); Tue, 28 Mar 2017 12:20:46 -0400 Subject: Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART To: Rob Herring References: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> <1490621848-24828-8-git-send-email-stefan.wahren@i2se.com> Cc: Mark Rutland , "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Marcel Holtmann , Sebastian Reichel , netdev , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Stefan Wahren Message-ID: <9a094176-ebe7-d906-ca9c-967285e53b07@i2se.com> Date: Tue, 28 Mar 2017 18:18:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3lC0cRQiTFff657I46Jc+DNbb7qqRTzGJ2N4Fry8PwAvtBwWlHK Pd+8guBFi80zkxNI4imNhd2jaqixY+3u4KAa9WqwJjLNEGXud5pCKvgcydJwv7ZSghcMkax LJn3F3alc6by6PqOt0OdLVRUAI4jugS4cNZHBMffjAwxzsBRupEx4zFDbToO/yza/zML1+J AruBRsiS7/pnuONIUxBIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:mGdFIiObgEA=:dnb5EOtaaNPdP7jWqWWoV5 lilh23ryQF1I8kx5/6mZiZN9et/KokeI/fJM+/q3RdGgA7vkvdhi7mNWw8btonUB/l+VINAcG 7n4iYffgsXNSCS+oLOBXakb0g39eb9HYIdObgPSYsNquIfL1vXcYup/Zr2ioFPIryzzRdDkJ2 OWxU9tkY9J2+epq+TGqydxm87r34M1KZLK5IPFUSFAwedZZHKhhXOEN6lN/Epn60w7bSIyuNP rp9C7zsaRLTFN4QECO9Y/SHR5yB24O43p981gpjQ7N/2ccnQvFZsXtSNaZKOJHKii1mviuyhs wD5XwrGhj6YSn+mTgcA7duEdq/zqzcJVNMZGp6IlkYXaKzLnqaX1NW3UzcbaUmozl/ZBjElp9 OITdDFMLdQftuTaqRdx6nc0IMHtCQSd6DywCePxI0Z+oGt4frMTjf5aNQsGwNwpu6dCnciXhE vho5Q25QpTGosEAZ8wanAZCM2Gwo/VbrR8uAFhJ5H6UTgaelTUm0ozO6YD2E474Jq72e7+RXx SrDn/nOaZMqx3mUxQGVlDMFhL+xlO9CPE3JpYolfnAnB66lJIPWM/AkD5slKl530I6Y6LNMuD RYoYB8+z0eXcwAXxlPnABtctEcRRjO/RtxBc3JjWsEbZpRIf3hmxP+Esi+WGyN5c2xdbUlgU+ WziG5bi0ASHU8YBchrdANaJl+Qiv6u45uLb/AMQJ9eV2zqePBLNMk/Rse0r/CII47Nm2v9160 zKM0TLzZkBlmr1MP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren >> --- >> >> According to this binding are still some questions: >> >> Where should be the optional hardware flow control defined (at master or slave side)? > Probably should be in the slave side. We already have uart-has-rtscts > and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not > necessarily that we want to enable them. > > In many cases, the driver may know what it needs. Like all the other UART settings the hardware flow control can be configured in the QCA7000 firmware and the driver can't detect it. Property suggestion for the slave side: use-rtscts > >> Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged? > Are they mutually-exclusive or both are used at the same time? They are mutually-exclusive because they use the same pins. > What > are the dependencies between the interfaces? Except they uses the same pins of the QCA7000, i can't see any dependency. > >> >> .../devicetree/bindings/net/qca-qca7000-uart.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> >> diff --git a/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> new file mode 100644 >> index 0000000..f2e0450 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> @@ -0,0 +1,31 @@ >> +* Qualcomm QCA7000 (Ethernet over UART protocol) >> + >> +Note: This binding applies in case the QCA7000 is configured as a >> +UART slave device. It is possible to preconfigure the UART settings >> +of the QCA7000 firmware, which can't be changed during runtime. >> + >> +Required properties: >> +- compatible : Should be "qca,qca7000-uart" >> + >> +Optional properties: >> +- local-mac-address : 6 bytes, Specifies MAC address > The description can be "see ./ethernet.txt" > >> +- current-speed : Specifies the serial device speed in >> + bits per second (default = 115200), which is >> + predefined by the QCA7000 firmware configuration > Add this to the slave binding doc with some caveats as to when this > should or should not be used as we discussed. > > Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART Date: Tue, 28 Mar 2017 18:18:03 +0200 Message-ID: <9a094176-ebe7-d906-ca9c-967285e53b07@i2se.com> References: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> <1490621848-24828-8-git-send-email-stefan.wahren@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Mark Rutland , "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Marcel Holtmann , Sebastian Reichel , netdev , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Rob Herring Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren >> --- >> >> According to this binding are still some questions: >> >> Where should be the optional hardware flow control defined (at master or slave side)? > Probably should be in the slave side. We already have uart-has-rtscts > and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not > necessarily that we want to enable them. > > In many cases, the driver may know what it needs. Like all the other UART settings the hardware flow control can be configured in the QCA7000 firmware and the driver can't detect it. Property suggestion for the slave side: use-rtscts > >> Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged? > Are they mutually-exclusive or both are used at the same time? They are mutually-exclusive because they use the same pins. > What > are the dependencies between the interfaces? Except they uses the same pins of the QCA7000, i can't see any dependency. > >> >> .../devicetree/bindings/net/qca-qca7000-uart.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> >> diff --git a/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> new file mode 100644 >> index 0000000..f2e0450 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt >> @@ -0,0 +1,31 @@ >> +* Qualcomm QCA7000 (Ethernet over UART protocol) >> + >> +Note: This binding applies in case the QCA7000 is configured as a >> +UART slave device. It is possible to preconfigure the UART settings >> +of the QCA7000 firmware, which can't be changed during runtime. >> + >> +Required properties: >> +- compatible : Should be "qca,qca7000-uart" >> + >> +Optional properties: >> +- local-mac-address : 6 bytes, Specifies MAC address > The description can be "see ./ethernet.txt" > >> +- current-speed : Specifies the serial device speed in >> + bits per second (default = 115200), which is >> + predefined by the QCA7000 firmware configuration > Add this to the slave binding doc with some caveats as to when this > should or should not be used as we discussed. > > Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html