From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0554C4361A for ; Fri, 4 Dec 2020 16:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C54A22A85 for ; Fri, 4 Dec 2020 16:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730687AbgLDQbf (ORCPT ); Fri, 4 Dec 2020 11:31:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730660AbgLDQbb (ORCPT ); Fri, 4 Dec 2020 11:31:31 -0500 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676D4C0613D1 for ; Fri, 4 Dec 2020 08:30:51 -0800 (PST) Received: by mail-oi1-x244.google.com with SMTP id y74so6716268oia.11 for ; Fri, 04 Dec 2020 08:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VulumupbWFfWXY5OG6YthXh9X7KfotRO1X3TG0cLq5o=; b=y5+pU2Jvlzjp42IYGpCP5qNRKGaODc6PcyZDCsxpgzVzZoLBcLml1Y0Li6BA6hK0W3 fEcBJHIvtHyqaA/hlF3pt/rs11mg8N+3//4LSG2UHbY2VxiygaUMPs2LRdBIwDwhF2o8 OjHV+5FJO7l9M7/jPQWmhDR3Y4oJE125p6gMEXYmIe5mY+SFlt/qwQ3xBvzY45zby4e0 y4+ynES5l/P5qMMun3Sl0iEiJD6Q5wPxFW709tAQncrXVO12luIyQgBo146H92preROa Wg01yVycanWot+GE7o+zgFtBUhod9h+HKlQ7T9oBjsvMSUgq+76npYKdt54XGG54tb2Y zIjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VulumupbWFfWXY5OG6YthXh9X7KfotRO1X3TG0cLq5o=; b=IJdWWN45ew3fMnOzVvVRzIVj6ShmhwU6XAOrNYMuvZs+LAFDMAKna5J8/tMIYcwBEr 5T9O6bTp51uva/gJZeqIMH1UiKBouC4qD5LYv0qiTdh8lVj8vUm4T+04QCtW3w89WKUZ dGq7+duT/7cYgZZifdBY7F6m8OaGYDBQGC3U8jy8XPa1fVak9J9gSLZg7iOwh0FbGqHb lDNW7QkdmQimcHSIB8u5DCIsjlbAVPwVyWafZFzkS7K7kcNFgK8q9SMC9DWWVxt9nace pKubfQIEXlySPqkt1lnOgM5U13NCwvKyHBVTvDpQAMeEoGeTkSgM3llqDRk3fH7Ma1/9 WLCg== X-Gm-Message-State: AOAM532Pc4Up9o8iaGZgcmlbohwFMVtBkrJR1xhA/zTKNggOtuZ/E4Ap rfUJHWhZx8Wf6ufiRVf/buu6KCURdHFSVKWG X-Google-Smtp-Source: ABdhPJz16+QuenQnBN9dbsIK53H8feE252gDEsotvffzRl1Vg/apyHPKCzhHZVvg1Kj8aYfG69L7JQ== X-Received: by 2002:aca:fd84:: with SMTP id b126mr2202995oii.85.1607099450853; Fri, 04 Dec 2020 08:30:50 -0800 (PST) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id z188sm732654oia.32.2020.12.04.08.30.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Dec 2020 08:30:50 -0800 (PST) Subject: Re: [PATCH 7/9] target/mips: Extract msa_translate_init() from mips_tcg_init() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Jiaxun Yang , Huacai Chen , kvm@vger.kernel.org, Aleksandar Rikalo , Paolo Bonzini , Aurelien Jarno References: <20201202184415.1434484-1-f4bug@amsat.org> <20201202184415.1434484-8-f4bug@amsat.org> From: Richard Henderson Message-ID: <9a103671-d4e7-bcff-c600-931655efbd2b@linaro.org> Date: Fri, 4 Dec 2020 10:30:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202184415.1434484-8-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: > Extract the logic initialization of the MSA registers from > the generic initialization. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 35 ++++++++++++++++++++--------------- > 1 file changed, 20 insertions(+), 15 deletions(-) Why? > - fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2]); > + fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, fregnames[i]); Maybe fold this back to the previous patch? r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89EF6C4361B for ; Fri, 4 Dec 2020 16:56:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B4AB22B2A for ; Fri, 4 Dec 2020 16:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B4AB22B2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klENf-0008FD-AZ for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 11:56:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klEMd-0006hI-GB for qemu-devel@nongnu.org; Fri, 04 Dec 2020 11:55:23 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:34414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klEMb-000217-DZ for qemu-devel@nongnu.org; Fri, 04 Dec 2020 11:55:23 -0500 Received: by mail-oi1-x244.google.com with SMTP id s75so3768560oih.1 for ; Fri, 04 Dec 2020 08:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VulumupbWFfWXY5OG6YthXh9X7KfotRO1X3TG0cLq5o=; b=y5+pU2Jvlzjp42IYGpCP5qNRKGaODc6PcyZDCsxpgzVzZoLBcLml1Y0Li6BA6hK0W3 fEcBJHIvtHyqaA/hlF3pt/rs11mg8N+3//4LSG2UHbY2VxiygaUMPs2LRdBIwDwhF2o8 OjHV+5FJO7l9M7/jPQWmhDR3Y4oJE125p6gMEXYmIe5mY+SFlt/qwQ3xBvzY45zby4e0 y4+ynES5l/P5qMMun3Sl0iEiJD6Q5wPxFW709tAQncrXVO12luIyQgBo146H92preROa Wg01yVycanWot+GE7o+zgFtBUhod9h+HKlQ7T9oBjsvMSUgq+76npYKdt54XGG54tb2Y zIjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VulumupbWFfWXY5OG6YthXh9X7KfotRO1X3TG0cLq5o=; b=GoyNRPRk9aaA7AQJZj2GxrvG/+5MQ8wjQqKAL+1oThDvG9GP41wlV3wy6yEYBaU1w6 O43c3WLy+xexDVC5we66b0/sKDVoVw9/lOVo8GufAuDU92tYXqet34VVBtDa0v3SQE7F cXkm2AzDhXPCJSZExkVGHy0hQFlYabuu4HehEYE5uWeJ/usFUkPsYe5GLwNqJiTabEiw DsbYh1jdjUAbp0R5iZJhdMBCKtUgY8+QJrC1XmehKyZ8y7WDKojrJUL/sMmMqCmOYP3l 4PowDojz2Ejq+I73Mo85KRkuKxC6YO6h3V1q5oM638U8waYx46EN9K/IOzEA9rsxYeIi 28xw== X-Gm-Message-State: AOAM532s6M2cn1b39t+dyZR6JuB3hdfdSm+atrWmFtZXGFCbZTJBBW+W FkrB0jYtMrOStQ1wE+aG1UY5mnJlOgUkcMeZ X-Google-Smtp-Source: ABdhPJz16+QuenQnBN9dbsIK53H8feE252gDEsotvffzRl1Vg/apyHPKCzhHZVvg1Kj8aYfG69L7JQ== X-Received: by 2002:aca:fd84:: with SMTP id b126mr2202995oii.85.1607099450853; Fri, 04 Dec 2020 08:30:50 -0800 (PST) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id z188sm732654oia.32.2020.12.04.08.30.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Dec 2020 08:30:50 -0800 (PST) Subject: Re: [PATCH 7/9] target/mips: Extract msa_translate_init() from mips_tcg_init() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201202184415.1434484-1-f4bug@amsat.org> <20201202184415.1434484-8-f4bug@amsat.org> From: Richard Henderson Message-ID: <9a103671-d4e7-bcff-c600-931655efbd2b@linaro.org> Date: Fri, 4 Dec 2020 10:30:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202184415.1434484-8-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::244; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x244.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , kvm@vger.kernel.org, Paolo Bonzini , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: > Extract the logic initialization of the MSA registers from > the generic initialization. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 35 ++++++++++++++++++++--------------- > 1 file changed, 20 insertions(+), 15 deletions(-) Why? > - fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2]); > + fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, fregnames[i]); Maybe fold this back to the previous patch? r~