From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@arm.com>
Date: Wed, 29 Mar 2017 12:17:31 +0100
Subject: [U-Boot] [PATCH v2 14/18] sunxi: Pine64: defconfig: enable SPL
	FIT support
In-Reply-To: <20170329065735.rvfzednn7ydcvjd3@lukather>
References: <1490661926-18400-1-git-send-email-andre.przywara@arm.com>
 <1490661926-18400-15-git-send-email-andre.przywara@arm.com>
 <20170329065735.rvfzednn7ydcvjd3@lukather>
Message-ID: <9ab9c695-7234-9b0d-9bae-edf94ceaa382@arm.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 29/03/17 07:57, Maxime Ripard wrote:
> On Tue, Mar 28, 2017 at 01:45:22AM +0100, Andre Przywara wrote:
>> The Pine64 (and all other 64-bit Allwinner boards) need to load an
>> ARM Trusted Firmware image beside the actual U-Boot proper.
>> This can now be easily achieved by using the just extended SPL FIT
>> loading support, so enable it in the Pine64 defconfig.
>> Also add the FIT image as a build target to 64-bit sunxi board to
>> trigger the respective Makefile rules.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>>  configs/pine64_plus_defconfig  | 6 ++++++
>>  include/configs/sunxi-common.h | 4 ++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/configs/pine64_plus_defconfig b/configs/pine64_plus_defconfig
>> index 92bda60..8a90579 100644
>> --- a/configs/pine64_plus_defconfig
>> +++ b/configs/pine64_plus_defconfig
>> @@ -3,9 +3,14 @@ CONFIG_ARCH_SUNXI=y
>>  CONFIG_MACH_SUN50I=y
>>  CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
>>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
>> +CONFIG_OF_LIST="sun50i-a64-pine64 sun50i-a64-pine64-plus"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>  CONFIG_CONSOLE_MUX=y
>>  CONFIG_SPL=y
>> +CONFIG_FIT=y
>> +CONFIG_SPL_FIT=y
>> +CONFIG_SPL_LOAD_FIT=y
>> +CONFIG_SPL_OF_LIBFDT=y
> 
> Again, this doesn't make any sense to enable it in *all* our
> defconfigs. If this is something that should be enabled by default for
> the A64 support, then do so in Kconfig directly.

Oh sorry, I think I completely misunderstood you last time.
Indeed this makes sense, especially with more defconfigs for A64/H5
boards coming up.

I will think about a solution that makes Icenowy happy as well,
something like BOARD_NEEDS_SPL_FIT or so - though a simple "select"
sounds tempting ;-)

Cheers,
Andre.