From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E52C388F9 for ; Thu, 19 Nov 2020 21:29:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB3B2221FC for ; Thu, 19 Nov 2020 21:29:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZxU5zsIY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB3B2221FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfrUJ-0004Cj-PK for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 16:29:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfrTf-0003ha-KD for qemu-devel@nongnu.org; Thu, 19 Nov 2020 16:28:27 -0500 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfrTe-0002OK-3M for qemu-devel@nongnu.org; Thu, 19 Nov 2020 16:28:27 -0500 Received: by mail-pg1-x533.google.com with SMTP id q28so5420402pgk.1 for ; Thu, 19 Nov 2020 13:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Th2L+cxfAJKNpgfTu59OpahZ0MVv8mB13xXeHaN+YwM=; b=ZxU5zsIYOaz/NhRzZ4BzQTT9szU2cCa8lz5hX4qSIgv9j4BK0nNgAwS1NPOwllv1vb RpwVCbbNb1ro+plRLxl8Ca7RuCRGwfILOfNo+N3HIfK37hdKfh7s2+Drswk7G9cnM4Ib 1mTX79avZALi0loCWAydGezWHYQnLyPUzy4Gzy23gJTFD/HRxW7xK//BZs6rCuk4JkHk fVI8zXATvNY9DwF3lJzMQDHoF9KuZ5ZJl2eW0JYANWn4+W/hFiJCEhs9nwH2AawH/t4j Jrb2M/RWTnFrHTbiV432iy3WblowOO/UE+O+BoZAL09VkyJ30cSgPSIkvKfqLPRtuozg yxVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Th2L+cxfAJKNpgfTu59OpahZ0MVv8mB13xXeHaN+YwM=; b=pP7dihbxo5Ia0a07XaJ7bbxnQJgecZCW3LFW/k7EsZYbCv44FpvblNMJOcfqfU1CcT X8/wo80D3Ivy/dve6e3TUtg2F6r39aIVQJbqDTvUL+XFu0dE/zfoRBtwk/5K5/cMQ0zK hv7oaRJM2lsNl2eKjYhPMTpnEIYPpqXFWgxtJfvu/WQRT+4tPwmzwqAvfdSvHI/CHFly /gtxrYzBuXBmE40aLS4uNOClUv1/YR2eO5JoTc2TxDB2NOM2+Ue9zk3wZs2BFshgrcoL AOH+35B0gg72l7f8/6wOXov15FbwPUmQlvzI3bpewMhAZdAkDXlUslNdbS+CsRno6Tzg S7kA== X-Gm-Message-State: AOAM533KXrAAMq8X+cx+71zf9fBwgHHuz4e5arRXGqdhVHO/DQnrUDTU wFEz1V8Twn964TOfzni8vKltJg== X-Google-Smtp-Source: ABdhPJxzGGM0psQPBTqcT3wh5y8bXETiWoWITi5HO3k+cUopoBuAlm0sgFGZyUVQ9zOoYn7eTh4eYw== X-Received: by 2002:a17:90a:4884:: with SMTP id b4mr6301379pjh.198.1605821304741; Thu, 19 Nov 2020 13:28:24 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id in14sm647445pjb.57.2020.11.19.13.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 13:28:24 -0800 (PST) Subject: Re: [RFC 12/15] target/riscv: rvb: generalized or-combine To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-13-frank.chang@sifive.com> From: Richard Henderson Message-ID: <9c0a1551-1fe6-effc-231d-532b7fde548c@linaro.org> Date: Thu, 19 Nov 2020 13:28:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-13-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +static target_ulong do_gorc(target_ulong rs1, > + target_ulong rs2, > + const target_ulong masks[]) Similar comments to grev. I'll also say that the masks array should *not* be local to do_grev, but placed at file level so that it can be shared between the two functions. r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kfrTh-0003i3-8s for mharc-qemu-riscv@gnu.org; Thu, 19 Nov 2020 16:28:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfrTf-0003hZ-K9 for qemu-riscv@nongnu.org; Thu, 19 Nov 2020 16:28:27 -0500 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:41933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfrTe-0002ON-2k for qemu-riscv@nongnu.org; Thu, 19 Nov 2020 16:28:27 -0500 Received: by mail-pf1-x42c.google.com with SMTP id t8so5724391pfg.8 for ; Thu, 19 Nov 2020 13:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Th2L+cxfAJKNpgfTu59OpahZ0MVv8mB13xXeHaN+YwM=; b=ZxU5zsIYOaz/NhRzZ4BzQTT9szU2cCa8lz5hX4qSIgv9j4BK0nNgAwS1NPOwllv1vb RpwVCbbNb1ro+plRLxl8Ca7RuCRGwfILOfNo+N3HIfK37hdKfh7s2+Drswk7G9cnM4Ib 1mTX79avZALi0loCWAydGezWHYQnLyPUzy4Gzy23gJTFD/HRxW7xK//BZs6rCuk4JkHk fVI8zXATvNY9DwF3lJzMQDHoF9KuZ5ZJl2eW0JYANWn4+W/hFiJCEhs9nwH2AawH/t4j Jrb2M/RWTnFrHTbiV432iy3WblowOO/UE+O+BoZAL09VkyJ30cSgPSIkvKfqLPRtuozg yxVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Th2L+cxfAJKNpgfTu59OpahZ0MVv8mB13xXeHaN+YwM=; b=Aq+DSZp/J0haOD7bGi+ReewWQyJmJmfta5RqW7CsNcIqVWeMA3zfha+BRqJH7RqYM+ qIOeyDs0laEFlwul+BqMc2k43IONUE2WpOkWdI00zXGAgEBRMe8skHYuNyPGaPXFEt1p llW11xm1+xXu5pcKpPuwvf1VIy+SE3+UymalpD2y1bRbyyD0eBVCbNm+CahZ1oKlTQED xYz6jzaMFNjBfcNCsdWlfFfILvybb5N3H7AkJZHeVwA89J6WfyzLcAOP4MvkMG+iT/Mh C0eAqECC9ovkHTDzHcGnE2QhPXQq34LH9UHLkKf/+HWnIv5U3f9wwQQraOgBMNiC4at+ 7IqQ== X-Gm-Message-State: AOAM533JAC6jr+lvtj7B1J7EH6AyV4yLangV20ei1xWcybY8WfFcteWP dcJfyumFHuBCXRoEZeNEmjA86g== X-Google-Smtp-Source: ABdhPJxzGGM0psQPBTqcT3wh5y8bXETiWoWITi5HO3k+cUopoBuAlm0sgFGZyUVQ9zOoYn7eTh4eYw== X-Received: by 2002:a17:90a:4884:: with SMTP id b4mr6301379pjh.198.1605821304741; Thu, 19 Nov 2020 13:28:24 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id in14sm647445pjb.57.2020.11.19.13.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 13:28:24 -0800 (PST) Subject: Re: [RFC 12/15] target/riscv: rvb: generalized or-combine To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Sagar Karandikar , Bastian Koppelmann , Alistair Francis , Palmer Dabbelt , Kito Cheng References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-13-frank.chang@sifive.com> From: Richard Henderson Message-ID: <9c0a1551-1fe6-effc-231d-532b7fde548c@linaro.org> Date: Thu, 19 Nov 2020 13:28:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-13-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 21:28:27 -0000 On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +static target_ulong do_gorc(target_ulong rs1, > + target_ulong rs2, > + const target_ulong masks[]) Similar comments to grev. I'll also say that the masks array should *not* be local to do_grev, but placed at file level so that it can be shared between the two functions. r~