From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03557CA9EA1 for ; Fri, 18 Oct 2019 13:48:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA0C8222BD for ; Fri, 18 Oct 2019 13:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393929AbfJRNsT (ORCPT ); Fri, 18 Oct 2019 09:48:19 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:58330 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392604AbfJRNsS (ORCPT ); Fri, 18 Oct 2019 09:48:18 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iLSc4-00045S-Vf; Fri, 18 Oct 2019 15:48:17 +0200 Message-ID: <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> Subject: Re: [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Date: Fri, 18 Oct 2019 15:48:13 +0200 In-Reply-To: <87imomdvsj.fsf@toke.dk> References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-10-18 at 15:31 +0200, Toke Høiland-Jørgensen wrote: > Well, let's try to do the actual math... A full-size (1538 bytes) packet > takes ~2050 microseconds to transmit at 6 Mbps. Adding in overhead, it's > certainly still less that 4096 us, so 12 bits is plenty. What about A-MSDUs? But I guess maximum continous transmissions are at most 4ms anyway, so a single packet should never be longer. > That leaves > four bits for the ACK status ID if we just split the u16; if we only > ever have "a handful", that should be enough, no? It's how many are in flight at a time, 16 doesn't seem likely to happen, but I don't really know what applications are doing with it now. Probably only wpa_s for the EAPOL TX status. > We could also split 5/11. That would support up to 32 ACK IDs, and we > can just truncate the airtime at 2048 us, which is not a big deal I'd > say. We can also play with the units of the airtime, e.g. making that a multiple of 2 or 4 us? Seems unlikely to matter much? > Think it mostly depends on what is the smallest ID space for ACK IDs we > can live with? :) :) TBH, I don't really know. In a lot of hardware using this is really bad for performance so it shouldn't be used much, so ... johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLScA-0002Lj-C2 for ath10k@lists.infradead.org; Fri, 18 Oct 2019 13:48:24 +0000 Message-ID: <9fc60b546b54b40357264d67536733251cf39ebe.camel@sipsolutions.net> Subject: Re: [PATCH v2 1/4] mac80211: Rearrange ieee80211_tx_info to make room for tx_time_est From: Johannes Berg Date: Fri, 18 Oct 2019 15:48:13 +0200 In-Reply-To: <87imomdvsj.fsf@toke.dk> References: <157115993755.2500430.12214017471129215800.stgit@toke.dk> <157115993866.2500430.13989567853855880476.stgit@toke.dk> <87sgnqe4wg.fsf@toke.dk> <10b885b3238cede2d99c6134bebcc0c8ba6f6b10.camel@sipsolutions.net> <87imomdvsj.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Kan Yan Cc: Rajkumar Manoharan , Kevin Hayes , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau T24gRnJpLCAyMDE5LTEwLTE4IGF0IDE1OjMxICswMjAwLCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5z ZW4gd3JvdGU6Cgo+IFdlbGwsIGxldCdzIHRyeSB0byBkbyB0aGUgYWN0dWFsIG1hdGguLi4gQSBm dWxsLXNpemUgKDE1MzggYnl0ZXMpIHBhY2tldAo+IHRha2VzIH4yMDUwIG1pY3Jvc2Vjb25kcyB0 byB0cmFuc21pdCBhdCA2IE1icHMuIEFkZGluZyBpbiBvdmVyaGVhZCwgaXQncwo+IGNlcnRhaW5s eSBzdGlsbCBsZXNzIHRoYXQgNDA5NiB1cywgc28gMTIgYml0cyBpcyBwbGVudHkuCgpXaGF0IGFi b3V0IEEtTVNEVXM/IEJ1dCBJIGd1ZXNzIG1heGltdW0gY29udGlub3VzIHRyYW5zbWlzc2lvbnMg YXJlIGF0Cm1vc3QgNG1zIGFueXdheSwgc28gYSBzaW5nbGUgcGFja2V0IHNob3VsZCBuZXZlciBi ZSBsb25nZXIuCgo+IFRoYXQgbGVhdmVzCj4gZm91ciBiaXRzIGZvciB0aGUgQUNLIHN0YXR1cyBJ RCBpZiB3ZSBqdXN0IHNwbGl0IHRoZSB1MTY7IGlmIHdlIG9ubHkKPiBldmVyIGhhdmUgImEgaGFu ZGZ1bCIsIHRoYXQgc2hvdWxkIGJlIGVub3VnaCwgbm8/CgpJdCdzIGhvdyBtYW55IGFyZSBpbiBm bGlnaHQgYXQgYSB0aW1lLCAxNiBkb2Vzbid0IHNlZW0gbGlrZWx5IHRvIGhhcHBlbiwKYnV0IEkg ZG9uJ3QgcmVhbGx5IGtub3cgd2hhdCBhcHBsaWNhdGlvbnMgYXJlIGRvaW5nIHdpdGggaXQgbm93 LgpQcm9iYWJseSBvbmx5IHdwYV9zIGZvciB0aGUgRUFQT0wgVFggc3RhdHVzLgoKPiBXZSBjb3Vs ZCBhbHNvIHNwbGl0IDUvMTEuIFRoYXQgd291bGQgc3VwcG9ydCB1cCB0byAzMiBBQ0sgSURzLCBh bmQgd2UKPiBjYW4ganVzdCB0cnVuY2F0ZSB0aGUgYWlydGltZSBhdCAyMDQ4IHVzLCB3aGljaCBp cyBub3QgYSBiaWcgZGVhbCBJJ2QKPiBzYXkuCgpXZSBjYW4gYWxzbyBwbGF5IHdpdGggdGhlIHVu aXRzIG9mIHRoZSBhaXJ0aW1lLCBlLmcuIG1ha2luZyB0aGF0IGEKbXVsdGlwbGUgb2YgMiBvciA0 IHVzPyBTZWVtcyB1bmxpa2VseSB0byBtYXR0ZXIgbXVjaD8KCj4gVGhpbmsgaXQgbW9zdGx5IGRl cGVuZHMgb24gd2hhdCBpcyB0aGUgc21hbGxlc3QgSUQgc3BhY2UgZm9yIEFDSyBJRHMgd2UKPiBj YW4gbGl2ZSB3aXRoPyA6KQoKOikKClRCSCwgSSBkb24ndCByZWFsbHkga25vdy4gSW4gYSBsb3Qg b2YgaGFyZHdhcmUgdXNpbmcgdGhpcyBpcyByZWFsbHkgYmFkCmZvciBwZXJmb3JtYW5jZSBzbyBp dCBzaG91bGRuJ3QgYmUgdXNlZCBtdWNoLCBzbyAuLi4KCmpvaGFubmVzCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAph dGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2F0aDEwawo=