From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752283AbbC0KST (ORCPT ); Fri, 27 Mar 2015 06:18:19 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:36988 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750819AbbC0KSR (ORCPT ); Fri, 27 Mar 2015 06:18:17 -0400 From: Punit Agrawal To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Stephen Warren , Mikko Perttunen , kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/13] thermal: Make temperatures consistently unsigned long References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> Date: Fri, 27 Mar 2015 10:18:14 +0000 In-Reply-To: <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Thu, 26 Mar 2015 16:53:48 +0100") Message-ID: <9hhzj6y217d.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sascha, Sascha Hauer writes: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell. > > Signed-off-by: Sascha Hauer I'd suggest changing to long instead. It would allow the use of the thermal framework in environments where temperatures are below 0C - quite easily reached in many parts of the world. Regards, Punit > --- > drivers/thermal/thermal_core.c | 10 +++++----- > include/linux/thermal.h | 6 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-) > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 From: punit.agrawal@arm.com (Punit Agrawal) Date: Fri, 27 Mar 2015 10:18:14 +0000 Subject: [PATCH 01/13] thermal: Make temperatures consistently unsigned long In-Reply-To: <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Thu, 26 Mar 2015 16:53:48 +0100") References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-2-git-send-email-s.hauer@pengutronix.de> Message-ID: <9hhzj6y217d.fsf@e105922-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sascha, Sascha Hauer writes: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell. > > Signed-off-by: Sascha Hauer I'd suggest changing to long instead. It would allow the use of the thermal framework in environments where temperatures are below 0C - quite easily reached in many parts of the world. Regards, Punit > --- > drivers/thermal/thermal_core.c | 10 +++++----- > include/linux/thermal.h | 6 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-) > [...]