From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Bligh Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack Date: Wed, 14 Sep 2011 09:01:34 +0100 Message-ID: References: <2184C0CE5A5EDC94CDDA5053@Ximines.local> <20110912072524.GA2996@p183.telecom.by> <20110912093749.GE2194@1984> <20110912183357.GC3641@1984> <87A32B21CA99D62CE1AB7A4B@Ximines.local> <7631498AC7E7C0EAD641AC7D@nimrod.local> <20110914013500.GB17051@1984> Reply-To: Alex Bligh Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110914013500.GB17051@1984> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Pablo Neira Ayuso Cc: Alexey Dobriyan , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Linux Containers , Alex Bligh List-Id: containers.vger.kernel.org --On 14 September 2011 03:35:00 +0200 Pablo Neira Ayuso wrote: >> Is this new version OK? I am happy to adjust if not. > > Hm, I still think that this is a workaround. It is a bit of a workaround, that is true. But it is a workaround that will fix the bug in every kernel since 2.6.32 (and perhaps before - I haven't looked). It's thus reasonably easily applicable to stable kernel series. I'm not clued-up enough on Netfilter to know what the right fix is, but is applying the workaround in a commit which could be easily backported, then applying the 'right fix' (assuming that is different) a reasonable strategy? As you can probably tell, my interest here is to get something that doesn't oops into stable kernels. -- Alex Bligh