From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EACC282C0 for ; Wed, 23 Jan 2019 10:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0410C21019 for ; Wed, 23 Jan 2019 10:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="MNZd1j/H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727136AbfAWKRc (ORCPT ); Wed, 23 Jan 2019 05:17:32 -0500 Received: from mail-eopbgr40041.outbound.protection.outlook.com ([40.107.4.41]:32112 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726682AbfAWKRc (ORCPT ); Wed, 23 Jan 2019 05:17:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=muBU/FIGWBkbufGSjgK1ueKZJq28CbthuvjSyOY+554=; b=MNZd1j/HgfjIMrfzDvI+6lsPjWDPP+XFV1LliCv+mtjQvHDs+Xj7j/vzk5Dp2SIN5WW8HjWkSUIfLHl4jNFtf2yITgWpYWDL+ccFkH5rR82pEcO7gS9glOtZ+baFRWMh93M2Iqx2PpNULafS88rMb+73trTzWaCUg+K5aobvfd4= Received: from AM6PR05MB5879.eurprd05.prod.outlook.com (20.179.0.76) by AM6PR05MB5144.eurprd05.prod.outlook.com (20.177.191.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Wed, 23 Jan 2019 10:17:26 +0000 Received: from AM6PR05MB5879.eurprd05.prod.outlook.com ([fe80::210c:168f:7b52:a165]) by AM6PR05MB5879.eurprd05.prod.outlook.com ([fe80::210c:168f:7b52:a165%4]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 10:17:26 +0000 From: Maxim Mikityanskiy To: Willem de Bruijn , "David S. Miller" CC: "netdev@vger.kernel.org" , Saeed Mahameed , Eran Ben Elisha , Tariq Toukan , Jason Wang , Eric Dumazet Subject: RE: [PATCH 0/7] AF_PACKET transport_offset fix Thread-Topic: [PATCH 0/7] AF_PACKET transport_offset fix Thread-Index: AQHUrAuzAIAMP364z0eAtMl9sGwnfaW8rMSw Date: Wed, 23 Jan 2019 10:16:43 +0000 Deferred-Delivery: Wed, 23 Jan 2019 10:16:07 +0000 Message-ID: References: <20190114131841.1932-1-maximmi@mellanox.com> In-Reply-To: <20190114131841.1932-1-maximmi@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=maximmi@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR05MB5144;6:RXidbCrU7Im+SPmpS8gwP1U8Fx9jTeTqdVBHEzst9+zKhSG9dn2iyWr86JTBiLEPtcKk0XbBMmDmJHuMnUoPk6drzejHgfwvdGHcAfUyaklku/KKOyKKxv08kNdRyl/sP6AEO7vbKBNdUGRkAMU0o8t0Xf2yCUZ4qepc7FXrIuE2lU0Bt2Tb9m03a45Dy0n210frmGyWQl0DSdu/arTGYaeAaYMTes43J+tvM9Qe+8d04g34oRBvBz4/DhKJyP85pO1zCla77dbHMfI0Nr+2N8DSnOAmaaHujX0xdVz1MjkOf7j7MgccN3H0owS+BB3LstScbqGpwgLypz6KgYfDjWypueUMMiScK5QbZTYFzHIHEd5xKM9qdZ8f2VFVnpZBIJmyfRsbfxJ93dJFlE02skh4T932i7lNdFsRYtJSz3OnHDQAyomJDOvJoxKSi6ywp2YSCtHnjG2nwcTebXeV9w==;5:9aehGG+YNK0c+tfF+ZlD0JG/f1nnbSUlsh2opaTYKKLqLtfAwYaoay4yQN4pzGRUdEvQNbMikIsruXXmb/wZKyX6w+a7ayJIG3ko0gFCTVcVB+okrX4ZPWGLex5HZQG3aIJefNA8sVaoBR33Gu9AldcS/iyp1iIzedxFF+MoSuV7UDr4MKgCwQmHAUxFI0i8O1EsXooHedZY8MqcB/hHGQ==;7:lN7KW5nNYsEJdVsSsakvXvKFzKRjRJDO51cx6pSLrJJKJ03RfaUSKLz04gRSPnUBH5OyXBfb83DF0BzevsOAjKvHkPWIDbR8BT6JCv8zCadFO+bSv86ZXBLW2YFgqoQIhAsHi6IqMRElF1uMSD8E/g== x-ms-office365-filtering-correlation-id: 5b2a1a52-7e6b-478f-4bf6-08d6811bf975 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB5144; x-ms-traffictypediagnostic: AM6PR05MB5144: x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(396003)(39860400002)(346002)(376002)(366004)(13464003)(199004)(189003)(8676002)(2906002)(476003)(229853002)(6666004)(478600001)(81166006)(33656002)(105586002)(81156014)(11346002)(486006)(97736004)(6436002)(55016002)(9686003)(6306002)(446003)(86362001)(25786009)(106356001)(8936002)(4326008)(53936002)(256004)(71200400001)(316002)(6116002)(102836004)(7696005)(66066001)(71190400001)(6246003)(53546011)(6506007)(26005)(3846002)(7736002)(68736007)(76176011)(966005)(74316002)(54906003)(110136005)(305945005)(14454004)(99286004)(186003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB5144;H:AM6PR05MB5879.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mvWhwiW+YK3AGc9dJ0Z3TfXD2dAIkMZMr7KqXTxi+93kkDRFJWlR1+eYlJ/tZ7eP9vK7j8/J8PlmnOEtXxm2e3tjzpwLDJorRR4fXIzF7YPkrUqFC9aTtQzpu5rQRfpPScyFlSGWXOg+EdmdZhPVB44bFTq41ZUwIkt6Fr+gqVDgMgdbRB2wlpaQ6ritqpRyrTAf3USNG1W5BZB55+FziTmImqP9nZafgXH7VplmX961JOLo+1s1Yp8fiwhqsDO6xMg51nOYLWNnnplKClUZex6WvG8OISQzdzC9d6HuHmJk9lL1Y6GZiqKqkNRYBB1jEuFkdciUbYC9KwzoRDgJqOXhe+ieOi2UZqpstZtAOtCE5xe7yWvnvnNsYzXX7TObAFnUfhzWCLhUsH5+u76guXz8O7aMPNlTqhEYo8AuyH0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b2a1a52-7e6b-478f-4bf6-08d6811bf975 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 10:17:03.1157 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5144 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org >From my perspective, after the discussion we had with Willem, the current version of this series can be merged to net-next. Willem, do you approve it? Thanks for reviewing! > -----Original Message----- > From: Maxim Mikityanskiy > Sent: 14 January, 2019 15:19 > To: David S. Miller ; Saeed Mahameed > ; Willem de Bruijn ; Jason Wang > ; Eric Dumazet > Cc: netdev@vger.kernel.org; Eran Ben Elisha ; Tariq > Toukan ; Maxim Mikityanskiy > Subject: [PATCH 0/7] AF_PACKET transport_offset fix >=20 > This patch series contains the implementation of the RFC that was posted > on this mailing list previously: > https://www.spinics.net/lists/netdev/msg541709.html >=20 > It fixes having incorrect skb->transport_header values in cases when > dissect fails. Having correct values set by the kernel fixes mlx5 > operation and allows to remove some unnecessary code flows in mlx5. >=20 > Maxim Mikityanskiy (7): > net: Don't set transport offset to invalid value > net: Introduce parse_protocol header_ops callback > net/ethernet: Add parse_protocol header_ops support > net/packet: Ask driver for protocol if not provided by user > net/packet: Remove redundant skb->protocol set > net/mlx5e: Remove the wrong assumption about transport offset > net/mlx5e: Trust kernel regarding transport offset >=20 > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++--------- > drivers/net/tap.c | 4 +-- > drivers/net/tun.c | 4 +-- > drivers/net/xen-netback/netback.c | 19 ++++++++------ > include/linux/etherdevice.h | 1 + > include/linux/netdevice.h | 10 +++++++ > include/linux/skbuff.h | 14 +++++----- > net/ethernet/eth.c | 13 ++++++++++ > net/packet/af_packet.c | 26 +++++++++---------- > 9 files changed, 60 insertions(+), 46 deletions(-) >=20 > -- > 2.19.1