From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shlomo.pongratz@huawei.com>) id 1Ys8QG-0000Kp-Ls
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:32:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shlomo.pongratz@huawei.com>) id 1Ys8QC-0000WP-LR
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:32:28 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:51888)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shlomo.pongratz@huawei.com>) id 1Ys8QC-0000Tu-2S
	for qemu-devel@nongnu.org; Tue, 12 May 2015 07:32:24 -0400
From: Shlomo Pongratz <shlomo.pongratz@huawei.com>
Date: Tue, 12 May 2015 11:29:42 +0000
Message-ID: <B5C21809C482C148A58516F588CD431466E40E@szxeml557-mbx.china.huawei.com>
References: <00c901d08990$2763c410$762b4c30$@samsung.com>
	<B5C21809C482C148A58516F588CD431466D281@szxeml557-mbx.china.huawei.com>
	<034301d08c92$dccf6e80$966e4b80$@samsung.com>
In-Reply-To: <034301d08c92$dccf6e80$966e4b80$@samsung.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

> -----Original Message-----
> From: Pavel Fedin [mailto:p.fedin@samsung.com]
> Sent: Tuesday, 12 May, 2015 12:06 PM
> To: Shlomo Pongratz; qemu-devel@nongnu.org
> Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500
>=20
>  Hello!
>=20
> > I just pulled last git and git am-ed your patch on-top of my first 3
> > patches and got
> this error:
> > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function
> 'fdt_add_gic_node':
> > /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error:
> > 'KVM_DEV_TYPE_ARM_VGIC_V3' undeclared (first use in this function)
> >      if (type =3D=3D KVM_DEV_TYPE_ARM_VGIC_V3) {
>=20
>  Very strange. Check your source tree. This value is declared in linux-
> headers/linux/kvm.h. Try to #include it directly maybe ? OTOH it perfectl=
y
> works for me, i have just verified, i have no extra #include's which coul=
d be
> missing from the patch.
>  But, may be something has changed in master over the last three days?
> Actually my base tree is from friday.
>=20
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>=20

Hi Pavel,

I did include "linux/kvm.h" which fixed the issue.
But as I wrote I did "git pull" before applying the patches, so it is stran=
ge.

BTW did you try going beyond 16 cores I had problems with 32 and 64 cores.

Best regards,

S.P.