From: "Yu, Jin" <jin.yu@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix compile error
Date: Wed, 30 Oct 2019 01:41:56 +0000 [thread overview]
Message-ID: <B9FBC361811A3D4DBB02350807E29F7B0B97FEF5@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191029133544.GA18351@___>
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Tuesday, October 29, 2019 9:36 PM
> To: Yu, Jin <jin.yu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] vhost: fix compile error
>
> On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need
> > the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 356
> > Cc: stable@dpdk.org
>
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Thanks.
>
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> > lib/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile index 41c463d92..a30accb29
> > 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=
> librte_rawdev
> > DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost DEPDIRS-librte_vhost
> > := librte_eal librte_mempool librte_mbuf librte_ethdev \
> > - librte_net
> > + librte_net librte_hash
>
> Do we also depend on cryptodev (rte_cryptodev.h)?
Yes, but luckily we didn't meet this error, it seems librte_cryptodev always compile before vhost. Ok, I will add it too.
Thanks.
>
> > DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash DEPDIRS-librte_hash :=
> > librte_eal librte_ring
> > DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> > --
> > 2.17.2
> >
next prev parent reply other threads:[~2019-10-30 1:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
2019-10-30 1:41 ` Yu, Jin [this message]
2019-10-30 9:37 ` [dpdk-dev] " Jin Yu
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-11-04 4:41 ` Tiwei Bie
2019-11-06 19:52 ` Maxime Coquelin
2019-11-06 19:59 ` Maxime Coquelin
2019-11-06 20:05 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-06 20:30 ` Maxime Coquelin
2019-11-06 20:59 ` [dpdk-dev] " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9FBC361811A3D4DBB02350807E29F7B0B97FEF5@SHSMSX101.ccr.corp.intel.com \
--to=jin.yu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.