All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: "Dave Airlie" <airlied@redhat.com>,
	"Marek Olšák" <maraeo@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Latest merge of 'drm-radeon-fixes' breaks my setup
Date: Wed, 8 Jun 2011 20:09:33 +1000	[thread overview]
Message-ID: <BANLkTinfn82C3TjPxzZuD+v=F+uCx8pmyg@mail.gmail.com> (raw)
In-Reply-To: <20110608054354.GA1717@x4.trippels.de>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Wed, Jun 8, 2011 at 3:43 PM, Markus Trippelsdorf
<markus@trippelsdorf.de> wrote:
> On 2011.06.08 at 07:40 +0200, Markus Trippelsdorf wrote:
>> The merge of the 'drm-radeon' branch by Linus yesterday breaks my setup
>> (RS780). The mouse cursor is just a black block suddenly and I see an
>> endless stream of:
>>  radeon 0000:01:05.0: r600_check_texture_resource:1338 texture invalid format 26
>>  [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

This is wierd, can you try the attached patch, it appears this
uncovered another bug.

Dave.

[-- Attachment #2: 0001-drm-radeon-kms-set-family-for-use-in-parser.patch --]
[-- Type: text/x-patch, Size: 1075 bytes --]

From 87a130763e7a17e61cc18a7279d31b58b7bdf5b2 Mon Sep 17 00:00:00 2001
From: Dave Airlie <airlied@redhat.com>
Date: Wed, 8 Jun 2011 19:58:29 +1000
Subject: [PATCH] drm/radeon/kms: set family for use in parser.

Wierdly the kms parser never initialised the family, it wasn't really used
much, but the fmt checker patch started using it and it fell over.

Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_cs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 8c19169..fae00c0 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -228,6 +228,7 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
 	parser.filp = filp;
 	parser.rdev = rdev;
 	parser.dev = rdev->dev;
+	parser.family = rdev->family;
 	r = radeon_cs_parser_init(&parser, data);
 	if (r) {
 		DRM_ERROR("Failed to initialize parser !\n");
-- 
1.7.5.2


  reply	other threads:[~2011-06-08 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  5:40 Latest merge of 'drm-radeon-fixes' breaks my setup Markus Trippelsdorf
2011-06-08  5:43 ` Markus Trippelsdorf
2011-06-08 10:09   ` Dave Airlie [this message]
2011-06-08 10:26     ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTinfn82C3TjPxzZuD+v=F+uCx8pmyg@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maraeo@gmail.com \
    --cc=markus@trippelsdorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.