From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YruuI-0002fQ-7r for qemu-devel@nongnu.org; Mon, 11 May 2015 17:06:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YruuD-0000L7-5q for qemu-devel@nongnu.org; Mon, 11 May 2015 17:06:34 -0400 Received: from blu004-omc1s6.hotmail.com ([65.55.116.17]:64441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YruuD-0000Ks-2m for qemu-devel@nongnu.org; Mon, 11 May 2015 17:06:29 -0400 Message-ID: Date: Tue, 12 May 2015 05:06:53 +0800 From: Chen Gang MIME-Version: 1.0 References: <5550D270.4020202@twiddle.net> In-Reply-To: <5550D270.4020202@twiddle.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/10 v10] target-tilegx/opcode_tilegx.h: Modify it to fit qemu using List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Chris Metcalf Cc: "walt@tilera.com" , Riku Voipio , qemu-devel On 5/12/15 00:01, Richard Henderson wrote: > On 05/10/2015 03:42 PM, Chen Gang wrote: >> -static __inline unsigned int >> +static inline uint8_t >> get_BFEnd_X0(tilegx_bundle_bits num) > > Do not change these casts to uint8_t. It's unnecessary churn. > For me, it is enough to return uint8_t, and the caller really treats it as uint8_t. So for the function declaration, uint8_t is more precise than unsigned int for return type. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed