From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sharma Bhupesh Subject: RE: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode Date: Thu, 10 Dec 2015 11:05:49 +0000 Message-ID: References: <1431603215-25546-1-git-send-email-bhupesh.sharma@freescale.com> <1431603215-25546-6-git-send-email-bhupesh.sharma@freescale.com> <5554C244.80809@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mail-bl2on0129.outbound.protection.outlook.com ([65.55.169.129]:23691 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752356AbbLJLFx convert rfc822-to-8bit (ORCPT ); Thu, 10 Dec 2015 06:05:53 -0500 In-Reply-To: Content-Language: en-US Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde , "arnd@arndb.de" , "linux-can@vger.kernel.org" Cc: "bhupesh.linux@gmail.com" , "linux-arm-kernel@lists.infradead.org" , Arora Sakar Hi Mark, > -----Original Message----- > From: linux-arm-kernel [mailto:linux-arm-kernel- > bounces@lists.infradead.org] On Behalf Of Sharma Bhupesh > Sent: Thursday, May 14, 2015 9:14 PM > To: Marc Kleine-Budde; arnd@arndb.de; linux-can@vger.kernel.org > Cc: bhupesh.linux@gmail.com; linux-arm-kernel@lists.infradead.org; Arora > Sakar-B45205 > Subject: RE: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO > mode > > > -----Original Message----- > > From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] > > Sent: Thursday, May 14, 2015 9:12 PM > > To: Sharma Bhupesh-B45370; arnd@arndb.de; linux-can@vger.kernel.org > > Cc: bhupesh.linux@gmail.com; Arora Sakar-B45205; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO > > mode > > > > On 05/14/2015 01:33 PM, Bhupesh Sharma wrote: > > > This patch adds support for non RX-FIFO (legacy) mode in the flexcan > > > driver. > > > > > > On certain SoCs, the RX-FIFO support might be broken, as a result we > > > need to fall-back on the legacy (non RX-FIFO) mode to receive CAN > > > frames. > > > > > > Signed-off-by: Bhupesh Sharma > > > Signed-off-by: Sakar Arora > > > > The non FIFO mode doesn't guarantee the order of the incoming frames, > > not does not even try to...this is not acceptable. I'm currently > > working on a patch by David Jander that brings in non FIFO mode, but > > tries to keep the order of the frames. > > That is already WIP at our end. V3 will contain the same change. > If you are already working on it, I don't know how to proceed further as > we had already v1 of this patchset with the non FIFO mode out since a > month or so. I don't remember seeing a patch from you which supports non-FIFO mode for flexcan IP. Since we now have Freescale LS1021A chip out in the field on which the FIFO mode broken, we cannot use the upstream flexcan driver for enabling flexcan IP on these chips. Do you still have plans to work on this? Or should I submit my v3 with in-order reception supported for rx frames. Regards, Bhupesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: bhupesh.sharma@freescale.com (Sharma Bhupesh) Date: Thu, 10 Dec 2015 11:05:49 +0000 Subject: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode In-Reply-To: References: <1431603215-25546-1-git-send-email-bhupesh.sharma@freescale.com> <1431603215-25546-6-git-send-email-bhupesh.sharma@freescale.com> <5554C244.80809@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, > -----Original Message----- > From: linux-arm-kernel [mailto:linux-arm-kernel- > bounces at lists.infradead.org] On Behalf Of Sharma Bhupesh > Sent: Thursday, May 14, 2015 9:14 PM > To: Marc Kleine-Budde; arnd at arndb.de; linux-can at vger.kernel.org > Cc: bhupesh.linux at gmail.com; linux-arm-kernel at lists.infradead.org; Arora > Sakar-B45205 > Subject: RE: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO > mode > > > -----Original Message----- > > From: Marc Kleine-Budde [mailto:mkl at pengutronix.de] > > Sent: Thursday, May 14, 2015 9:12 PM > > To: Sharma Bhupesh-B45370; arnd at arndb.de; linux-can at vger.kernel.org > > Cc: bhupesh.linux at gmail.com; Arora Sakar-B45205; linux-arm- > > kernel at lists.infradead.org > > Subject: Re: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO > > mode > > > > On 05/14/2015 01:33 PM, Bhupesh Sharma wrote: > > > This patch adds support for non RX-FIFO (legacy) mode in the flexcan > > > driver. > > > > > > On certain SoCs, the RX-FIFO support might be broken, as a result we > > > need to fall-back on the legacy (non RX-FIFO) mode to receive CAN > > > frames. > > > > > > Signed-off-by: Bhupesh Sharma > > > Signed-off-by: Sakar Arora > > > > The non FIFO mode doesn't guarantee the order of the incoming frames, > > not does not even try to...this is not acceptable. I'm currently > > working on a patch by David Jander that brings in non FIFO mode, but > > tries to keep the order of the frames. > > That is already WIP at our end. V3 will contain the same change. > If you are already working on it, I don't know how to proceed further as > we had already v1 of this patchset with the non FIFO mode out since a > month or so. I don't remember seeing a patch from you which supports non-FIFO mode for flexcan IP. Since we now have Freescale LS1021A chip out in the field on which the FIFO mode broken, we cannot use the upstream flexcan driver for enabling flexcan IP on these chips. Do you still have plans to work on this? Or should I submit my v3 with in-order reception supported for rx frames. Regards, Bhupesh