RE: [PATCH 1/1] Updated comment accuracy in PSP SOS/Sysdriver loading sequence to target bootloader instead of bootrom

["Huang, Ray" <Ray.Huang-5C7GfCeVMHo@public.gmane.org>]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of John Clements
> Sent: Tuesday, October 16, 2018 9:23 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: John Clements <clements.jm@gmail.com>
> Subject: [PATCH 1/1] Updated comment accuracy in PSP SOS/Sysdriver
> loading sequence to target bootloader instead of bootrom
> 
> From: John Clements <clements.jm@gmail.com>
> 

The commit message should not be empty, please add a line of words even like "refine the comments for PSP".

With that fixed, patch is Reviewed-by: Huang Rui <ray.huang@amd.com>

> Signed-off-by: John Clements <clements.jm@gmail.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index b70cfa3fe1b2..3fe30eb46d26 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct
> psp_context *psp)
>  	/* Copy PSP System Driver binary to memory */
>  	memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size);
> 
> -	/* Provide the sys driver to bootrom */
> +	/* Provide the sys driver to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 1 << 16;
> @@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct
> psp_context *psp)
>  	/* Copy Secure OS binary to PSP memory */
>  	memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size);
> 
> -	/* Provide the PSP secure OS to bootrom */
> +	/* Provide the PSP secure OS to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 2 << 16;
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> index e1ebf770c303..9cea0bbe4525 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> @@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct
> psp_context *psp)
>  	/* Copy PSP System Driver binary to memory */
>  	memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size);
> 
> -	/* Provide the sys driver to bootrom */
> +	/* Provide the sys driver to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 1 << 16;
> @@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct
> psp_context *psp)
>  	/* Copy Secure OS binary to PSP memory */
>  	memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size);
> 
> -	/* Provide the PSP secure OS to bootrom */
> +	/* Provide the PSP secure OS to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 2 << 16;
> --
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx