From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28ACC433EF for ; Fri, 17 Sep 2021 11:50:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF2A16124D for ; Fri, 17 Sep 2021 11:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF2A16124D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6457282DA1; Fri, 17 Sep 2021 13:50:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="GVnjgUe3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 111BC831C8; Fri, 17 Sep 2021 13:50:00 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20619.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 20CC682BF6 for ; Fri, 17 Sep 2021 13:49:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tkarthik@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j37kwR6WaunLKkaZR7MP/qUtU8MzpNd4EGTvOQq+ierpfR3bTZntNRkhB6U/tOwjTQJrs2n8vyhwF5vdoYzmcgllbTeo+X+StN2Tx48eagPg4zaBGU2MGk40oF0hDR91zxFun1iJw0mIDPoSdvUyJNowkYnd3y5Miwf1FcA+W1VpOuQexp7+ePOZHbUmN1+HBXRmy+/1QqDYgxdEkC3tvULEATk7ANA5w4RyL6SCQZPuzNh0GF+wAxM1cyx6rPoPd15rqo7WuEgD7QP1ZJ5oDHoXKLXJc47471/sj22scV7z4/ng77pYOK/z0Bf+ns8Y3in1dkahpU65hTw/WCMsrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5gv90cX48fMphoO+1x8epbES9oUhWbrR5osUxdjwS+Y=; b=HNuI+qD3RzJ6++h+SSpqC5Scq+1dv5tVHdSfeCUHnQXRPFwA0NpE95iNREkJFcvJTjhLR20+PlT3RLVstDYf6WtabiMBFnQDZSuPKIUY03A8hkeF2EjOCgGYQDNtsJOY+2LdC05n1GkFEC05iAR/5t8JJub2fu6eQtRdYwDYkzP+5CkHWaTMXYALoyfx7hX/BAVlVu8f3kCl+wTNoGDWAb/0JDSX3wXyGyoaEyXfs2+bO0334n3z359AJrKiNBJQ4SWyCZsqNYon+X9BWBDdvj/nklrcXMM6mQqGiLYhXNQCl3FTHw77R3zzywqanELXgQzCyjDhfB86cfJwj4+JbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5gv90cX48fMphoO+1x8epbES9oUhWbrR5osUxdjwS+Y=; b=GVnjgUe35LdagXoI897qXZoYyzaaH7jY6KeIt07If2gukK9pA2wGBIiLCPIAu2cdjHUeoy3/tycSp2vYjAl0LgLqBP+wn+ilL7MU3B9sKt2W+y7TZWjxotLE1Lbys3md11QRO+C7iLAZcTDMsgeqVadxxRSRX0/fJmscB/Y/4Zw= Received: from BY5PR02MB6739.namprd02.prod.outlook.com (2603:10b6:a03:208::7) by SJ0PR02MB7197.namprd02.prod.outlook.com (2603:10b6:a03:293::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Fri, 17 Sep 2021 11:49:52 +0000 Received: from BY5PR02MB6739.namprd02.prod.outlook.com ([fe80::50e2:c685:286b:b98]) by BY5PR02MB6739.namprd02.prod.outlook.com ([fe80::50e2:c685:286b:b98%3]) with mapi id 15.20.4500.018; Fri, 17 Sep 2021 11:49:51 +0000 From: T Karthik Reddy To: Tom Rini CC: Ashok Reddy Soma , "u-boot@lists.denx.de" , "miquel.raynal@bootlin.com" , git Subject: RE: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable Thread-Topic: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable Thread-Index: AQHXf7zcG8RBxQl0XEerxBk7RtYo66tjiWmAgADS82CAAJ4fAIBB6W0w Date: Fri, 17 Sep 2021 11:49:51 +0000 Message-ID: References: <20210723121826.23072-1-ashok.reddy.soma@xilinx.com> <20210804152149.GB9379@bill-the-cat> <20210805132246.GJ858@bill-the-cat> In-Reply-To: <20210805132246.GJ858@bill-the-cat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=xilinx.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43556b97-8bc3-45bd-87c4-08d979d14265 x-ms-traffictypediagnostic: SJ0PR02MB7197: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vaTzcBbXVgtIR2o9RxD5o+BkzvUQPMn5kavKojotUyniUzhTJMoUHvMD1KB1J9ux08GrozNKqvNL5Qbz0XdaYav4rUyqwPxfwbT7r/mBYjc/24j7diQUmwsWLM3C3ymmEq3pK733X1luFCQZ0YA02LMHqvMx/pjMzODqpL6xx7KtI3ZU7NA1hKHGMuW1jRI3h9u10gxuZbS6WXnGc4qg2KWDDDK2NeOIWb7NRsN/9cX95IrOQn7en5Ti+joX+tADwDeGXj0+Aas7BOGouPpk6ti5xYrGlTy95ZufLGYaXX7DMKWcjt6zJ1m72OmWjlkiym6dwC5Dq4HKRT0hTXjfQ8dzIKbxMHZmHSOA9d5InviGkNeR/1ykuy4XAWplxcMeAVl1VJ1EWz92ckap3bqDzmhDIH7/F0gRrcTqx976zARnD3hNPXSUrtJw4p0GHQdqHPc/3YDIQFE4Asix1TXfFcnJG85xLN5p7SiJaUKHcC3xH/q+g8mytLehqL0ZsU+3Z1KuRsGnCyPMXxb5Zl2GhTG8b0iKtZiFwlaLQ2kYtAoPRzuXCqg7srnfZFSvLMu2pe74SjKmFFma5oC3FnPnwIZcF2lRkbsNdMukbjdrXw80TLXxV6pR1K5BQ2w4oAYnDuBNlzPnKFzfiqWu+HUCZBND7UbEaM7GkTLjKGnivb4+QoBbGTWIQ8TFKF2X6cwcoa+xwW13hQNEUIqy5vnyNQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR02MB6739.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(9686003)(186003)(66556008)(66946007)(66476007)(66446008)(64756008)(26005)(4326008)(8936002)(55016002)(83380400001)(71200400001)(8676002)(107886003)(38070700005)(6916009)(478600001)(2906002)(76116006)(122000001)(86362001)(5660300002)(6506007)(53546011)(54906003)(316002)(52536014)(7696005)(33656002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?Gyi22qfpBjDhM7MJ/CyVYJXty1UiBXLVSxnBRZYnu2xi2xYMtnEySbc3?= =?Windows-1252?Q?mCvFWdXdbAya68JizAjfcsHUJgLjKgeAy16Z6J+5jMidADfjhAU/qjI2?= =?Windows-1252?Q?fo6mcfeXGMdAcbV+IIDBNxNuE/qF8TlHtDTiro6vLCOQ30g4NuZGaoDO?= =?Windows-1252?Q?kqJJW2bS0YKvUFOEkW379e9VfaRapAkY2tReRZeFcztvIOrYqSywxDDP?= =?Windows-1252?Q?f7YvnJvszgdu3P1EKEoX2srucqMaviFtKx8kTfZNRyLLgzsew6P8YXZk?= =?Windows-1252?Q?g63uEzirvPIV3bLNXI2FNuh16xqMmh6eeeBWX9qRW3GDnjCFOnV34EHn?= =?Windows-1252?Q?x6TR7jsCZTq0YC8Rhga6dp+PZXpk2XJJ2nqv1fSqtmrsDWNPwc/aXetZ?= =?Windows-1252?Q?8hALnVzaKXeW5MHycIrKZpmKMEAbb56GwqUJ3MrBNIx95D8+xz1W7l/C?= =?Windows-1252?Q?ynjsgoDekTGeqYeNu8vU7K9in8owNUiYdlp8a8EVcCs4D/ASVF0C4Kso?= =?Windows-1252?Q?VTzEtgjHqrTbP+0P5iS4g7OSNyME6QdWsAQhQlxyD1w5ST+p+pqF30zN?= =?Windows-1252?Q?1LpwKkHwM+/gJsF8DglDd6LNG3QbQtEpkhYdSo45ccJKx0Qmf2lNRR6j?= =?Windows-1252?Q?Y5NKMDZAxhYbjUB1MNt6CgWBaof4dcRu5E1T12+eXwmSNzJX4Vc0f9E3?= =?Windows-1252?Q?bbDX75MshBMu70KZ24ThqrZf4qO4X0YhDTiSoHkdcKVoSa4OFkKdPgQO?= =?Windows-1252?Q?nH9fhXalOF3Y8hLjmkd3T29YZL3X8SH+4xB24MEUVTMh54AILKNVhQYb?= =?Windows-1252?Q?kKmqk2+Q6sUBasaxuHkd+J+7xauh7sawzY0W1OE98KzJl2SD3sVraPtl?= =?Windows-1252?Q?XvuxpBNbku1kOpW3BK5N79GKraoV7BSTz6f4/ngX501/XF/YDkwA4144?= =?Windows-1252?Q?fZ5HgEfVXSQV0QtvOij1qoGmOkzi1dHYaM7kj/isZKWqWMF7OXE4i5Xf?= =?Windows-1252?Q?2LYsOlQrF/DogU2OTbkd2CJdDegSRR6qPzWOZ3OwJwIJEKdNueaPjd4W?= =?Windows-1252?Q?I8jkvj92oGcEeeU3xyNzmjEAP7rVyt4AC8JM/2ub3KzBMxoJfRv/79g5?= =?Windows-1252?Q?zJ/pQ6lKbGBfy0f2K8kC3dX5ozTOh1kUdBb+jJuRxFgvQZcxf+/1KyjE?= =?Windows-1252?Q?BcTv1hJaIV81K4r9XAQYoqCh3PZOyNxSb4/gys82LCUPX/7130puHfle?= =?Windows-1252?Q?s/5fOYfI4B5r39D0ztIEDnMLBiu1SRJHd+j9EtFNIgJZE9v8BZvjCD2U?= =?Windows-1252?Q?Duq6WL9jhb1r6V12pTv0aUKXrmpi591K6KqvRmYrstoC64JqJTmSVadE?= =?Windows-1252?Q?21xiwWTmrP5Psx8MVJ7s6y1FItD5UbMI1oeW41HGXG8+8qjSxzGaW6uK?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR02MB6739.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43556b97-8bc3-45bd-87c4-08d979d14265 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2021 11:49:51.6710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qMTIoUPFqKzznZd/hytHn99wJ9yTWEMMuwy4opXuNcDYZ9XY89ezEs5j4wdap00TLx7cf7SVnteozt/8kJpXtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7197 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, > -----Original Message----- > From: Tom Rini > Sent: Thursday, August 5, 2021 6:53 PM > To: T Karthik Reddy > Cc: Ashok Reddy Soma ; u-boot@lists.denx.de; > miquel.raynal@bootlin.com; git > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable >=20 > On Thu, Aug 05, 2021 at 05:56:50AM +0000, T Karthik Reddy wrote: > > Hello Tom Rini, > > > > > -----Original Message----- > > > From: Tom Rini > > > Sent: Wednesday, August 4, 2021 8:52 PM > > > To: Ashok Reddy Soma > > > Cc: u-boot@lists.denx.de; miquel.raynal@bootlin.com; git > > > ; T Karthik Reddy > > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env > > > variable > > > > > > On Fri, Jul 23, 2021 at 06:18:26AM -0600, Ashok Reddy Soma wrote: > > > > > > > From: T Karthik Reddy > > > > > > > > Tpm test cases relies on tpm device setup. Provide an environment > > > > variable "env__tpm_device_test_skip =3D True" to skip the test case > > > > if tpm device is not present. > > > > Only needed will have to add variable to the py-test framework. > > > > Test runs successfully even this variable is absent. > > > > > > > > Signed-off-by: T Karthik Reddy > > > > Signed-off-by: Ashok Reddy Soma > > > > > > Why is this not using boardenv_* like other tests do to disable runni= ng? > > > > What I meant here was this test doesn't depend on configuration value > > from boardenv_*. But it uses env__tpm_device_test_skip variable from > the configuration file. > > I referred test/py/tests/test_sleep.py for writing this test case, henc= e > copied comments as well. > > Should I change this NOTE in comment section? >=20 > Thanks for explaining. This got me to re-read the existing tests and whi= le > none of it is as clear as I would like, your example here is just as clea= r as the > rest, so it's fine and I'll pick it up soon. I see this patch is not yet applied on the repo, could you please let me kn= ow when this will be applied? Thanks T karthik=20 >=20 > -- > Tom