Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc

["Srinivas, Vidya" <vidya.srinivas@intel.com>]

Hello Petri,

The https://patchwork.freedesktop.org/series/90389/ rev 7 has been reviewed by Juha-Pekka.
Please let me know if I need to re upload the patch by adding the Reviewed-by.

Kindly consider it for merge.

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Srinivas, Vidya 
Sent: Thursday, June 10, 2021 2:24 PM
To: juhapekka.heikkila@gmail.com; igt-dev@lists.freedesktop.org
Cc: markyacoub@chromium.org; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <Charlton.Lin@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Modem, Bhanuprakash <Bhanuprakash.Modem@intel.com>; Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc

Hello Juha-Pekka,

Thank you so much.

Regards
Vidya

-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Thursday, June 10, 2021 2:22 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
Cc: markyacoub@chromium.org; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Shankar, Uma <uma.shankar@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc

Results look ok, there show one new fifo underrun on glk but I don't think it is caused by your change.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 8.6.2021 12.05, Vidya Srinivas wrote:
> CRC mismatch is seen between big and small CRC on
> Gen11 systems for subtest y-tiled-32bpp-rotate-0.
> Patch changes igt_pipe_crc_collect_crc to igt_pipe_crc_get_current for 
> collecting CRC for big and small fb to compare.
> 
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Change-Id: Ie913127f149f577ab0a034dcbbd4314af17cad52
> ---
>   tests/kms_big_fb.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b35727a09bd0..ea12a34157f2 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -331,14 +331,13 @@ static bool test_plane(data_t *data)
>   		 * rendering pipeline introduces slight differences into
>   		 * the result if we try that, and so the crc will not match.
>   		 */
> +		igt_pipe_crc_start(data->pipe_crc);
>   		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
>   			     small_fb->width, small_fb->height);
>   
>   		igt_display_commit2(&data->display, data->display.is_atomic ?
>   				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> -
> -		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
> +		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, 
> +&small_crc);
>   
>   		igt_plane_set_fb(plane, big_fb);
>   		igt_fb_set_position(big_fb, plane, x, y); @@ -347,11 +346,12 @@ 
> static bool test_plane(data_t *data)
>   		igt_display_commit2(&data->display, data->display.is_atomic ?
>   				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>   
> -		igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
> +		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, 
> +&big_crc);
>   
>   		igt_plane_set_fb(plane, NULL);
>   
>   		igt_assert_crc_equal(&big_crc, &small_crc);
> +		igt_pipe_crc_stop(data->pipe_crc);
>   	}
>   
>   	return true;
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev