RE: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

From: Parav Pandit <parav@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeed@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	David Ahern <dsahern@kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	"Sridhar Samudrala" <sridhar.samudrala@intel.com>,
	"david.m.ertman@intel.com" <david.m.ertman@intel.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"kiran.patil@intel.com" <kiran.patil@intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Vu Pham <vuhuong@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: RE: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support
Date: Thu, 17 Dec 2020 05:23:10 +0000	[thread overview]
Message-ID: <BY5PR12MB4322009AFF1E26F8BEF72C72DCC40@BY5PR12MB4322.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201216161154.69e367fe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, December 17, 2020 5:42 AM
> 
> On Wed, 16 Dec 2020 05:19:15 +0000 Parav Pandit wrote:
> > > From: Jakub Kicinski <kuba@kernel.org>
> > > Sent: Wednesday, December 16, 2020 6:14 AM
> > >
> > > On Tue, 15 Dec 2020 01:03:50 -0800 Saeed Mahameed wrote:
> > > > +static ssize_t sfnum_show(struct device *dev, struct
> > > > +device_attribute *attr, char *buf) {
> > > > +	struct auxiliary_device *adev = container_of(dev, struct
> > > auxiliary_device, dev);
> > > > +	struct mlx5_sf_dev *sf_dev = container_of(adev, struct
> > > > +mlx5_sf_dev, adev);
> > > > +
> > > > +	return scnprintf(buf, PAGE_SIZE, "%u\n", sf_dev->sfnum); }
> > > > +static DEVICE_ATTR_RO(sfnum);
> > > > +
> > > > +static struct attribute *sf_device_attrs[] = {
> > > > +	&dev_attr_sfnum.attr,
> > > > +	NULL,
> > > > +};
> > > > +
> > > > +static const struct attribute_group sf_attr_group = {
> > > > +	.attrs = sf_device_attrs,
> > > > +};
> > > > +
> > > > +static const struct attribute_group *sf_attr_groups[2] = {
> > > > +	&sf_attr_group,
> > > > +	NULL
> > > > +};
> > >
> > > Why the sysfs attribute? Devlink should be able to report device
> > > name so there's no need for a tie in from the other end.
> > There isn't a need to enforce a devlink instance creation either,
> 
> You mean there isn't a need for the SF to be spawned by devlink?
>
No. sorry for the confusion.
Let me list down the sequence and plumbing.
1. Devlink instance having eswitch spawns the SF port (port add, flavour = pcisf [..]).
2. This SF is either for local or external controller. Just like today's VF.
3. When SF port is activated (port function set state), SF auxiliary device is spawned on the hosting PF.
4. This SF auxiliary device when attached to mlx5_core driver it registers devlink instance (auxiliary/mlx5_core.sf.4).
5. When netdev of SF dev is created, it register devlink port of virtual flavour with link to its netdev.
/sys/class/net/<sf_netdev>/device points to the auxiliary device.
/sys/class/infiniband/<sf_rdma_dev>/device points to the auxiliary device.

6. SF auxiliary device has the sysfs file read by systemd/udev to rename netdev and rdma devices of SF.

Steps 4,5,6 are equivalent to an existing VF.