From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] block: Remove unused blk_pm_*() function definitions
Date: Mon, 22 Feb 2021 03:52:56 +0000 [thread overview]
Message-ID: <BYAPR04MB4965BB91BBE47BB21C2543BD86819@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210222022805.18196-1-bvanassche@acm.org
On 2/21/21 18:29, Bart Van Assche wrote:
> Commit a1ce35fa4985 ("block: remove dead elevator code") removed the last
> callers of blk_pm_requeue_request(), blk_pm_add_request() and
> blk_pm_put_request(). Hence remove the definitions of these functions.
> Removing these functions removes all users of the struct request nr_pending
> member. Hence also remove 'nr_pending'. Note: 'nr_pending' is no longer
> used since commit 7cedffec8e75 ("block: Make blk_get_request() block for
> non-PM requests while suspended").
>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2021-02-22 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 2:28 [PATCH] block: Remove unused blk_pm_*() function definitions Bart Van Assche
2021-02-22 3:52 ` Chaitanya Kulkarni [this message]
2021-02-22 13:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965BB91BBE47BB21C2543BD86819@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.