From: G, GurucharanX <gurucharanx.g@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v3 2/3] ice: fix rate limit update after coalesce change
Date: Mon, 20 Sep 2021 05:10:35 +0000 [thread overview]
Message-ID: <BYAPR11MB3367279107DD5651D7E73B47FCA09@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210824011259.738307-3-jesse.brandeburg@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Tuesday, August 24, 2021 6:43 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net-next v3 2/3] ice: fix rate limit update
> after coalesce change
>
> If the adaptive settings are changed with ethtool -C ethx adaptive-rx off
> adaptive-tx off then the interrupt rate limit should be maintained as a user
> set value, but only if BOTH adaptive settings are off. Fix a bug where the rate
> limit that was being used in adaptive mode was staying set in the register but
> was not reported correctly by ethtool -c ethx. Due to long lines include a
> small refactor of q_vector variable.
>
> Fixes: b8b4772377dd ("ice: refactor interrupt moderation writes")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> v3: merged with tx_ring/rx_ring split series.
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 17 +++++++++++------
> drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++--
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
next prev parent reply other threads:[~2021-09-20 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 1:12 [Intel-wired-lan] [PATCH net-next v3 0/3] ice: interrupt moderation updates Jesse Brandeburg
2021-08-24 1:12 ` [Intel-wired-lan] [PATCH net-next v3 1/3] ice: update dim usage and moderation Jesse Brandeburg
2021-09-20 5:09 ` G, GurucharanX
2021-09-20 6:46 ` Paul Menzel
2021-09-20 19:02 ` Jesse Brandeburg
2021-08-24 1:12 ` [Intel-wired-lan] [PATCH net-next v3 2/3] ice: fix rate limit update after coalesce change Jesse Brandeburg
2021-09-20 5:10 ` G, GurucharanX [this message]
2021-08-24 1:12 ` [Intel-wired-lan] [PATCH net-next v3 3/3] ice: fix software generating extra interrupts Jesse Brandeburg
2021-09-20 5:11 ` G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3367279107DD5651D7E73B47FCA09@BYAPR11MB3367.namprd11.prod.outlook.com \
--to=gurucharanx.g@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.