All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antoine, Peter" <peter.antoine@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Gordon, Dave" <dave.gordon@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Wait after context init with GuC Submission
Date: Mon, 11 Jan 2016 15:48:30 +0000	[thread overview]
Message-ID: <C182EC90AE29B54BB712270726FAFA75144F9A78@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20160108151940.GE652@nuc-i3427.alporthouse.com>

Ok,

Please ignore this patch.
It is really part of the pre-emption series. Was included as is being used in Android.

Peter.

-----Original Message-----
From: Chris Wilson [mailto:chris@chris-wilson.co.uk] 
Sent: Friday, January 8, 2016 3:20 PM
To: Antoine, Peter
Cc: intel-gfx@lists.freedesktop.org; daniel.vetter@ffwll.ch; Gordon, Dave
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait after context init with GuC Submission

On Fri, Jan 08, 2016 at 03:03:54PM +0000, Peter Antoine wrote:
> Per-context initialisation GPU instructions (which are injected 
> directly into the ringbuffer rather than being submitted as a batch) 
> should not be allowed to mix with user-generated batches in the same 
> submission; it will cause confusion for the GuC (which might merge a 
> subsequent preemptive request with the non-preemptive initialisation 
> code), and for the scheduler, which wouldn't know how to re-inject a 
> non-batch request if it were the victim of preemption.

Move the context init into the first request. Problem solved.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-01-11 15:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 15:03 [PATCH 0/3] Enabling GuC Loading on Broxton Peter Antoine
2016-01-08 15:03 ` [PATCH 1/3] drm/i915: Adding Broxton GuC Loader Support Peter Antoine
2016-01-11 16:40   ` Yu Dai
2016-01-08 15:03 ` [PATCH 2/3] drm/i915: resize the GuC WOPCM for rc6 Peter Antoine
2016-01-11 16:40   ` Yu Dai
2016-01-19 23:52   ` Yu Dai
2016-01-20 17:48   ` Jeff McGee
2016-01-08 15:03 ` [PATCH 3/3] drm/i915: Wait after context init with GuC Submission Peter Antoine
2016-01-08 15:19   ` Chris Wilson
2016-01-11 15:48     ` Antoine, Peter [this message]
2016-01-11 16:40   ` Yu Dai
2016-01-11 10:13 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-12 16:23   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C182EC90AE29B54BB712270726FAFA75144F9A78@IRSMSX102.ger.corp.intel.com \
    --to=peter.antoine@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dave.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.