From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752471AbdIAUVb (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Sep 2017 16:21:31 -0400
Received: from mail-it0-f48.google.com ([209.85.214.48]:33886 "EHLO
        mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752213AbdIAUV3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Sep 2017 16:21:29 -0400
X-Google-Smtp-Source: ADKCNb4UBtmWWqKZ9PAnES3si5yTg7Aj2mnjliPInm7jk3Y+Tn3PIg2Dusn716UYlQV2FdqGM3xGA/VZkrjdzi3ouRg=
MIME-Version: 1.0
In-Reply-To: <1504287133.2361.11.camel@perches.com>
References: <20170828090521.GA25025@amd> <20170828102830.GA403@jagdpanzerIV.localdomain>
 <20170828122109.GA532@jagdpanzerIV.localdomain> <20170828124634.GD492@amd>
 <20170829134048.GA437@jagdpanzerIV.localdomain> <CA+55aFwmwdY_mMqdEyFPpRhCKRyeqj=+aCqe5nN108v8ELFvPw@mail.gmail.com>
 <CA+55aFyzR4LKhJKLFgvvd9OTsos2_g4-9fova782BX4kyA3bLA@mail.gmail.com>
 <20170829195013.5048dc42@gandalf.local.home> <20170830010348.GB654@jagdpanzerIV.localdomain>
 <20170829211046.74644c8a@gandalf.local.home> <20170901131656.GA468@tigerII.localdomain>
 <1504287133.2361.11.camel@perches.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 1 Sep 2017 13:21:28 -0700
X-Google-Sender-Auth: wjKtVytlaf3UkVFkaR6RwtpOtUI
Message-ID: <CA+55aFxmL4ybpz19OPn97VYqAk2ZS-tf=0W2Ff1K=-UUB6mYyg@mail.gmail.com>
Subject: Re: printk: what is going on with additional newlines?
To: Joe Perches <joe@perches.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Petr Mladek <pmladek@suse.com>,
        Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        Jiri Slaby <jslaby@suse.com>, Andreas Mohr <andi@lisas.de>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 1, 2017 at 10:32 AM, Joe Perches <joe@perches.com> wrote:
>
> Yes, it's a poor name.  At least keep using a pr_ prefix.

I'd suggest perhaps just "pr_line()".

And instead of having those "err/info/cont" variations, the severity
level should just be set at initialization time.  Not different
versions of "pr_line()".

There's no point to having different severity variations, since the
*only* reason for this would be for buffering. So "pr_cont()" is kind
of assumed for everything but the first.

And even if you end up doing multiple lines, if you actually do
different severities, you damn well shouldn't buffer them together.
They are clearly different things!

               Linus