From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbdECXVK (ORCPT ); Wed, 3 May 2017 19:21:10 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36719 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdECXVD (ORCPT ); Wed, 3 May 2017 19:21:03 -0400 MIME-Version: 1.0 In-Reply-To: <20170228075747.GA10419@gmail.com> References: <20170228075747.GA10419@gmail.com> From: Linus Torvalds Date: Wed, 3 May 2017 16:21:01 -0700 X-Google-Sender-Auth: R7NqWXIBHAC76Bjmd8Q7oo4_pr4 Message-ID: Subject: Re: [GIT PULL] locking fixes To: Ingo Molnar Cc: Linux Kernel Mailing List , Peter Zijlstra , Thomas Gleixner , "Paul E. McKenney" , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is from last merge window, and the reason I react now is that nobody noticed or cared until we had a release.. On Mon, Feb 27, 2017 at 11:57 PM, Ingo Molnar wrote: > > Peter Zijlstra (1): > locking/refcounts: Out-of-line everything This one is all good generally, but it has one really stupid side effect: it makes refcounting GPL-only. That's just silly. These are functions that atomically add and subtract one. The only thing that making them GPL-only can possibly do is to make people hack around it, and lose the overflow handling debugging in the process. It also breaks any kref uses. Which is what drivers etc are supposed to use. So that "move from inline to out-of-line" had a big subtle semantic change that was probably not intentional, and certainly not documented. Linus