From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751697AbdIQPfM (ORCPT <rfc822;w@1wt.eu>);
        Sun, 17 Sep 2017 11:35:12 -0400
Received: from mail-it0-f66.google.com ([209.85.214.66]:33143 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751408AbdIQPfL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 17 Sep 2017 11:35:11 -0400
X-Google-Smtp-Source: AOwi7QCVaNyazFCIYdl1SXpXKPeQLy2+yUCEg7C6nYeVxsBXL/7E4H3uL9l96YWSkP5gS3vj9gQRLcjE7ZLRTBFeOys=
MIME-Version: 1.0
In-Reply-To: <20170917062608.GA512@tigerII.localdomain>
References: <20170829211046.74644c8a@gandalf.local.home> <1504057959.2786.4.camel@perches.com>
 <20170830022528.GA17968@jagdpanzerIV.localdomain> <1504060296.2786.8.camel@perches.com>
 <20170830024703.GA17175@jagdpanzerIV.localdomain> <20170905094452.GE8741@pathway.suse.cz>
 <20170905095900.GC2066@jagdpanzerIV.localdomain> <20170905122154.GG8741@pathway.suse.cz>
 <20170905134228.GE521@jagdpanzerIV.localdomain> <20170906075554.GI8741@pathway.suse.cz>
 <20170917062608.GA512@tigerII.localdomain>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 17 Sep 2017 08:35:09 -0700
X-Google-Sender-Auth: Nloe7jJOqCSITfXLBrtL7_N9_IQ
Message-ID: <CA+55aFynkjSL1NNZbx6m1iE2HjZagGK09rAr5-HaZ4Ep2eWKOg@mail.gmail.com>
Subject: Re: printk: what is going on with additional newlines?
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Joe Perches <joe@perches.com>, Steven Rostedt <rostedt@goodmis.org>,
        Pavel Machek <pavel@ucw.cz>, Jan Kara <jack@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Slaby <jslaby@suse.com>, Andreas Mohr <andi@lisas.de>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Sep 16, 2017 at 11:26 PM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
>
> so... I think we don't have to update 'struct printk_log'. we can store
> that "extended data" at the beginning of every message, right after the
> prefix.

No, we really can't. That just means that all the tools would have to
be changed to get the normal messages without the extra crud. And
since it will have lost the difference, that's not even easy to do.

So this is exactly the wrong way around.

If people want to see the extra data, it really should be extra data
that you can get with a new interface from the kernel logs. Not a
"let's just a add it to all lines and make every line uglier and
harder to read.

              Linus