From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D66C4361A for ; Thu, 3 Dec 2020 15:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6469207AA for ; Thu, 3 Dec 2020 15:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbgLCP4k (ORCPT ); Thu, 3 Dec 2020 10:56:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgLCP4k (ORCPT ); Thu, 3 Dec 2020 10:56:40 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CA83C061A4E for ; Thu, 3 Dec 2020 07:56:00 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id bo9so4119574ejb.13 for ; Thu, 03 Dec 2020 07:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9gVQmR6ld/lYpsHK76ZuRZXd01EGXnxILe/SFcJOW2w=; b=eYNFtbruDro6dQJWGgCuegmzBpPQ1LahVDbKosAhd/jN2Cwudb8DQbTVXaBLRxfb8o Th0rdj9064ZJNEbCx5jr4Msx0qQ/j1MEUEcx9QPYlUlHwi5ei/IuvUdhJaTQ6GCeiOsb bgNNMQzUuNCxGp/71Du5NA7g2S+KmbGNQOgPQBG3hJuZAv3+qsUV8dCHb0ACSCH/q2Wt 3gViBUy5WgJp1DegkcsSg7E0l5cJ2Ts+L3tMNDMRizt8WuSPT2YP9/0H3hEGjMTc+DhM LTynTdwdGRKYQ4jcKqZ56dTMgPnpUOdQTL7DVddSaI7TqFdTJbJYZxiCR2BZQzmmZTGl 3OIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9gVQmR6ld/lYpsHK76ZuRZXd01EGXnxILe/SFcJOW2w=; b=tLonGLgDOMUopSd9wOJpb1jTPCSZV9Yj9OTxw8v/qKn1AiFEAN3X/saBTUHVLbkV7K 33Xtaad3nibDgtE84Lo4Bmkcj++mUqy/xcP8x/VJSOSZW8uwWkmcycHoGYmzkvO5kAXs lHdRwAthroSXXmxh/p3BwhpsUvahNkTdXiIYlMBgdHW3iGSxn9tOWgNmZOmTAh02J0+I tXfyiSWBFkybJ3sCpfiys4fnScutd/y3S6b0SP/71ui0TzZARAvJW2i43gWYxLcKUn5i YRg+8bdkLKJe9arLYlyv5m3kc3EfQ/LRC95yEBXHrlLVoI2TXJoESX4R4pHfIGESALCu d8hQ== X-Gm-Message-State: AOAM531MQQLwFMogM4XfwNx+RNFuo4+uBhinqRoqRf1odfATYaooVQS2 5In9S+U/fM8u2p/zkXxWhhQVrfSkhb/LQXg7jm3J0g== X-Google-Smtp-Source: ABdhPJx4jNqDXKZJ7ETQGpqkj49u2SxuSrzCLNoPj2MITdYbco0cQP8gTTPag0zTLJ3vffEXV31zz7RTpiFNDGjFKTs= X-Received: by 2002:a17:906:d41:: with SMTP id r1mr2983758ejh.383.1607010958929; Thu, 03 Dec 2020 07:55:58 -0800 (PST) MIME-Version: 1.0 References: <20201202052330.474592-1-pasha.tatashin@soleen.com> <20201202052330.474592-7-pasha.tatashin@soleen.com> In-Reply-To: From: Pavel Tatashin Date: Thu, 3 Dec 2020 10:55:23 -0500 Message-ID: Subject: Re: [PATCH 6/6] mm/gup: migrate pinned pages out of movable zone To: John Hubbard Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Jason Gunthorpe , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I like the cleanup so far, even at this point it's a relief to finally > see the nested ifdefs get removed. > > One naming nit/idea below, but this looks fine as is, so: > > Reviewed-by: John Hubbard Thank you for reviewing this series. > Maybe naming it "movable_page_list", would be a nice touch. Sure, I will change it. Thank you, Pasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B52C4361A for ; Thu, 3 Dec 2020 15:56:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 549A5207AD for ; Thu, 3 Dec 2020 15:56:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 549A5207AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F1686B006E; Thu, 3 Dec 2020 10:56:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C89C6B0070; Thu, 3 Dec 2020 10:56:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 606738D0001; Thu, 3 Dec 2020 10:56:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 4AC696B006E for ; Thu, 3 Dec 2020 10:56:01 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1169B180AD806 for ; Thu, 3 Dec 2020 15:56:01 +0000 (UTC) X-FDA: 77552422122.25.art14_600723c273bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id D62ED1804E3A8 for ; Thu, 3 Dec 2020 15:56:00 +0000 (UTC) X-HE-Tag: art14_600723c273bd X-Filterd-Recvd-Size: 3703 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 15:56:00 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id n26so4189822eju.6 for ; Thu, 03 Dec 2020 07:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9gVQmR6ld/lYpsHK76ZuRZXd01EGXnxILe/SFcJOW2w=; b=eYNFtbruDro6dQJWGgCuegmzBpPQ1LahVDbKosAhd/jN2Cwudb8DQbTVXaBLRxfb8o Th0rdj9064ZJNEbCx5jr4Msx0qQ/j1MEUEcx9QPYlUlHwi5ei/IuvUdhJaTQ6GCeiOsb bgNNMQzUuNCxGp/71Du5NA7g2S+KmbGNQOgPQBG3hJuZAv3+qsUV8dCHb0ACSCH/q2Wt 3gViBUy5WgJp1DegkcsSg7E0l5cJ2Ts+L3tMNDMRizt8WuSPT2YP9/0H3hEGjMTc+DhM LTynTdwdGRKYQ4jcKqZ56dTMgPnpUOdQTL7DVddSaI7TqFdTJbJYZxiCR2BZQzmmZTGl 3OIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9gVQmR6ld/lYpsHK76ZuRZXd01EGXnxILe/SFcJOW2w=; b=Ii7Vuiq0XfgGZWxlxuLnqZitAPLiUDI424kIQhT0iZy3uap//S6ci3jdq5FxgJk5YB Sptvyk6uEEgDoqUcCvjqs/TqRD7KTQu90uJnNkpnn2e6bsn+gXX/2rOHHzjvLLqMQlkS +PCbBc106pRjlJDnXUGYsNNZFjKx/yq+UHVespX4J06H/guUIj+eDlqjSbWaYyzpWrHn Kw8ZWTETZQvsDwLnJ4FEh3heoZGWY6XXxpLWdmlIr+YNRvirBGalmYa62me+P/1wGSey bf1sXQyYZC6BKAK+SjvdkZzc52emR13csf6FzLyIhQjvFPbzDVf7eqjwWnfICUWBr0Ue SkZQ== X-Gm-Message-State: AOAM532fYflzq3pAmdj9GL+B2fOk1vbzpY9CLr+AjRV5gxo+0N4AaH8z 8AAcziyJl3GdAgpP8PELZmTONhYBcFJ5BVAmx/7F0Q== X-Google-Smtp-Source: ABdhPJx4jNqDXKZJ7ETQGpqkj49u2SxuSrzCLNoPj2MITdYbco0cQP8gTTPag0zTLJ3vffEXV31zz7RTpiFNDGjFKTs= X-Received: by 2002:a17:906:d41:: with SMTP id r1mr2983758ejh.383.1607010958929; Thu, 03 Dec 2020 07:55:58 -0800 (PST) MIME-Version: 1.0 References: <20201202052330.474592-1-pasha.tatashin@soleen.com> <20201202052330.474592-7-pasha.tatashin@soleen.com> In-Reply-To: From: Pavel Tatashin Date: Thu, 3 Dec 2020 10:55:23 -0500 Message-ID: Subject: Re: [PATCH 6/6] mm/gup: migrate pinned pages out of movable zone To: John Hubbard Cc: LKML , linux-mm , Andrew Morton , Vlastimil Babka , Michal Hocko , David Hildenbrand , Oscar Salvador , Dan Williams , Sasha Levin , Tyler Hicks , Joonsoo Kim , mike.kravetz@oracle.com, Steven Rostedt , Ingo Molnar , Jason Gunthorpe , Peter Zijlstra , Mel Gorman , Matthew Wilcox , David Rientjes Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > I like the cleanup so far, even at this point it's a relief to finally > see the nested ifdefs get removed. > > One naming nit/idea below, but this looks fine as is, so: > > Reviewed-by: John Hubbard Thank you for reviewing this series. > Maybe naming it "movable_page_list", would be a nice touch. Sure, I will change it. Thank you, Pasha