From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B68C4338F for ; Mon, 2 Aug 2021 09:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BD6461057 for ; Mon, 2 Aug 2021 09:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233097AbhHBJiK (ORCPT ); Mon, 2 Aug 2021 05:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231690AbhHBJiJ (ORCPT ); Mon, 2 Aug 2021 05:38:09 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77166C06175F for ; Mon, 2 Aug 2021 02:38:00 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id y18so23453479oiv.3 for ; Mon, 02 Aug 2021 02:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=Cvc16oiWzGruwX0f0ktKnc1ZiyBzxwiqQhJ6zidI9O6soPlFBx0S/h8qiBq1giZ56R PLmLFPAKGf6XX1jfTnDi+CtnyBSyDI1LjXcdPSCj7WOhuUHZvjUAQ/cZS6RgpvKQ1FHz TufIGOxp4rJPwGDFLeJFThrkm/En8Il1VlcdRkyzsOSBHueCNo/+xiKF1yhSEMEWsYSp Aux21NZtYuiMwvPO+6MIZeReeC0zX2cPlz8ebAmvspErZuhEABpQCC+NS58haHIVsyrQ HcUOBpS0EsOFhpkNWgZFTYQC62C08pl6dgWCd8FH3fb/YproWIVcsLrfzz42r2uUO6to 5N2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=KJebaSWBAIGBNpigGvvklYX35hmAMPMqJF0DkQOhWfNJtt0/+8p3JKCr5wl69JnM63 /dc+zcAz5ir16vhFVCRP98Nwnx4RhdQ0KVre1626YhmlA3tZIUhFhjEfaJzhS6CbMbl2 9VZkyLLcs+jweMJkdInrbspjxChsutg2+i6v02UvyFAYCBv2jVuL9wD9cnM++3W+g/Wu mj0/6I3tfmXmyf8DPtajXYO2wAzKIxaGdXxRk5lF83F6H3Kg8m0lmfOOmt7nng6T4zn+ KAP0YfW8T39Sj/BJ7AEcjgdH65SliX5Wm2hWK6EdmJ9dvFsnqoMtpmpUlkXDbwJuBJm5 AOrg== X-Gm-Message-State: AOAM531Q51UskehJ6Yhrp/OWYj1LRJBTOZ4mJBfgI9dmjzKe2yJl/Ayk pUEu+FkVXL5RYNImvW79Tt7KD2G3ogSbYzxVDDp8Mw== X-Google-Smtp-Source: ABdhPJxAZ2w+4Gmwl0Swj3Q7EhvFKuhBneyXqG8Tc52r4GVBIzVckQSJCz5xN0cudeXLur8PfIFHqP4V3T4Vzap4ILk= X-Received: by 2002:a05:6808:1981:: with SMTP id bj1mr5627597oib.8.1627897079715; Mon, 02 Aug 2021 02:37:59 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-8-qperret@google.com> In-Reply-To: <20210729132818.4091769-8-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 11:37:23 +0200 Message-ID: Subject: Re: [PATCH v3 07/21] KVM: arm64: Rename KVM_PTE_LEAF_ATTR_S2_IGNORED To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > The ignored bits for both stage-1 and stage-2 page and block > descriptors are in [55:58], so rename KVM_PTE_LEAF_ATTR_S2_IGNORED to > make it applicable to both. And while at it, since these bits are more > commonly known as 'software' bits, rename accordingly. As in the Armv8-A Address Translation spec. Reviewed-by: Fuad Tabba Thanks, /fuad > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/pgtable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 4dff2ad39ee4..59a394d82de3 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -36,6 +36,8 @@ > > #define KVM_PTE_LEAF_ATTR_HI GENMASK(63, 51) > > +#define KVM_PTE_LEAF_ATTR_HI_SW GENMASK(58, 55) > + > #define KVM_PTE_LEAF_ATTR_HI_S1_XN BIT(54) > > #define KVM_PTE_LEAF_ATTR_HI_S2_XN BIT(54) > @@ -44,8 +46,6 @@ > KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W | \ > KVM_PTE_LEAF_ATTR_HI_S2_XN) > > -#define KVM_PTE_LEAF_ATTR_S2_IGNORED GENMASK(58, 55) > - > #define KVM_INVALID_PTE_OWNER_MASK GENMASK(63, 56) > #define KVM_MAX_OWNER_ID 1 > > -- > 2.32.0.432.gabb21c7263-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5A1C4338F for ; Mon, 2 Aug 2021 09:38:04 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 37ED8610CE for ; Mon, 2 Aug 2021 09:38:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37ED8610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D18994A522; Mon, 2 Aug 2021 05:38:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id peIgPx+j7OTW; Mon, 2 Aug 2021 05:38:02 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C922740C88; Mon, 2 Aug 2021 05:38:02 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3CEF44048B for ; Mon, 2 Aug 2021 05:38:01 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwpABCrDFamA for ; Mon, 2 Aug 2021 05:38:00 -0400 (EDT) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 53C414020A for ; Mon, 2 Aug 2021 05:38:00 -0400 (EDT) Received: by mail-oi1-f181.google.com with SMTP id u10so23411176oiw.4 for ; Mon, 02 Aug 2021 02:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=Cvc16oiWzGruwX0f0ktKnc1ZiyBzxwiqQhJ6zidI9O6soPlFBx0S/h8qiBq1giZ56R PLmLFPAKGf6XX1jfTnDi+CtnyBSyDI1LjXcdPSCj7WOhuUHZvjUAQ/cZS6RgpvKQ1FHz TufIGOxp4rJPwGDFLeJFThrkm/En8Il1VlcdRkyzsOSBHueCNo/+xiKF1yhSEMEWsYSp Aux21NZtYuiMwvPO+6MIZeReeC0zX2cPlz8ebAmvspErZuhEABpQCC+NS58haHIVsyrQ HcUOBpS0EsOFhpkNWgZFTYQC62C08pl6dgWCd8FH3fb/YproWIVcsLrfzz42r2uUO6to 5N2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=iCXZ/IkIVjOObizhPSTFZ9w7JrsZbvHUtq1pDd2LQ3p2hi8lRd2GyPIaXlvArN/v6z Ms5EVL2ReVjQbm2+ad1U7ydvlE1rlsdYnrIX83v8YU/XGDN1iLYtUhX7S1hbWZ+YQeXz AurMP74wmQjjKooyO+X7Xx6nrEc5XUTQhvMTeezgLFADLW0jRvcLlEkXw7ru7qbcPwMl QrUY/ni37PQkM1LYONNm0myyQ4Esme4BfrwmrHmupN/A1Bzlltuilryn0Sg1l+s20bfX rqkPvlECAKhF//UpoiG/6grwA35AT/NiQHtXNh4tGm6Irxp7aOexyWatOHacV8TZL/l8 sYXg== X-Gm-Message-State: AOAM531fk3DBuWnO950E/pOsdG7pAtcJNJpATq3F7apJP60I2U5D6/Mu 1UEsAAafk5yAek1/WuaEbgfjgMen4Xi8tNO8wAVGVA== X-Google-Smtp-Source: ABdhPJxAZ2w+4Gmwl0Swj3Q7EhvFKuhBneyXqG8Tc52r4GVBIzVckQSJCz5xN0cudeXLur8PfIFHqP4V3T4Vzap4ILk= X-Received: by 2002:a05:6808:1981:: with SMTP id bj1mr5627597oib.8.1627897079715; Mon, 02 Aug 2021 02:37:59 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-8-qperret@google.com> In-Reply-To: <20210729132818.4091769-8-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 11:37:23 +0200 Message-ID: Subject: Re: [PATCH v3 07/21] KVM: arm64: Rename KVM_PTE_LEAF_ATTR_S2_IGNORED To: Quentin Perret Cc: kernel-team@android.com, qwandor@google.com, maz@kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > The ignored bits for both stage-1 and stage-2 page and block > descriptors are in [55:58], so rename KVM_PTE_LEAF_ATTR_S2_IGNORED to > make it applicable to both. And while at it, since these bits are more > commonly known as 'software' bits, rename accordingly. As in the Armv8-A Address Translation spec. Reviewed-by: Fuad Tabba Thanks, /fuad > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/pgtable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 4dff2ad39ee4..59a394d82de3 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -36,6 +36,8 @@ > > #define KVM_PTE_LEAF_ATTR_HI GENMASK(63, 51) > > +#define KVM_PTE_LEAF_ATTR_HI_SW GENMASK(58, 55) > + > #define KVM_PTE_LEAF_ATTR_HI_S1_XN BIT(54) > > #define KVM_PTE_LEAF_ATTR_HI_S2_XN BIT(54) > @@ -44,8 +46,6 @@ > KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W | \ > KVM_PTE_LEAF_ATTR_HI_S2_XN) > > -#define KVM_PTE_LEAF_ATTR_S2_IGNORED GENMASK(58, 55) > - > #define KVM_INVALID_PTE_OWNER_MASK GENMASK(63, 56) > #define KVM_MAX_OWNER_ID 1 > > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32FAC4338F for ; Mon, 2 Aug 2021 09:39:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84853610CF for ; Mon, 2 Aug 2021 09:39:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 84853610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eBELFE4kdEwSt/BaucYSb2WobAtS4mssJNAcBwZ/cdg=; b=B+a9/vxvOlzumi SHr9Zk42ltZo6f1+pGqZPgo5LAubD3flWPOFyR4tX8DkfgeYoXPZ35ubvQefN29MmFrxv7sozYavY 206tDcIXzzLj1W/Oej1/lanW4pdgrHad+/UZgzYkNWllL4BlxYKIlOFcccPFrl8+qAuqFayjXQzOl QeAOk5TkbpMUEQuSdtfJFFCXIowi3soXeQtMG2CJJiNZLoSQJSmbtGEPeHT1U5xqA8rDeQM1it/++ ipVQf1RcmF4Ntu6unCWMdDejCsiV/MNVLb+7sVHt/BO9zrZxnICeKFRdpAqGNAeliZ6gkdXmL4daK BOQPDMxHi3iflrB3JoEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAUOb-00FZf5-Ir; Mon, 02 Aug 2021 09:38:05 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAUOW-00FZcj-OD for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 09:38:02 +0000 Received: by mail-oi1-x22d.google.com with SMTP id a19so23468746oiw.6 for ; Mon, 02 Aug 2021 02:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=Cvc16oiWzGruwX0f0ktKnc1ZiyBzxwiqQhJ6zidI9O6soPlFBx0S/h8qiBq1giZ56R PLmLFPAKGf6XX1jfTnDi+CtnyBSyDI1LjXcdPSCj7WOhuUHZvjUAQ/cZS6RgpvKQ1FHz TufIGOxp4rJPwGDFLeJFThrkm/En8Il1VlcdRkyzsOSBHueCNo/+xiKF1yhSEMEWsYSp Aux21NZtYuiMwvPO+6MIZeReeC0zX2cPlz8ebAmvspErZuhEABpQCC+NS58haHIVsyrQ HcUOBpS0EsOFhpkNWgZFTYQC62C08pl6dgWCd8FH3fb/YproWIVcsLrfzz42r2uUO6to 5N2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qnd2EC9vITZLgMCS/eh0ytFlSZARisHdIkWr1reDb+g=; b=UoR/FcX7vmxdPGZ7WJ5+peUoGMRvn4Vsh4gM1AMPZD3UlLHWpWWMUqx5zS2v5aKTEa OtTS3gmI0ufg57yHrCfwVMTnwI0isCs4XRdtLep8GKOj6Ar/N+foyeXrcn5WbZ+JPZxo ExHjIfe3BsSWez1gaJ+XKrsil90CTpgpzSunUGGgkHPy7HKVfbCe7JRzF/bsRur21Hg+ 0XaWGg5vIz6a9FBFRIE+oIuloYuSDx549MWluHSV9vZs3D1NlFKUBUqd7QNXJKmY0q5v sA3ly/jmNliw0h4ArqGZxI/A+Ngf71jzMtDmT2MRCEKecZk6gwKnVHuKnMm2jIEQgznA JLIw== X-Gm-Message-State: AOAM533ImHc4x3J/4/1KnaDflJvdCIE24CA1lcaoXfdlsmpbO7Iovr0g 8V//4ReZNMIBAb23a2XAfZC4ICkAcnl+NKggTlCrWg== X-Google-Smtp-Source: ABdhPJxAZ2w+4Gmwl0Swj3Q7EhvFKuhBneyXqG8Tc52r4GVBIzVckQSJCz5xN0cudeXLur8PfIFHqP4V3T4Vzap4ILk= X-Received: by 2002:a05:6808:1981:: with SMTP id bj1mr5627597oib.8.1627897079715; Mon, 02 Aug 2021 02:37:59 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-8-qperret@google.com> In-Reply-To: <20210729132818.4091769-8-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 11:37:23 +0200 Message-ID: Subject: Re: [PATCH v3 07/21] KVM: arm64: Rename KVM_PTE_LEAF_ATTR_S2_IGNORED To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_023800_837162_7C6F07D6 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin, On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > The ignored bits for both stage-1 and stage-2 page and block > descriptors are in [55:58], so rename KVM_PTE_LEAF_ATTR_S2_IGNORED to > make it applicable to both. And while at it, since these bits are more > commonly known as 'software' bits, rename accordingly. As in the Armv8-A Address Translation spec. Reviewed-by: Fuad Tabba Thanks, /fuad > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/pgtable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 4dff2ad39ee4..59a394d82de3 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -36,6 +36,8 @@ > > #define KVM_PTE_LEAF_ATTR_HI GENMASK(63, 51) > > +#define KVM_PTE_LEAF_ATTR_HI_SW GENMASK(58, 55) > + > #define KVM_PTE_LEAF_ATTR_HI_S1_XN BIT(54) > > #define KVM_PTE_LEAF_ATTR_HI_S2_XN BIT(54) > @@ -44,8 +46,6 @@ > KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W | \ > KVM_PTE_LEAF_ATTR_HI_S2_XN) > > -#define KVM_PTE_LEAF_ATTR_S2_IGNORED GENMASK(58, 55) > - > #define KVM_INVALID_PTE_OWNER_MASK GENMASK(63, 56) > #define KVM_MAX_OWNER_ID 1 > > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel