From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6396C07E9E for ; Thu, 8 Jul 2021 10:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9AE961451 for ; Thu, 8 Jul 2021 10:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231458AbhGHKHv (ORCPT ); Thu, 8 Jul 2021 06:07:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbhGHKHt (ORCPT ); Thu, 8 Jul 2021 06:07:49 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9BBBC061574 for ; Thu, 8 Jul 2021 03:05:07 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id a6so7532621ioe.0 for ; Thu, 08 Jul 2021 03:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=UYLH/VW8SI7ZogoX7fR4NWP4DRGl1d62SfimYKsYGCETDopjoL/y+RsptFQTSoByGW q+sENfaHQCddz+goHWQTbvBYRlZpPNGTD+hwSbScS+9stYayGZQXolfj/woo+NmCRBFa jGhhZ2GepPegJFGXuvZ83xSc31slF8PwiWyq/CFpd9Wkx+YE6ESZv0Bd/Zg2Bn1QN4L3 XlwQ5Gw1bepr7GNdQBbKm28jDLcSJf11PX8aOk5pdKA+hC4hLLRMYbVPpSJHXz2ar6DR UDOSQX01Z+z/FHqmL6RR7vDsF7HIoczBZVtLjl/NWXDfF8VnYSiP+1906qUiWuzmA55S 3mlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=Bz3VQg2WQBSua+29TXPpgNGNN0n6QUKDNLc+u/Kqv7ZGygmhhIo3ZJ9BFBUZLmShvU bofB67a8yFVuVZoV/BEwGCihnaHan0+Y4IaJtKYNJlnFLs2k5Sf/0JKrkHwNITx4aKil rOsCMVWMB9x6ImOfUNQolTBL9YUaw8a4iCng86RrgbTG7LugOE4FH9WJNuv4AvBjXP2A JOOoLy5o1uDaxjbX6IZiiEsYDtvnep68tz+BmJDD/2AKp1Vms39hSkmOHHd2IOyyDsnp wFPbgZKAXO3SoHmagEPu2fharMYHhpQC+P+Pw8FcxfaBowCCzwu0/aaYktycj/Bn2gi8 HQWg== X-Gm-Message-State: AOAM533NQUziLziRJJ92QV7i9pKXwQ+9Z4LMt5wtKa8UXxQETbOZHttv kldZ0sdQgIWMCdxlAzrK8SXbEt/1f25c2YVm9hZ7iQ== X-Google-Smtp-Source: ABdhPJxdKSoYDqcwBIX1WQ4+fbUqa84UqW8rvefJuvTTO1vwGh4lLoujDgkp/mZyijH1oUQhvQsnJcYa+CxvYJZElwI= X-Received: by 2002:a02:9402:: with SMTP id a2mr26130879jai.110.1625738705769; Thu, 08 Jul 2021 03:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-5-yunfei.dong@mediatek.com> In-Reply-To: <20210707062157.21176-5-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Thu, 8 Jul 2021 18:04:54 +0800 Message-ID: Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++ > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt The patch is weird. Its title says "separate" but the changes are all creating new content. Would expect the patch to remove content from some files (e.g. Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and separate into 2 files. Also would expect the patch is a refactor which shouldn't introduce any new things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CD5C07E99 for ; Thu, 8 Jul 2021 10:05:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA15619BE for ; Thu, 8 Jul 2021 10:05:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEA15619BE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uVqmDAWxLrceWBNwJ7d3rWYimjjzKMmYPniYEUhYEPo=; b=pLqCxf6XuAMHIx WRcYG+9Ai1tp61C2RAfCGl1PV9K1vLJYu3d/LvhCj7cUUgX9brtZBgzDEMUzomMHxh4wF/wisi1QY fu9b8vowcAj0IwOxI8l+Q7zkpJePayemclXMMVcHz7sXx87nL+8JXGMLzItbIGAItL+/bnNlWBbud 8FKAkcaaNHgv72uIKWrLjkiRjl0vdXzSQxs9Jmp8zv35OORenyb2mZvHIYMOANpZyzvbTzxQfE/ON yCwrvGE6GkzeeJzKGW7fBgNUxExTMDq/iMRbZZZZjGerS6wbNvIInjwOw+Ah0R67/MluO8eyj7muq NyuQJxKbVENQkdU7d3rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1QuN-00GYSb-Vh; Thu, 08 Jul 2021 10:05:28 +0000 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Qu4-00GYKo-7e for linux-mediatek@lists.infradead.org; Thu, 08 Jul 2021 10:05:09 +0000 Received: by mail-io1-xd31.google.com with SMTP id l5so7453401iok.7 for ; Thu, 08 Jul 2021 03:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=UYLH/VW8SI7ZogoX7fR4NWP4DRGl1d62SfimYKsYGCETDopjoL/y+RsptFQTSoByGW q+sENfaHQCddz+goHWQTbvBYRlZpPNGTD+hwSbScS+9stYayGZQXolfj/woo+NmCRBFa jGhhZ2GepPegJFGXuvZ83xSc31slF8PwiWyq/CFpd9Wkx+YE6ESZv0Bd/Zg2Bn1QN4L3 XlwQ5Gw1bepr7GNdQBbKm28jDLcSJf11PX8aOk5pdKA+hC4hLLRMYbVPpSJHXz2ar6DR UDOSQX01Z+z/FHqmL6RR7vDsF7HIoczBZVtLjl/NWXDfF8VnYSiP+1906qUiWuzmA55S 3mlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=R+NKMnMhVhIR/cDOG4e07a9Hj5v538mOeDm/iK4RSbpfGHoAA+f+dYCq7a1ZscjZFE 5yM0ZRI2EDe/rh4Gbbm2i5FQpRPwAp8R5ku26l1ojlgHHlb/WQlP2KIVLgQPQYNi73sV eUnzqvYqZWr6gL6p3x24bgTkZ1qTGBDZ81vRfEKJroFjizacZBGf52FA5WLA7ic5y6U0 s9eEdaeT2yDw/6fCGavrP+drjT/5rLTh36oYZsc2plVF/dWTtClkQCPgI1Nu6da2ZpUM Hm26X4uFZZLEab+JozZFmcf/PK8V3wuxZ4KW7qPRfaLXvUgI8ekAq78k5Vr5Z+SqYup9 g3Fw== X-Gm-Message-State: AOAM5302W9VTktMiKScbJaeNtoSRxu5TUx56tBrhixW6LMZIYD+5OkKV oL+/+W38D7KWHl2Gpogb+6GALEVvcwl43TSdBuJzIw== X-Google-Smtp-Source: ABdhPJxdKSoYDqcwBIX1WQ4+fbUqa84UqW8rvefJuvTTO1vwGh4lLoujDgkp/mZyijH1oUQhvQsnJcYa+CxvYJZElwI= X-Received: by 2002:a02:9402:: with SMTP id a2mr26130879jai.110.1625738705769; Thu, 08 Jul 2021 03:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-5-yunfei.dong@mediatek.com> In-Reply-To: <20210707062157.21176-5-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Thu, 8 Jul 2021 18:04:54 +0800 Message-ID: Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_030508_327208_A756121B X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++ > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt The patch is weird. Its title says "separate" but the changes are all creating new content. Would expect the patch to remove content from some files (e.g. Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and separate into 2 files. Also would expect the patch is a refactor which shouldn't introduce any new things. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B923EC07E96 for ; Thu, 8 Jul 2021 10:06:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8478861451 for ; Thu, 8 Jul 2021 10:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8478861451 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bTIlmIrj7BdP6csAS0DBE9nCbpkCT9MrbmGa9LUtcBc=; b=l+Ud+SvTU4SZpg R1VsLhTnUhhDE8pUca0s/VXZ41STmsjWb2+Xn8fitX8YY51vfkm9pbie0ErlZ+py39fPp4FDJPcMa /ZqqwKrzO0EWPhuKaVfXA1NnR092kfuePJzHDo4YnTvX/IxmfQKahfvUr1L5jOSwiUS/ZxecAUuba aJGqS+PRlKDJQy8FOcCO6y0GQ/BmHTEMFY/Fn971T+4IEf9wTc2jIa5Gon4SVx4/394FXmdVGuNiA gceEAj1t06r7orfYC9frhjuYxNz9nORy5vbeG9eEC8JwRcWiBqNdh8eazIs3w2CCG/DQbUzamNyJQ kbXjHvwLwwO5hhTGkCKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1QuD-00GYOO-Ha; Thu, 08 Jul 2021 10:05:17 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Qu4-00GYKp-7P for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 10:05:09 +0000 Received: by mail-io1-xd2c.google.com with SMTP id q2so7413379iot.11 for ; Thu, 08 Jul 2021 03:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=UYLH/VW8SI7ZogoX7fR4NWP4DRGl1d62SfimYKsYGCETDopjoL/y+RsptFQTSoByGW q+sENfaHQCddz+goHWQTbvBYRlZpPNGTD+hwSbScS+9stYayGZQXolfj/woo+NmCRBFa jGhhZ2GepPegJFGXuvZ83xSc31slF8PwiWyq/CFpd9Wkx+YE6ESZv0Bd/Zg2Bn1QN4L3 XlwQ5Gw1bepr7GNdQBbKm28jDLcSJf11PX8aOk5pdKA+hC4hLLRMYbVPpSJHXz2ar6DR UDOSQX01Z+z/FHqmL6RR7vDsF7HIoczBZVtLjl/NWXDfF8VnYSiP+1906qUiWuzmA55S 3mlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=GyWyMXucK6R7/5q/k3xz+rGGB+iH9kQL8W9U9Uc5PqdoQstquCFhVNKjNynPwe8d5O v67ybuKz0zc2ZXdSnbW9P+VsZD3OQhGQE8uyGyE22+hu9bZHh+YJjLWH8boVdITgvZwZ IwV5fNupzoqjGqVzZb1TwcB3keLZnEnIXHa/BW/m+pd4unLKo0Bnb4xWXVas43hnjtQd bCB9292sFrDI3Jly7pRL5g6aJbhIyLuoQAVHNy8NqVoPfrhfkMXB8ec2eRtsvvVtkpRs n9RDmcGwKFvR6yk2LHa0kZAkRPwqqiycv92CTke4a+hbJU4GscPTat36boI6eAl4nwYm t4VA== X-Gm-Message-State: AOAM531HwqIqzuYuYPGc54/v0ues2vF9XGu2fQeoK201Qa5H8DgAthRT tWlgMFAKB+ex76xPbXnsmtd3J2o8cGMT9NdA2TxlDg== X-Google-Smtp-Source: ABdhPJxdKSoYDqcwBIX1WQ4+fbUqa84UqW8rvefJuvTTO1vwGh4lLoujDgkp/mZyijH1oUQhvQsnJcYa+CxvYJZElwI= X-Received: by 2002:a02:9402:: with SMTP id a2mr26130879jai.110.1625738705769; Thu, 08 Jul 2021 03:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-5-yunfei.dong@mediatek.com> In-Reply-To: <20210707062157.21176-5-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Thu, 8 Jul 2021 18:04:54 +0800 Message-ID: Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_030508_325553_C0C2C17D X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++ > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt The patch is weird. Its title says "separate" but the changes are all creating new content. Would expect the patch to remove content from some files (e.g. Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and separate into 2 files. Also would expect the patch is a refactor which shouldn't introduce any new things. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel