From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7D6C5DF61 for ; Thu, 7 Nov 2019 08:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14EC92077C for ; Thu, 7 Nov 2019 08:10:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XIQjJ1Kk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbfKGIKh (ORCPT ); Thu, 7 Nov 2019 03:10:37 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:46856 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbfKGIKh (ORCPT ); Thu, 7 Nov 2019 03:10:37 -0500 Received: by mail-oi1-f195.google.com with SMTP id n14so1161700oie.13; Thu, 07 Nov 2019 00:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Ln1GAykiZS8RusuR4H+KQoetDdyYBnG1RhAd3RuDvU=; b=XIQjJ1KkwJwDO2WBDAlhOf60GzfwCkkbNwnxofI1gvr56DlMnJZNb4jHhH9l+siPjy 7XUMhHNlxMeUd0C8IsfA/1LUeakE2mhibVwGsvSfeeV6D1unTFUY+jfFqzTPIcRQl5X+ gWKfPOXD3nsSRoQRnk8+d5iIA5qxdNdnYM0aAjr5pCDue/7MNTnR9v4pFaetY9pKAOIL RcPun1cI3Qh9hzQ1HJD8sMy57glLs6u3q1iXmG7lA0FwoChXUDNfAOgr2ETpotB//xIX UnxYVtmQXIYLoaVGsh7uTHXu6+JIFIEnRncdelUnehHP33ZJr4CmSpidqTtDpVy7SPn3 mHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Ln1GAykiZS8RusuR4H+KQoetDdyYBnG1RhAd3RuDvU=; b=jXkXFJEFNJU9WLirEP/Sn7tJJOv6Ym6nWlh3UeBnYz+C86DGtGD/tU9C9pLIbJVm/t cY6A1cv9WUqmSVWYSHSgNT6WGhhjzZXoNB+G9cVhYsa5x9omHRALVeRA3Yhr/el8QLzR jXCn52QdIvdJ4y0i/8WQ5TJd4mYRIhTo5eSf86pNAqC7th98jkzn0sX777IhQUkg7IVP eKzQ28sTXuAG+YAjEsoozPHjlNE3bH48DE6Y5/w11eM9KWOYYBplVhmUfOyW3w21X5pL xdNFP1Xl33HGB8r147wHcntSqb6IEw9CVyA+t5dh3zkugZdla/vHYRQP83gVC5FEl9fh 7G2w== X-Gm-Message-State: APjAAAXu1tPNCNl+tKGRcIL8KNNGOANBC/XVvMZgQwqGcY6mVN9CtSJu irTMf6I/L0dapihTroB/BkaHlp8qb3MzSp9MAWc= X-Google-Smtp-Source: APXvYqyCsRHXrlcNyFDdWgqpUGNUi9JY2dnU8nu8fLaBJBr7i8H4CEPtAXOaCsi6gmrcZ/dmVtw/Dn8k5G1I4v7yMqw= X-Received: by 2002:a05:6808:3cf:: with SMTP id o15mr2227687oie.7.1573114236156; Thu, 07 Nov 2019 00:10:36 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 7 Nov 2019 08:10:09 +0000 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: Biju Das Cc: Bjorn Helgaas , Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , "linux-pci@vger.kernel.org" , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Prabhakar Mahadev Lad Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Biju, Thank you for the review. On Thu, Nov 7, 2019 at 7:39 AM Biju Das wrote: > > Hi Prabhakar, > > Thanks for the patch > > > Subject: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings > > > > From: "Lad, Prabhakar" > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > Signed-off-by: Lad, Prabhakar > > --- > > .../devicetree/bindings/pci/rcar-pci-ep.txt | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > new file mode 100644 > > index 000000000000..b8c8616ca007 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > @@ -0,0 +1,43 @@ > > +* Renesas R-Car PCIe Endpoint Controller DT description > > + > > +Required properties: > > + "renesas,pcie-ep-r8a774c0" for the R8A774C0 SoC; > > + "renesas,pcie-ep-rcar-gen3" for a generic R-Car Gen3 or > > + RZ/G2 compatible device. > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first > > + followed by the generic version. > > + > > +- reg: Five register ranges as listed in the reg-names property > > +- reg-names: Must include the following names > > + - "apb-base" > > + - "memory0" > > + - "memory1" > > + - "memory2" > > + - "memory3" > > +- resets: Must contain phandles to PCIe-related reset lines exposed by IP > > block > > +- clocks: from common clock binding: clock specifiers for the PCIe controller > > + clock. > > +- clock-names: from common clock binding: should be "pcie". > > + > > +Optional Property: > > +- max-functions: Maximum number of functions that can be configured > > (default 1). > > + > > +Example: > > + > > +SoC-specific DT Entry: > > + > > + pcie_ep: pcie_ep@fe000000 { > > + compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar- > > gen2"; > > I believe it is currently tested on RZ/G2E. so please use the same. > Yes you are correct its tested on RZ/G2E board, ill fix it in next iteration. Cheers, --Prabhakar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582ACC5DF61 for ; Thu, 7 Nov 2019 08:10:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A1462077C for ; Thu, 7 Nov 2019 08:10:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PeKTRmUg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XIQjJ1Kk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A1462077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tUFjR6He6Jqml116WrHsuA7KZ/VRavoo9abn1xdZxVY=; b=PeKTRmUgMiT94G zGWMBFDkSOAKY2Kzx1jGerGbaHGEmNzCWXbrPWDTNA0Jq3ef4tZwkiAuBfx4/uDbmX0jm9SOH/HWu 7ubaqrmYtCxjh/iNdUpX4JW4CGHzQ1Q9A2TjVGhDIN03AjaLx2QveTuCkA5CwfoWw4pVHR1uk47Xj wpky4LonCUXMwcjA2DaVrxGLlDE3WpuFklsx5Z+mc4rvem6MnYDutd7F7yK1lHOspzz0MJPa9hD76 huDO+yNxXpGfItBJwpLH2/4U0ap3AIPN5V82NKeJfsLfDy6A42bgRkYmQzPnnAZ5xG97KKd4H28cV 6Xba1DeE7iFWmensJhKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iScsK-0004GH-RP; Thu, 07 Nov 2019 08:10:40 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iScsH-0004F2-Mf for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 08:10:39 +0000 Received: by mail-oi1-x244.google.com with SMTP id n16so1220495oig.2 for ; Thu, 07 Nov 2019 00:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Ln1GAykiZS8RusuR4H+KQoetDdyYBnG1RhAd3RuDvU=; b=XIQjJ1KkwJwDO2WBDAlhOf60GzfwCkkbNwnxofI1gvr56DlMnJZNb4jHhH9l+siPjy 7XUMhHNlxMeUd0C8IsfA/1LUeakE2mhibVwGsvSfeeV6D1unTFUY+jfFqzTPIcRQl5X+ gWKfPOXD3nsSRoQRnk8+d5iIA5qxdNdnYM0aAjr5pCDue/7MNTnR9v4pFaetY9pKAOIL RcPun1cI3Qh9hzQ1HJD8sMy57glLs6u3q1iXmG7lA0FwoChXUDNfAOgr2ETpotB//xIX UnxYVtmQXIYLoaVGsh7uTHXu6+JIFIEnRncdelUnehHP33ZJr4CmSpidqTtDpVy7SPn3 mHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Ln1GAykiZS8RusuR4H+KQoetDdyYBnG1RhAd3RuDvU=; b=cpQ780hhawkuPM7n8LMPsBTY1VwBBbtVbwispO3NV8CdxcVJ0WzTtE0UCC+S9pIX8q 7bw0agnDtbYOg8mrplkc/PZSV65vdhDnM0iEQtaehdsYuslATmlrecPLRNOFNx+1HWkZ uUVnfWT+DZVmUZsSoZZz/WTS+rppBij6ZhmULYostSxOvZqR5UezB+OO711OKm1lR2ON LMsJKZqu1vrXiGFOxu3wnu4VI8HPdGOCVBB/99ria6u9RWW1p2zQ2gKb+wd06xCIv3hd GeMly+T7icmVfbfXY4P/AstNfyirYtp1xksLDy1Mp97LgkxHJLrPEICjGaSiJkAuzESS 8MJA== X-Gm-Message-State: APjAAAW8SuIoPFI1zqYuCBx2aCcf9eBALRJLb6I3FhP0oEQkC/QqQRac /oHvw/yikHj6lrhw9p+ETPFEOSjQnepmy3R32bE= X-Google-Smtp-Source: APXvYqyCsRHXrlcNyFDdWgqpUGNUi9JY2dnU8nu8fLaBJBr7i8H4CEPtAXOaCsi6gmrcZ/dmVtw/Dn8k5G1I4v7yMqw= X-Received: by 2002:a05:6808:3cf:: with SMTP id o15mr2227687oie.7.1573114236156; Thu, 07 Nov 2019 00:10:36 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: "Lad, Prabhakar" Date: Thu, 7 Nov 2019 08:10:09 +0000 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: Biju Das X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_001037_763179_CF1704FE X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Chris Paterson , Lorenzo Pieralisi , Prabhakar Mahadev Lad , Arnd Bergmann , Geert Uytterhoeven , Greg Kroah-Hartman , "linux-pci@vger.kernel.org" , Yoshihiro Shimoda , Magnus Damm , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , "linux-renesas-soc@vger.kernel.org" , Rob Herring , Catalin Marinas , Bjorn Helgaas , Andrew Murray , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Marek Vasut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Biju, Thank you for the review. On Thu, Nov 7, 2019 at 7:39 AM Biju Das wrote: > > Hi Prabhakar, > > Thanks for the patch > > > Subject: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings > > > > From: "Lad, Prabhakar" > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > Signed-off-by: Lad, Prabhakar > > --- > > .../devicetree/bindings/pci/rcar-pci-ep.txt | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > new file mode 100644 > > index 000000000000..b8c8616ca007 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > @@ -0,0 +1,43 @@ > > +* Renesas R-Car PCIe Endpoint Controller DT description > > + > > +Required properties: > > + "renesas,pcie-ep-r8a774c0" for the R8A774C0 SoC; > > + "renesas,pcie-ep-rcar-gen3" for a generic R-Car Gen3 or > > + RZ/G2 compatible device. > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first > > + followed by the generic version. > > + > > +- reg: Five register ranges as listed in the reg-names property > > +- reg-names: Must include the following names > > + - "apb-base" > > + - "memory0" > > + - "memory1" > > + - "memory2" > > + - "memory3" > > +- resets: Must contain phandles to PCIe-related reset lines exposed by IP > > block > > +- clocks: from common clock binding: clock specifiers for the PCIe controller > > + clock. > > +- clock-names: from common clock binding: should be "pcie". > > + > > +Optional Property: > > +- max-functions: Maximum number of functions that can be configured > > (default 1). > > + > > +Example: > > + > > +SoC-specific DT Entry: > > + > > + pcie_ep: pcie_ep@fe000000 { > > + compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar- > > gen2"; > > I believe it is currently tested on RZ/G2E. so please use the same. > Yes you are correct its tested on RZ/G2E board, ill fix it in next iteration. Cheers, --Prabhakar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel