The last one is a symlink and sed -i doesn't follow symlinks as you haven't used --follow-symlinks. On Mon, Sep 28, 2020 at 3:48 AM Jon Mason wrote: > On Fri, Sep 25, 2020 at 5:29 PM Richard Purdie > wrote: > > > > On Fri, 2020-09-25 at 15:28 -0400, Jon Mason wrote: > > > Multiple files have " ," instead of ", " in expressions. This > > > changes > > > them to conform to the way the rest of them are done. > > > > > > Found and corrected via: > > > git ls-files | xargs sed -i 's/ ,d/, d/g' > > > > > > Signed-off-by: Jon Mason > > > --- > > > meta/classes/linuxloader.bbclass | 2 +- > > > meta/classes/rootfs_rpm.bbclass | 2 +- > > > meta/conf/machine/include/arm/arch-arm64.inc | 10 +- > > > meta/conf/machine/include/arm/arch-armv4.inc | 2 +- > > > meta/conf/machine/include/arm/arch-armv5.inc | 2 +- > > > meta/conf/machine/include/arm/arch-armv6.inc | 2 +- > > > meta/conf/machine/include/arm/arch-armv6m.inc | 2 +- > > > meta/conf/machine/include/arm/arch-armv7a.inc | 2 +- > > > .../conf/machine/include/arm/arch-armv7ve.inc | 2 +- > > > .../machine/include/arm/arch-armv8-2a.inc | 2 +- > > > meta/conf/machine/include/arm/arch-armv8a.inc | 2 +- > > > meta/conf/machine/include/mips/arch-mips.inc | 16 +- > > > .../conf/machine/include/tune-arm1136jf-s.inc | 2 +- > > > .../conf/machine/include/tune-arm1176jz-s.inc | 2 +- > > > meta/conf/machine/include/tune-arm920t.inc | 2 +- > > > meta/conf/machine/include/tune-arm926ejs.inc | 2 +- > > > meta/conf/machine/include/tune-arm9tdmi.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa15.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa17.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa5.inc | 2 +- > > > .../include/tune-cortexa57-cortexa53.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa7.inc | 2 +- > > > .../include/tune-cortexa72-cortexa53.inc | 2 +- > > > .../include/tune-cortexa73-cortexa53.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa8.inc | 2 +- > > > meta/conf/machine/include/tune-cortexa9.inc | 2 +- > > > meta/conf/machine/include/tune-ep9312.inc | 2 +- > > > meta/conf/machine/include/tune-iwmmxt.inc | 2 +- > > > .../machine/include/tune-strongarm1100.inc | 2 +- > > > meta/conf/machine/include/tune-xscale.inc | 2 +- > > > meta/conf/machine/include/x86/arch-x86.inc | 12 +- > > > .../recipes-core/images/core-image-minimal.bb | 2 +- > > > .../qemu/qemu-system-native_5.1.0.bb | 2 +- > > > meta/recipes-devtools/qemu/qemu_5.1.0.bb | 4 +- > > > .../vulkan/vulkan-demos_git.bb | 2 +- > > > meta/recipes-kernel/linux/linux-yocto-dev.bb | 2 +- > > > .../linux/linux-yocto-rt_5.4.bb | 2 +- > > > .../linux/linux-yocto-rt_5.8.bb | 2 +- > > > meta/recipes-kernel/linux/linux-yocto_5.4.bb | 4 +- > > > meta/recipes-kernel/linux/linux-yocto_5.8.bb | 4 +- > > > .../libpng/libpng_1.6.37.bb | 2 +- > > > scripts/pybootchartgui/pybootchartgui/main.py | 184 > > > +++++++++++++++++- > > > > Cleanup is good but this last bit doesn't look quite right! > > I 100% agree, but it is from the the command I mentioned in the commit > message. In fact, I ran it again just to be sure it wasn't an > accident. I have no idea why that file is being so heavily modified > perhaps the sed regex is having some unforeseen side effect. I'll > remove it by hand from the commit and push a v3. > > Thanks, > Jon > > > > > Cheers, > > > > Richard > > > > > >