From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF156C433ED for ; Mon, 17 May 2021 23:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBEE661185 for ; Mon, 17 May 2021 23:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344613AbhEQXwD (ORCPT ); Mon, 17 May 2021 19:52:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344597AbhEQXwC (ORCPT ); Mon, 17 May 2021 19:52:02 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA07C061756 for ; Mon, 17 May 2021 16:50:45 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id h7so4074111plt.1 for ; Mon, 17 May 2021 16:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rri/ZUWebCAURWUdOsBuRJz+8kSWlPQMsU2NIL6PvoY=; b=FRMPueRDHgiD5iCfFvtD1s0ilAwmF/bus1HxUHlZsO4yO+Y4hKh9zMq4hstI9wA+yr Ns3pzVTPc0f4VwxvgvaiwPAcXYq5wTkTUnEcw5bxrcDTzD7zqgsfQ1MyutHQP97qzgIo ecMfPUCp/aKHEWCaIUKcnuTuMiSyd6R3+z64HVpN1n8fy5NIjhZggdtG6T8scxbMAYZi nthZhEZrnsytJUDMpXJmY2YmWXPWE0xdmWlUKf3ihhZXJbPVkSjul1zUJqJ6AYuIG5hn nJZdH4r8iXoMsNTCpb1NG+rMOvyOHBJQS8ZZnYa5EKDqIel5WoRnSevz3VAh/ZKh4bi1 5JyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rri/ZUWebCAURWUdOsBuRJz+8kSWlPQMsU2NIL6PvoY=; b=lkiPtV3DQR/cr0wcWy0d9WlzJ26u1yJwxc1x701zZeGM2NVspzuVIu6KaM6lngd27q WlU2H8+AxTEs9hEAZDD57wUwx5WO2BgLWaqQjNstZaJKuzV7zQsNle0LP3dD0VsOzh3Z O1fuH4riQLgBgW0uoNGWG1E0u3/K28mBv3iSVbtSj1y2a7sOyVGSiTU9xfnaqxD2/LEd lwCP6r6CLZyy6m3KWdM2c6RTcoZ8srgyzGMF2zTWoKoq8P3MConr1SJdkSxE9qtY3Xr+ 21y+L8Ekj9wt86doNRBV2qj70nTw6PYyclUgtB78xXjCBJFdYdjFOrAf5dJv6wLy/NYg sYwQ== X-Gm-Message-State: AOAM532ducTHDnzhtL4kH+Sf7Ll3ZjdJNtu/8fq6NNdVCX3thVvk9VK7 aGqtsJ0RVw6uwiSUbNq/69OA7rtUrfc4Kijz+iPN+w== X-Google-Smtp-Source: ABdhPJyy7iz0pvj/Fs0u3ozhUqVj0td4iHAzKCmbTFdgNCXrudwdwNQEWknZydQnZmI8D3Vrap2sp+6pKzwu8PknRfw= X-Received: by 2002:a17:90a:6f06:: with SMTP id d6mr2110560pjk.216.1621295444570; Mon, 17 May 2021 16:50:44 -0700 (PDT) MIME-Version: 1.0 References: <20210424004645.3950558-1-seanjc@google.com> <20210424004645.3950558-36-seanjc@google.com> In-Reply-To: <20210424004645.3950558-36-seanjc@google.com> From: Reiji Watanabe Date: Mon, 17 May 2021 16:50:28 -0700 Message-ID: Subject: Re: [PATCH 35/43] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -1204,12 +1204,6 @@ static void init_vmcb(struct kvm_vcpu *vcpu) > init_sys_seg(&save->ldtr, SEG_TYPE_LDT); > init_sys_seg(&save->tr, SEG_TYPE_BUSY_TSS16); > > - svm_set_cr0(vcpu, X86_CR0_NW | X86_CR0_CD | X86_CR0_ET); > - svm_set_cr4(vcpu, 0); > - svm_set_efer(vcpu, 0); > - kvm_set_rflags(vcpu, X86_EFLAGS_FIXED); > - vcpu->arch.regs[VCPU_REGS_RIP] = 0x0000fff0; Reviewed-by: Reiji Watanabe Those your vCPU RESET/INIT changes look great. I think the change in init_vmcb() basically assumes that the function is called from kvm_vcpu_reset(via svm_vcpu_reset()). Although shutdown_interception() directly calls init_mcb(), I would think the change doesn't matter for the shutdown interception case. IMHO it would be a bit misleading that a function named 'init_vmcb', which is called from other than kvm_vcpu_reset (svm_vcpu_reset()), only partially resets the vmcb (probably just to me though). So, I personally think it would be better if its name or comment can give some more specific information about the assumption. BTW, it looks like two lines of "vcpu->arch.hflags = 0;" can be also removed from the init_vmcb() as well. Thanks, Reiji