From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE17C433F5 for ; Fri, 17 Dec 2021 12:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236435AbhLQMs4 (ORCPT ); Fri, 17 Dec 2021 07:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236392AbhLQMsz (ORCPT ); Fri, 17 Dec 2021 07:48:55 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C48CC06173E for ; Fri, 17 Dec 2021 04:48:55 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id q16so3830303wrg.7 for ; Fri, 17 Dec 2021 04:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=snUeSCccdhoRxlfsg8Ts9j6VNOw1G6e55Lk+9WKqlyc=; b=VrmeN3wpi1gNrML4Do0CYOVryw5xkN4me97Ek7NhAj7E67onCecFOZV06lH2uNNoJ0 YR5aTAScn+MqHEktNhQIouNZlSvvsSqlSYK5pSwn8ZCcOfFGQXYPYLSNyVpWYH2ymQrB 2/qLQ5fz8zm9gKd9baYQ2q+5P0Qc+27cwpVt1UayVc8QE1JtQhIVPcXFDxT5a1Mg3OXy hupJvCEkFLVmuspWM2kMimCBqqJ+XCEPm+jiE3o2oOqxeeZZELizJuZJIoiaxKgrMqsV yWiWsLt+2WpKUJlE59KZU1/7iNyhKk7B5XFEwrxms8hnaYVQ8erxC3etPvF7V8Qf5rOd 9Zew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=snUeSCccdhoRxlfsg8Ts9j6VNOw1G6e55Lk+9WKqlyc=; b=SY3G9f+dh8+jbjnTQfVkHgEvNIjdUK7TjHxV8A/KMqQYviBvzl/09D8SRlsLsJi6E1 YgMSjFuMnKZKJ67gugjV2q3H758YOi1jTAhYHpGhHX7TbVib5kAmtVJXNdXhuDq5HTJo WLBqemfeyn3fuNgSJeTzzlvRPM+kfgfB52NyqGW0D7vqKT49hziMF4Gnt1r4g52NGobP XuB7ED3e+qep/d7TRiigwaAvHALLNfnUL3jXKnPs5Y/bmTwhhmLqH992cGkTKhCFj1bB 0aCaetoxKDHtSxuroPIgAy0H6d4qO585koYH97ySKTCq9EdBezlMYkrMS9u+5l3kpF6p qHUw== X-Gm-Message-State: AOAM530yOVA7rJ37ypGKY3CyhIhMV49x+YrH9LXhmxckUaqTXOpRWXVl sKQMySIQ+4Txwuhj8wH7SofyKjI89E90Ezsvzewl4Q== X-Google-Smtp-Source: ABdhPJy6jZjbGiy24EK1rrImb8JGalcQGHnt5zFcmV3cEzqNUYKetq2K2+tqD4tnFwJzeYSapqKjLx5IuF9v9+BKmaA= X-Received: by 2002:adf:efd0:: with SMTP id i16mr2505380wrp.86.1639745333595; Fri, 17 Dec 2021 04:48:53 -0800 (PST) MIME-Version: 1.0 References: <4f409ac939e260a4657a0e6e6518ef8736527822.1639744468.git.geert@linux-m68k.org> In-Reply-To: <4f409ac939e260a4657a0e6e6518ef8736527822.1639744468.git.geert@linux-m68k.org> From: Anup Patel Date: Fri, 17 Dec 2021 18:18:42 +0530 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: timer: sifive,clint: Fix number of interrupts To: Geert Uytterhoeven Cc: Daniel Lezcano , Thomas Gleixner , Palmer Dabbelt , Paul Walmsley , Anup Patel , Rob Herring , "linux-kernel@vger.kernel.org List" , DTML , linux-riscv , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems". As the architectural maximum > is 4095 interrupts, using that as the limit would be unpractical. Hence > limit it to 10 interrupts (two interrupts for a system management core, > and two interrupts per core for other cores). This should be sufficient > for now, and the limit can always be increased when the need arises. Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup > > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring > --- > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 10 > > additionalProperties: false > > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D951EC433F5 for ; Fri, 17 Dec 2021 12:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cbtpba+4YCMDEc4NHUlW7NrZNGEgXhSR1e6ZRZsDM5E=; b=S8PZIEwxOWVUz7 34QBonKRjrw2tXiFauq6FODW8MSCHqdSh2ScRyUTEcw/aIn/8ZiEdx78r0iu1thw6syJQZeZU3Uar QD8IHHwl4BZJWvEie3jdFM+XwnUpc4YEIzld/99X2BefR8nQDh/xdysuzZXXay3kIhFb/mVPe4L5L mzv5TRwx9H20Y8vvOHdZaeVzo02TteVp28WMkJz+HuxPMJ8UdfH7YoPmJjyek4hzzpwsfvKgVN76S RIb56zEgZ3kqJLPvIP5t3o+0TgBUF4/qq3R6NlpJu8CxdmrEKyfWgzsq3JL3ZhDwX6tIMQVzXlkJd HEq8uM5fwfBdaQTS6awA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myCfT-00AE0D-1k; Fri, 17 Dec 2021 12:48:59 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myCfP-00ADxE-PZ for linux-riscv@lists.infradead.org; Fri, 17 Dec 2021 12:48:57 +0000 Received: by mail-wr1-x42c.google.com with SMTP id a9so3815621wrr.8 for ; Fri, 17 Dec 2021 04:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=snUeSCccdhoRxlfsg8Ts9j6VNOw1G6e55Lk+9WKqlyc=; b=VrmeN3wpi1gNrML4Do0CYOVryw5xkN4me97Ek7NhAj7E67onCecFOZV06lH2uNNoJ0 YR5aTAScn+MqHEktNhQIouNZlSvvsSqlSYK5pSwn8ZCcOfFGQXYPYLSNyVpWYH2ymQrB 2/qLQ5fz8zm9gKd9baYQ2q+5P0Qc+27cwpVt1UayVc8QE1JtQhIVPcXFDxT5a1Mg3OXy hupJvCEkFLVmuspWM2kMimCBqqJ+XCEPm+jiE3o2oOqxeeZZELizJuZJIoiaxKgrMqsV yWiWsLt+2WpKUJlE59KZU1/7iNyhKk7B5XFEwrxms8hnaYVQ8erxC3etPvF7V8Qf5rOd 9Zew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=snUeSCccdhoRxlfsg8Ts9j6VNOw1G6e55Lk+9WKqlyc=; b=B/Lp1SOnjNgPsS2Gent2lBBfpXzPszRkOrhOd5zdkilFcauT4zF4d8KB5p9PbM2dYB IFPlaAEVYflt3vfaeiDIIgPsT/4rV74yzWKtXamsjR6OU0Yf+OopsQcB7eGGIYZxM2Vu Q0HlQRHLaiz7jR0pBqQxI+AnBTVqvX5VaInjkKjvcZsd0SxkYK0ykUtdIMxhaIc9sdkv vZ9gK+Qbw9l+xoTsbI0ewrI8znKPwEVHVk58R8bbJijdu1ZUGYq+eqoY8nJxOMrMyyJK fIiEnpraYZrSMSRRBC+s/RGRn8t//8bAo3FI4ZBjHpa0OMnQ/lLUFLzcpSyf1m0rGDty pDkg== X-Gm-Message-State: AOAM531vYAj6rSVHNXvMse1uZ/cbtNB8XqIXBJGBRMCXDiFQB7c1bcTp gd3QBnO0wDYTpL9uyROtYHBo5MTgjpDJ/YvcwcHxFw== X-Google-Smtp-Source: ABdhPJy6jZjbGiy24EK1rrImb8JGalcQGHnt5zFcmV3cEzqNUYKetq2K2+tqD4tnFwJzeYSapqKjLx5IuF9v9+BKmaA= X-Received: by 2002:adf:efd0:: with SMTP id i16mr2505380wrp.86.1639745333595; Fri, 17 Dec 2021 04:48:53 -0800 (PST) MIME-Version: 1.0 References: <4f409ac939e260a4657a0e6e6518ef8736527822.1639744468.git.geert@linux-m68k.org> In-Reply-To: <4f409ac939e260a4657a0e6e6518ef8736527822.1639744468.git.geert@linux-m68k.org> From: Anup Patel Date: Fri, 17 Dec 2021 18:18:42 +0530 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts To: Geert Uytterhoeven Cc: Daniel Lezcano , Thomas Gleixner , Palmer Dabbelt , Paul Walmsley , Anup Patel , Rob Herring , "linux-kernel@vger.kernel.org List" , DTML , linux-riscv , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211217_044855_879802_C3216ACC X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Dec 17, 2021 at 6:08 PM Geert Uytterhoeven wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems". As the architectural maximum > is 4095 interrupts, using that as the limit would be unpractical. Hence > limit it to 10 interrupts (two interrupts for a system management core, > and two interrupts per core for other cores). This should be sufficient > for now, and the limit can always be increased when the need arises. Same comment as the PLIC DT binding patch. The "maxItems" should represent CLINT spec constraints so please don't add any synthetic value here. Regards, Anup > > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring > --- > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > index 8d5f4687add9e81e..b75fd6f982b1ecb3 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -44,6 +44,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 10 > > additionalProperties: false > > -- > 2.25.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv