Re: [PATCH 0 of 2] Add libxc API that sets mem_access type for an array of gfns

From: Aravindh Puthiyaparambil <aravindh@virtuata.com>
To: Tim Deegan <tim@xen.org>
Cc: Christian.Limpach@gmail.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 0 of 2] Add libxc API that sets mem_access type for an array of gfns
Date: Fri, 27 Apr 2012 11:26:42 -0700	[thread overview]
Message-ID: <CAB10MZA=w3=EBsp2yqq5t2YXKhi2u9+m22r90b3Z7uVY0C1cFQ@mail.gmail.com> (raw)
In-Reply-To: <20120427084832.GA86045@ocelot.phlegethon.org>

On Fri, Apr 27, 2012 at 1:48 AM, Tim Deegan <tim@xen.org> wrote:
> At 18:36 -0700 on 26 Apr (1335465381), Aravindh Puthiyaparambil wrote:
>> > - this is wrong:
>> > > -        old_entry = *ept_entry;
>> > > +        old_entry->epte = ept_entry->epte;
>> > You should follow the code and see what uses old_entry and you'll see
>> > that within the function old_entry->mfn is used (your diff changes the
>> > line that uses it) and ept_free_entry also accesses mfn.
>>
>> I will fix that.
>>
>> > - are you sure you can move the ept_sync_domain call past the iommu code?
>> >
>>
>> I was hoping Tim would give me feedback about that.
>
> I'm afraid I won't be able to review this code until next week.  This
> change is already too late for the 4.2 freeze, though, so there's plenty
> of time to get it right after we branch.

Not a problem. This can wait for post 4.2. By then I would have
reworked it the way Christian was mentioning.

Thanks,
Aravindh