Re: [PATCH BlueZ 1/3] adapter-api: Rename ResetData to DuplicateData filter

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi Marcel,

On Mon, Aug 28, 2017 at 5:21 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Luiz,
>
>> Since essencially what this filter would be doing is disable duplicate
>> for data use it instead of ResetData.
>> ---
>> doc/adapter-api.txt |  9 +++++----
>> src/adapter.c       | 32 ++++++++++++++++----------------
>> src/device.c        |  8 ++++----
>> src/device.h        |  5 +++--
>> 4 files changed, 28 insertions(+), 26 deletions(-)
>>
>> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
>> index c2898694d..eaf96f36c 100644
>> --- a/doc/adapter-api.txt
>> +++ b/doc/adapter-api.txt
>> @@ -58,7 +58,8 @@ Methods             void StartDiscovery()
>>                       int16         RSSI      : RSSI threshold value
>>                       uint16        Pathloss  : Pathloss threshold value
>>                       string        Transport : type of scan to run
>> -                     bool          ResetData : Reset advertisement data
>> +                     bool          DuplicateData : Disables duplicate
>> +                     detection of advertisement data.
>>
>>                       When a remote device is found that advertises any UUID
>>                       from UUIDs, it will be reported if:
>> @@ -91,9 +92,9 @@ Methods             void StartDiscovery()
>>                       the RSSI delta-threshold, that is imposed by
>>                       StartDiscovery by default, will not be applied.
>>
>> -                     If ResetData is enabled PropertiesChanged signals will
>> -                     be generated for either ManufacturerData and ServiceData
>> -                     everytime they are discovered.
>> +                     If DuplicateData is enabled PropertiesChanged signals
>> +                     will be generated for either ManufacturerData and
>> +                     ServiceData everytime they are discovered.
>
> mention that this is false by default when omitted.

Will add it to the documentation.

> We should in addition state that even if this is omitted or set to false, the duplicate filtering is best-effort and not guaranteed. Unless we actually plan to have a huge report cache in bluetoothd.

It checks if it is duplicated from the last received report, there is
no report aggregation, so the caching is really minimal just to avoid
sending PropertiesChanges with the same data when scanning.

> Regards
>
> Marcel
>



-- 
Luiz Augusto von Dentz