From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC20C4708F for ; Wed, 2 Jun 2021 13:45:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15EEC613AE for ; Wed, 2 Jun 2021 13:45:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15EEC613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loRBS-0007BE-3n for qemu-devel@archiver.kernel.org; Wed, 02 Jun 2021 09:45:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loRAU-0005vq-3i; Wed, 02 Jun 2021 09:44:22 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:42691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loRAS-0005oM-9O; Wed, 02 Jun 2021 09:44:21 -0400 Received: by mail-qv1-xf41.google.com with SMTP id u33so1288726qvf.9; Wed, 02 Jun 2021 06:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=129Pl9OSeUE3s5KLE+dbt5S1ITWq22ra9ssXImBVUdk=; b=R7WLlCg809KsuGwbbWqQm/Ad6sqwzSKUBVX3BbtrUgKeXhAuF43MqFuViwFvzD+isf I9DmsCTXR2mLWcEsBxMLxM7CQWMuxrf7ZaNOnSSlHVpOJSuRU5hHeGsoaynmNbu2OEnJ vH5BHjdtCTZNdWrKFajAucg+e5U1rXn/ZUI8GGRsP8qfrg/WbIB+ULKybmWrQ3Nu9k5g 5olYn60rz9eEvQJRCHKrqhciTKf3L3ofCbEnAHkduj39/Q9EXOjIzjsenvfptAgdqkgw mdk2n+tuQdGdvjLiJTmeMZvka/zsPUBzjlSCxgw4H5qAUBuurKv87DOQZVoLrhOuqYC4 Sv/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=129Pl9OSeUE3s5KLE+dbt5S1ITWq22ra9ssXImBVUdk=; b=s5MbzSBncq8kF3HAbsJVX3BWQ90nw6A1HczXu6JYvEmkgjgpTYpfFPWE5EVZS2x1b/ tA1bfe0gflSgcWbpT8cb/OUPk2ycPTJuZBa5CVKaEO72mZuOv7GCkAvzyhKSfpfXck6u wSGdufS1B7CNGeaoJ3grIhE/AmViBjI5sauDKwxupMoNgp8ypRJyGmZHFPepFDo9kzCD CUG/bZiupanq5uzE//Udi1WeaN7dkExKEJd6xHyr/68qTZyeTqeBu99PYSMlZu/8U4dv gPcN6eImUV4rTr9R4beHGxGZI7Qvf3pvsfrvFynKzuBFTu9CwBFJ68MWGevV0qweszN1 EVjA== X-Gm-Message-State: AOAM531llYX3qPw+NTKOhSaWcYRvSPAeUcMVchOIP2GMt9nIMtWupgEz dp/CIhS/DuEK7gdqTc3sb7BOM1YBawbCc/lJiLs= X-Google-Smtp-Source: ABdhPJzJ1IM7GvIyLG2Ec1ojxpdCcaNeISEKLqwd4bbo2Rzlq6f99UZSFiK5sQc53lMQvxveefSd+iKMgGhS5saljQw= X-Received: by 2002:a0c:c184:: with SMTP id n4mr28431158qvh.36.1622641458215; Wed, 02 Jun 2021 06:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Dongjiu Geng Date: Wed, 2 Jun 2021 21:44:07 +0800 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Swetha Joshi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f41; envelope-from=gengdongjiu1@gmail.com; helo=mail-qv1-xf41.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Peter Maydell , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Swetha Joshi =E4=BA=8E2021=E5=B9=B45=E6=9C=8829= =E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=883:41=E5=86=99=E9=81=93=EF=BC= =9A > > I apologize for the delay, here are the repro steps: > 1. Remove CONFIG_ARM_VIRT=3Dy from arm-softmmu.mak > 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in= all the places where we disable kvm using -disable-kvm, replace this with = -enable-kvm > 3. Build According to your steps, I can not see such errors=EF=BC=8Calso your change= is odd. I suggested you do not this change until you indeed encounter errors diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devices/arm-softmmu.mak index 0500156a0c..f47ab0f3b1 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -6,7 +6,6 @@ CONFIG_ARM_V7M=3Dy # CONFIG_PCI_DEVICES=3Dn # CONFIG_TEST_DEVICES=3Dn -CONFIG_ARM_VIRT=3Dy CONFIG_CUBIEBOARD=3Dy CONFIG_EXYNOS4=3Dy CONFIG_HIGHBANK=3Dy diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index e94d95ec54..95387c3e5a 100644 --- a/tests/vm/Makefile.include +++ b/tests/vm/Makefile.include @@ -110,7 +110,7 @@ vm-build-%: $(IMAGES_DIR)/%.img " VM-BUILD $*") vm-boot-serial-%: $(IMAGES_DIR)/%.img - qemu-system-x86_64 -enable-kvm -m 4G -smp 2 -nographic \ + qemu-system-x86_64 -disable-kvm -m 4G -smp 2 -nographic \ -drive if=3Dnone,id=3Dvblk,cache=3Dwriteback,file=3D"$<" \ -netdev user,id=3Dvnet \ -device virtio-blk-pci,drive=3Dvblk \ > > You should see errors pointing to these routines: virt_is_acpi_enabled, a= cpi_ghes_record_errors > > Thanks, > Swetha. > > On Fri, May 28, 2021 at 12:08 AM Dongjiu Geng wr= ote: >> >> Peter Maydell =E4=BA=8E2021=E5=B9=B45=E6=9C= =8827=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8A=E5=8D=882:19=E5=86=99=E9=81=93= =EF=BC=9A >> > >> > On Wed, 26 May 2021 at 18:32, Swetha Joshi = wrote: >> > > >> > > Hello, >> > > >> > > One of the qemu machines we use has KVM enabled, but we don't want t= he CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physica= l hardware that we don't need. The compilation errors I mentioned are not i= n the qemu mainline per say but we see them in one of the qemu derived mach= ines we use. >> > >> > Sure, but unless you can give me a recipe for reproducing the >> > build failure in mainline I can't really help... >> >> Hi Swetha=EF=BC=8C >> Yes, Can you give a method that how to reproduce the build >> failure issues? Thanks >> >> > >> > thanks >> > -- PMM > > > > -- > Regards > > Swetha Joshi.