All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keno Fischer <keno@juliacomputing.com>
To: Greg Kurz <groug@kaod.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 15/20] 9p: darwin: *xattr_nofollow implementations
Date: Sat, 2 Jun 2018 16:01:54 -0400	[thread overview]
Message-ID: <CABV8kRyNgQMKdRnKVnJ9anCi0pR59qAXN_P_UP9aAqGRZErHCw@mail.gmail.com> (raw)
In-Reply-To: <20180601131352.6ab033aa@bahia.lan>

> I guess this calls for some defines in 9p.h:
>
> /* 9p2000.L says that the 'flags' argument of operation 'xattrcreate'
>  * are derived from Linux setxattr.
>  */
> #define P9_XATTR_CREATE  1
> #define P9_XATTR_REPLACE 2
>
> Please do that in a preparatory patch.
>
> I would also appreciate you look at other 9P operations and
> check if we have other places where we need to translate
> some flags.

I will include this additional patch in the next respin of the series.
I took a look at the remaining protocol messages and it looks
like with the exception of this and unlinkat (the other patch in the
series), flags/open modes are translated properly.

  reply	other threads:[~2018-06-02 20:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01  1:25 [Qemu-devel] [PATCH v2 00/20] 9p: Add support for Darwin Keno Fischer
2018-06-01  1:25 ` [Qemu-devel] [PATCH v2 01/20] cutils: Provide strchrnul Keno Fischer
2018-06-01  8:15   ` Greg Kurz
2018-06-01  8:46     ` Dr. David Alan Gilbert
2018-06-01 14:15   ` Eric Blake
2018-06-01  1:25 ` [Qemu-devel] [PATCH v2 02/20] 9p: proxy: Fix size passed to `connect` Keno Fischer
2018-06-01  9:09   ` Greg Kurz
2018-06-01  1:25 ` [Qemu-devel] [PATCH v2 03/20] 9p: xattr: Fix crash due to free of uninitialized value Keno Fischer
2018-06-01  9:19   ` Greg Kurz
2018-06-01  1:25 ` [Qemu-devel] [PATCH v2 04/20] 9p: linux: Fix a couple Linux assumptions Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 05/20] 9p: Properly set errp in fstatfs error path Keno Fischer
2018-06-01  9:32   ` Greg Kurz
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 06/20] 9p: Avoid warning if FS_IOC_GETVERSION is not defined Keno Fischer
2018-06-01  9:57   ` Greg Kurz
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 07/20] 9p: Move a couple xattr functions to 9p-util Keno Fischer
2018-06-01 10:03   ` Greg Kurz
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 08/20] 9p: Rename 9p-util -> 9p-util-linux Keno Fischer
2018-06-01 10:07   ` Greg Kurz
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 09/20] 9p: Properly check/translate flags in unlinkat Keno Fischer
2018-06-01 10:13   ` Greg Kurz
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 10/20] 9p: darwin: Handle struct stat(fs) differences Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 11/20] 9p: darwin: Handle struct dirent differences Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 12/20] 9p: darwin: Explicitly cast comparisons of mode_t with -1 Keno Fischer
2018-06-29 20:32   ` Eric Blake
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 13/20] 9p: darwin: Ignore O_{NOATIME, DIRECT} Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 14/20] 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 15/20] 9p: darwin: *xattr_nofollow implementations Keno Fischer
2018-06-01 11:13   ` Greg Kurz
2018-06-02 20:01     ` Keno Fischer [this message]
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 16/20] 9p: darwin: Compatibility for f/l*xattr Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 17/20] 9p: darwin: Provide a fallback implementation for utimensat Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 18/20] 9p: darwin: Implement compatibility for mknodat Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 19/20] 9p: darwin: virtfs-proxy: Implement setuid code for darwin Keno Fischer
2018-06-01  1:26 ` [Qemu-devel] [PATCH v2 20/20] 9p: darwin: configure: Allow VirtFS on Darwin Keno Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABV8kRyNgQMKdRnKVnJ9anCi0pR59qAXN_P_UP9aAqGRZErHCw@mail.gmail.com \
    --to=keno@juliacomputing.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.