All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
	Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers
Date: Thu, 8 Apr 2021 21:03:57 +0200	[thread overview]
Message-ID: <CABgObfad1g5n=Ya5+b9m0v_gVbFF1Tbg8Zo+iCuNWsJwiD6oNQ@mail.gmail.com> (raw)
In-Reply-To: <ef103aa2-d585-22ce-0aaf-45a6e190d2ef@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Il gio 8 apr 2021, 18:06 Emanuele Giuseppe Esposito <eesposit@redhat.com>
ha scritto:

>
>
> On 08/04/2021 17:40, Paolo Bonzini wrote:
> > On 07/04/21 15:50, Emanuele Giuseppe Esposito wrote:
> >>       def get_qmp_events_filtered(self, wait=60.0):
> >>           result = []
> >> -        for ev in self.get_qmp_events(wait=wait):
> >> +        qmp_wait = wait
> >> +        if qemu_gdb:
> >> +            qmp_wait = 0.0
> >> +        for ev in self.get_qmp_events(wait=qmp_wait):
> >>               result.append(filter_qmp_event(ev))
> >>           return result
> >
> > Should this be handled in get_qmp_events instead, since you're basically
> > changing all the callers?
>
> get_qmp_events is in python/machine.py, which as I understand might be
> used also by some other scripts, so I want to keep the changes there to
> the minimum. Also, machine.py has no access to qemu_gdb or
> qemu_valgrind, so passing a boolean or something to delay the timer
> would still require to add a similar check in all sections.
>
> Or do you have a cleaner way to do this?
>

Maybe a subclass IotestsMachine?

Paolo


> Emanuele
>
>

[-- Attachment #2: Type: text/html, Size: 1922 bytes --]

  reply	other threads:[~2021-04-08 19:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 13:50 [RFC PATCH v2 00/11] qemu_iotests: improve debugging options Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 01/11] python: qemu: add timer parameter for qmp.accept socket Emanuele Giuseppe Esposito
2021-04-08 19:51   ` John Snow
2021-04-09 16:01     ` Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 02/11] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine Emanuele Giuseppe Esposito
2021-04-08 19:59   ` John Snow
2021-04-09 16:07     ` Emanuele Giuseppe Esposito
2021-04-09 16:37       ` John Snow
2021-04-07 13:50 ` [RFC PATCH v2 03/11] qemu-iotests: add option to attach gdbserver Emanuele Giuseppe Esposito
2021-04-08 15:40   ` Paolo Bonzini
2021-04-08 16:02     ` Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers Emanuele Giuseppe Esposito
2021-04-08 15:40   ` Paolo Bonzini
2021-04-08 16:06     ` Emanuele Giuseppe Esposito
2021-04-08 19:03       ` Paolo Bonzini [this message]
2021-04-09 16:13         ` Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 05/11] qemu_iotests: insert gdbserver command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 06/11] qemu-iotests: add gdbserver option to script tests too Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 07/11] qemu_iotests: extend the check script to support valgrind for python tests Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 08/11] qemu_iotests: extent QMP socket timeout when using valgrind Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 09/11] qemu_iotests: allow valgrint to print/delete the generated log file Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 10/11] qemu_iotests: insert valgrind command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-04-07 13:50 ` [RFC PATCH v2 11/11] qemu_iotests: add option to show qemu binary logs on stdout Emanuele Giuseppe Esposito
2021-04-08  8:26 ` [RFC PATCH v2 00/11] qemu_iotests: improve debugging options Markus Armbruster
2021-04-08 11:15   ` Emanuele Giuseppe Esposito
2021-04-08 12:39     ` Markus Armbruster
2021-04-08 13:41       ` Emanuele Giuseppe Esposito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfad1g5n=Ya5+b9m0v_gVbFF1Tbg8Zo+iCuNWsJwiD6oNQ@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=crosa@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.