From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4514C433EF for ; Tue, 12 Apr 2022 08:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3PS8oCTC0T8khYPwT83Jj7kHLpgGcV6x5RfIeobaxmU=; b=Pj5wqJL7dV6EVWPdmw1LavIyoI taefevxP+IGk6ZzhZAYcEfa/e7jsUYHoKkTukv5Hvqryx5cQlb6WBNeDRdSgvENgN0sBZHGtQ7Hom Dc7oIdmpqwjFI07z88fWoQrNr0zlgVVR57yYo4P5zanEcjQwTBb4PxVxlEChzneYcQ5JVItOfSdZk lqvTRf+jDzwmIG0hv87kUD9pH34jJW4Dc2non9v/2JsoMPDXRRJaR1fSXiQxtaBU5NejVAJh3zC5v GCkrvDoCtAQUo9Du/HhdYJZYo9cR55x1eqFV4Vs+9DBHumGg7J93yLOGqMgNwtZgpivS9/z1RLL96 r7xPm7Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLY-00CjNS-LO; Tue, 12 Apr 2022 08:58:00 +0000 Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLU-00CjJq-8Z for linux-mediatek@lists.infradead.org; Tue, 12 Apr 2022 08:57:59 +0000 Received: by mail-oi1-x22f.google.com with SMTP id e4so18383381oif.2 for ; Tue, 12 Apr 2022 01:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=O4uumP51JcV7qBCLnK0EA1pkMY6sGD/pTvzvNjou2PgcdwHOFuibGIptBgZ3zJNPCO HNcpOraxajhSfH6FKpX+oohFsR9+cAmNzr3raUAIRjIXsDz70WJRGRPe0sBzCtIorZSn jwU9hlWq8nhRQgCL+0BDauOseU08SQ6kHBE39slH9gyCacBPIRunwbgJFwT4MEAkgB4u XOLgBEcCs1r6ODorwmX7IF0ZhAGaeOSeAxRCXAcIUN8mXCyKnW+FU3R/7MlScEWkf0VY ZvjB33mZDqS56xB5bdfVu9Bjy/qdU0l0vvxbk6G4z6AorUZE6E2dkUcfig1wxL70aOEU PS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=DFskgT4XG5X8NJ5LLwHoy7ARYf2JSsiNlJ5vGlYNfqFf6D3iH8NuNhipaAACSpTsWz CqP8x77Hxy8Y0PQxpHsyp0yzzjXF6Xa7DRQF3AhhUqFL85Skku9Pe7NfH1i7BIxlp/jq Ecy0kpFEyz9J/7lZQmLW9I/uQfuUJKfnqhDBLQud453Cjqx1cWjKi92KRqezUQ8BWxBP Wy+loiBIVRnpxRDGrXjjdA9G52ZkIeyGeAP5sKgVNg1Rs8edWafv+SM7J/EWnDQ6CVqm X6mLNZObeZe7QiuJBG3wNiksz6jb9/I1O2hvdrnx2FUT6LSwxokzYuO+fdXW6LxA5WTi X+7g== X-Gm-Message-State: AOAM5328ScsgOQ5hIwRY9WBRHQaBDRuzRT8DplMKtvn2ucVpUgNYE4zN 7vL4xg9Ce73Q6QySKNgbF+2BAU35EkzqCGU3X5+vcg== X-Google-Smtp-Source: ABdhPJyGsXSnBb0OrYJzuxK+lplYEUvtBMZUA3XN/6JoCjC1Dfht5xOEuqQ6v8izMrWtfTdYVEwhffLY26AWeFbXjVU= X-Received: by 2002:a05:6808:159d:b0:2da:3946:ab3d with SMTP id t29-20020a056808159d00b002da3946ab3dmr1258843oiw.248.1649753874382; Tue, 12 Apr 2022 01:57:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:57:53 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-5-granquet@baylibre.com> <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> In-Reply-To: <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:57:53 -0700 Message-ID: Subject: Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015756_550472_35B6EA53 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3148C433EF for ; Tue, 12 Apr 2022 08:57:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20DE710FF9C; Tue, 12 Apr 2022 08:57:56 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E6C10FF99 for ; Tue, 12 Apr 2022 08:57:55 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id 12so18336720oix.12 for ; Tue, 12 Apr 2022 01:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=O4uumP51JcV7qBCLnK0EA1pkMY6sGD/pTvzvNjou2PgcdwHOFuibGIptBgZ3zJNPCO HNcpOraxajhSfH6FKpX+oohFsR9+cAmNzr3raUAIRjIXsDz70WJRGRPe0sBzCtIorZSn jwU9hlWq8nhRQgCL+0BDauOseU08SQ6kHBE39slH9gyCacBPIRunwbgJFwT4MEAkgB4u XOLgBEcCs1r6ODorwmX7IF0ZhAGaeOSeAxRCXAcIUN8mXCyKnW+FU3R/7MlScEWkf0VY ZvjB33mZDqS56xB5bdfVu9Bjy/qdU0l0vvxbk6G4z6AorUZE6E2dkUcfig1wxL70aOEU PS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=KQxt/PXsTaupo/EFTY5l4+fjgbFJeMs2bW6a+/EWYh4JkJFta/2oRpeweQkuc8VW3o EEuQMGNCCxXFT0TtcLd3APBov+QOVEkrxegD3Z4COnuqq1mm12GR6J0D65acQmZBdqML ig7T3snU7omwx7T5uGGcGcv7iQUj+T5IRDziaoauBBKe8CLSyEvY+NCU6Pzof96IAHTb zMbwl+2akS8hSVoUgXdkVLS76LvV+ozGh7skhcD8Zpu7Mp8UEVxAmz4Gymb1gwdX+QZm F7tnl73cZjedbf9kJb2mx7VlUf1YFYMvM+6xl1mD5lqf2QqD45OdA+n5vo61wVsDuZdW aTEg== X-Gm-Message-State: AOAM533my7SXhXNzmpu9CVgwcMhjwsw1kfyornVSmIil1+5VhBxPWQdw wfjANp2bg6Nd1xaEgiiKJs3q7P+++Gn5f7MO1rsK7w== X-Google-Smtp-Source: ABdhPJyGsXSnBb0OrYJzuxK+lplYEUvtBMZUA3XN/6JoCjC1Dfht5xOEuqQ6v8izMrWtfTdYVEwhffLY26AWeFbXjVU= X-Received: by 2002:a05:6808:159d:b0:2da:3946:ab3d with SMTP id t29-20020a056808159d00b002da3946ab3dmr1258843oiw.248.1649753874382; Tue, 12 Apr 2022 01:57:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:57:53 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-5-granquet@baylibre.com> <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> In-Reply-To: <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:57:53 -0700 Message-ID: Subject: Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, markyacoub@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2D0EC433F5 for ; Tue, 12 Apr 2022 08:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8IzBNUbzNijdyAsQtME/63WSjf7LbO4q+GlQ+bTijOA=; b=UGZRnMCEMbIW24AYjCEAVhooOI ocuzTgZXIi/nTERcu2zXDppY9kxMRHRQy6IMbt/fD7nFd6fIhzucgcBXt/aAtiSOoFJqgifbDEmpY jKjFKKMMMhLKodP7ttxJDFS+wv6zZ35szyCn76J+CAGdfN1OZKONL57P058rxZwgE0KGoqI0enN67 FPi7MK5GRFdi9iuLdFbdcKn0JF7Jd7vlQcK7lEZ4ZjyQaXFKTwdy/5TVvQymyPMlpEkY5Wqa0apQY dBCK163yMXh31qVdTmA7D5JQblPLHOWSslAbGu2h2UCzxpgE+TyjAjE8ygxtr2aDFgICW5wpbBpdU QtfRDiDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLn-00CjV9-5j; Tue, 12 Apr 2022 08:58:15 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLV-00CjKK-5E for linux-phy@lists.infradead.org; Tue, 12 Apr 2022 08:57:59 +0000 Received: by mail-oi1-x233.google.com with SMTP id z8so18369372oix.3 for ; Tue, 12 Apr 2022 01:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=O4uumP51JcV7qBCLnK0EA1pkMY6sGD/pTvzvNjou2PgcdwHOFuibGIptBgZ3zJNPCO HNcpOraxajhSfH6FKpX+oohFsR9+cAmNzr3raUAIRjIXsDz70WJRGRPe0sBzCtIorZSn jwU9hlWq8nhRQgCL+0BDauOseU08SQ6kHBE39slH9gyCacBPIRunwbgJFwT4MEAkgB4u XOLgBEcCs1r6ODorwmX7IF0ZhAGaeOSeAxRCXAcIUN8mXCyKnW+FU3R/7MlScEWkf0VY ZvjB33mZDqS56xB5bdfVu9Bjy/qdU0l0vvxbk6G4z6AorUZE6E2dkUcfig1wxL70aOEU PS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=tpZHoGT9tpR0jRkgO44IuLUT5qg4phT28FxKCAbFSWXFuN7+H0nFgIZX/B/KNl+Fel Aktqx9+88cNfqsdp1q7HW0nKS3hbnkizAkOsBh2/QFHAfQfKuReUu9525jBbiRX/yuPG D5PVE9O/MPCHQbGGQ8fuhQcYeZPRizfe5fjNMjtL84v3nLQH9sYhjLoUt580o01oeMNd w6YDQXYsST2DKPfy/TkvIms4QvY5bAIp+xEYfunBFosc4iufFrndg6rEy53gyWNX99oa owIcUf15KrHhXVbCG/rqxgnadzL3eObIhwy3ibTqyd/I8O9cwdrlTaV8Q2xdTQ+8kkkG qzjA== X-Gm-Message-State: AOAM533RPa5bNgSAUX27GyOLNmcNJV5kMc5quHpHlTEVdJa2apVfXEeD L6O+FWiqf9bEuAu02JD0i4oejcFr5TyKbvisF1fQEw== X-Google-Smtp-Source: ABdhPJyGsXSnBb0OrYJzuxK+lplYEUvtBMZUA3XN/6JoCjC1Dfht5xOEuqQ6v8izMrWtfTdYVEwhffLY26AWeFbXjVU= X-Received: by 2002:a05:6808:159d:b0:2da:3946:ab3d with SMTP id t29-20020a056808159d00b002da3946ab3dmr1258843oiw.248.1649753874382; Tue, 12 Apr 2022 01:57:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:57:53 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-5-granquet@baylibre.com> <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> In-Reply-To: <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:57:53 -0700 Message-ID: Subject: Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015757_225645_724DC557 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DE85C433F5 for ; Tue, 12 Apr 2022 08:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9L8z5qa1kUkbFbIRy8mAqKsazdjci0QUOYelImxpBBI=; b=ogr2CyZW54MedpxVYZ/sEEA9AD fwax6W4KrxLeMCOsq9Km2qA3SSEZ8pEfe5j/E+H/7Pir1vr1MbSv2QbNvKkT1348Im77NBg3NS46w GT/8osoG0aJCNdsLda+JixAffHMkFFq9b7UwJkmb9ornOBLs4hVI0+Vhs5pYEt1Mp8EXg5C7GE4Xy mVQquuFytTff6EhiAUsyIQ+HIhjq6Aw91CeGb2WRAPuxy+eQ7fuL3JPSkwU3O+dEAprEjbXq/Vnbp 2aeCUZN/ryg2lReEyzVixXVCtCmlObUthHKsQT7PWeupGn9y7aUkUGdMdrrVo+CUPNh6CZApiZDF1 IJfki4VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLb-00CjO7-Ga; Tue, 12 Apr 2022 08:58:03 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCLU-00CjKJ-OR for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 08:57:59 +0000 Received: by mail-oi1-x22b.google.com with SMTP id q189so18326126oia.9 for ; Tue, 12 Apr 2022 01:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=O4uumP51JcV7qBCLnK0EA1pkMY6sGD/pTvzvNjou2PgcdwHOFuibGIptBgZ3zJNPCO HNcpOraxajhSfH6FKpX+oohFsR9+cAmNzr3raUAIRjIXsDz70WJRGRPe0sBzCtIorZSn jwU9hlWq8nhRQgCL+0BDauOseU08SQ6kHBE39slH9gyCacBPIRunwbgJFwT4MEAkgB4u XOLgBEcCs1r6ODorwmX7IF0ZhAGaeOSeAxRCXAcIUN8mXCyKnW+FU3R/7MlScEWkf0VY ZvjB33mZDqS56xB5bdfVu9Bjy/qdU0l0vvxbk6G4z6AorUZE6E2dkUcfig1wxL70aOEU PS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=QWw+mMWttZ8PicmLldbDhhgFwCCEwr8LleyXJXzY1xmsf5XYljGysj9hgTLW2tJXe+ Gag1QB64xx6/punX6ko1kiLGHHw6E/SOQc3A8pQwbv6E9g3v+zC2jyCZr1/5NVy2R/VP o64EJMI5MSpGMyFi1iE+5LqYfOp8cwntLkZtmcAmytm0i01HOlsRbGDz0RCfWJKMctU6 iE5E0nDx3LbkZuRWowcpFjNgF0Qdk4fkk9I57Nakt0BTn7+7D0KBsNBFug92Wp0NRDAl qyuMkYjznjL+cKMaFiSMJLyC52Ne4pcjQ1yBRwpqS9LaEOlVn3RJGyF6q2BZHL8lVSVJ 0lIQ== X-Gm-Message-State: AOAM530zlQ9lwroEX529EeYyXnP5g8ZlNqRyQvVW/v4ZbWMCLBALWz83 a/2tUGYC43XVRBH1v1w01z9OV2ioNCFmbZyanWcXiw== X-Google-Smtp-Source: ABdhPJyGsXSnBb0OrYJzuxK+lplYEUvtBMZUA3XN/6JoCjC1Dfht5xOEuqQ6v8izMrWtfTdYVEwhffLY26AWeFbXjVU= X-Received: by 2002:a05:6808:159d:b0:2da:3946:ab3d with SMTP id t29-20020a056808159d00b002da3946ab3dmr1258843oiw.248.1649753874382; Tue, 12 Apr 2022 01:57:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:57:53 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-5-granquet@baylibre.com> <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> In-Reply-To: <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:57:53 -0700 Message-ID: Subject: Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_015756_822554_63C8554B X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C26FCC4167B for ; Tue, 12 Apr 2022 10:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376767AbiDLKTa (ORCPT ); Tue, 12 Apr 2022 06:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356296AbiDLJzI (ORCPT ); Tue, 12 Apr 2022 05:55:08 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183456A033 for ; Tue, 12 Apr 2022 01:57:55 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id r8so18361037oib.5 for ; Tue, 12 Apr 2022 01:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=O4uumP51JcV7qBCLnK0EA1pkMY6sGD/pTvzvNjou2PgcdwHOFuibGIptBgZ3zJNPCO HNcpOraxajhSfH6FKpX+oohFsR9+cAmNzr3raUAIRjIXsDz70WJRGRPe0sBzCtIorZSn jwU9hlWq8nhRQgCL+0BDauOseU08SQ6kHBE39slH9gyCacBPIRunwbgJFwT4MEAkgB4u XOLgBEcCs1r6ODorwmX7IF0ZhAGaeOSeAxRCXAcIUN8mXCyKnW+FU3R/7MlScEWkf0VY ZvjB33mZDqS56xB5bdfVu9Bjy/qdU0l0vvxbk6G4z6AorUZE6E2dkUcfig1wxL70aOEU PS7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=4FpzyyLj/OdDU3ZmpUpstG+y8CAFSWZd/AR4b2PM65Y=; b=beUcIHLmV+S6LpykoMLcD9SESvBrBxyuGTaae6FQwDCqQLtL0mFueHGEpkLUK8m28x d5WiIJLM6dghBjRQg+q1CfVZ/m3Xcg+XdHxLy/8h9GvV1jMF+ZbClTWuFIto73osHR3K 7zXxxv1YCwDGWMctpe0HxnHTt0xTU5MhP5xjtNAcFaV9vzqURJ75JBl6YpcJQg3t4jmF OcK7zmfN/0XJJ7PG6VcG1ozzvPrsFLrNhpcQRPlA5JlD2zNCXcwtN2Y769GvEkVWiCdC dkQDWZqCMozFiWTVye00CxXF+hZ5/WvZBXlUEZr+IBH8kKpb0njJD1ZypJXLVwFUAPJe wRTQ== X-Gm-Message-State: AOAM530AnHFToCkDLMjDsGwEhEQZl2+TdRAQiWHiq2jZoJtOpn4dVrMI VXfvkViHSVtvRi78svd3gMIQ/V6AUDrjGG4x5HqGrQ== X-Google-Smtp-Source: ABdhPJyGsXSnBb0OrYJzuxK+lplYEUvtBMZUA3XN/6JoCjC1Dfht5xOEuqQ6v8izMrWtfTdYVEwhffLY26AWeFbXjVU= X-Received: by 2002:a05:6808:159d:b0:2da:3946:ab3d with SMTP id t29-20020a056808159d00b002da3946ab3dmr1258843oiw.248.1649753874382; Tue, 12 Apr 2022 01:57:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Apr 2022 01:57:53 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-5-granquet@baylibre.com> <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> In-Reply-To: <0c523ad5-6a71-5c71-17b8-1f15c1860d89@collabora.com> MIME-Version: 1.0 Date: Tue, 12 Apr 2022 01:57:53 -0700 Message-ID: Subject: Re: [PATCH v9 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc To: AngeloGioacchino Del Regno , vkoul@kernel.org, airlied@linux.ie, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2022 10:04, AngeloGioacchino Del Regno wrote: >Il 28/03/22 00:39, Guillaume Ranquet ha scritto: >> Signed-off-by: Guillaume Ranquet >> --- >> include/drm/drm_edid.h | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 144c495b99c4..5d4d840b9904 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -359,12 +359,17 @@ struct edid { >> >> #define EDID_PRODUCT_ID(e) ((e)->prod_code[0] | ((e)->prod_code[1] << 8)) >> >> -/* Short Audio Descriptor */ > >Hello Guillaume, > >> +/* struct cea_sad - Short Audio Descriptor. >> + @format: See HDMI_AUDIO_CODING_TYPE_*. >> + @channels: max number of channels - 1. >> + @freq: See CEA_SAD_FREQ_*. >> + @byte2: meaning depends on format. >> +*/ > >I appreciate the effort, but this is not valid kerneldoc. > >Please refer to https://docs.kernel.org/doc-guide/kernel-doc.html > >Regards, >Angelo Hello Angelo, Thx for your review. I'm sorry I posted this v9 in a bit of a rush... but I promise we will get there... eventually :D Thx, Guillaume.