From mboxrd@z Thu Jan 1 00:00:00 1970 From: Engel Sanchez Subject: Re: lttng-modules 2.6.1 compilation error on Ubuntu 14.04 Date: Thu, 14 May 2015 13:03:23 -0400 Message-ID: References: <499393386.662.1431609527328.JavaMail.zimbra@efficios.com> <1729124733.954.1431617303791.JavaMail.zimbra@efficios.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1013456068==" Return-path: Received: from mail-ob0-f175.google.com ([209.85.214.175]) by ltt.polymtl.ca with esmtp (Exim 4.80) (envelope-from ) id 1YswXh-00085i-Iy for lttng-dev@lists.lttng.org; Thu, 14 May 2015 13:03:35 -0400 Received: by obblk2 with SMTP id lk2so57703001obb.0 for ; Thu, 14 May 2015 10:03:24 -0700 (PDT) In-Reply-To: <1729124733.954.1431617303791.JavaMail.zimbra@efficios.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lttng-dev-bounces@lists.lttng.org To: Mathieu Desnoyers Cc: lttng-dev@lists.lttng.org List-Id: lttng-dev@lists.lttng.org --===============1013456068== Content-Type: multipart/alternative; boundary=001a1134b02c98ab1305160db4be --001a1134b02c98ab1305160db4be Content-Type: text/plain; charset=UTF-8 Thanks Mathieu! In the meantime I'm using 2.6.0 for the moment and will try your fix when it's ready. On Thu, May 14, 2015 at 11:28 AM, Mathieu Desnoyers < mathieu.desnoyers@efficios.com> wrote: > ----- Original Message ----- > > ----- Original Message ----- > > > > > Hello there. I was wondering if anybody knew what is causing this > > > compilation > > > error I'm getting on a new Ubuntu 14.04 VM with a 3.13.0 kernel. It > does > > > not > > > find the DEBIAN_API_VERSION symbol. The use of that was introduced in > 2.6.1 > > > apparently: > > > > > > http://fossies.org/diffs/lttng-modules/2.6.0_vs_2.6.1/lttng-kernel-version.h-diff.html > > > > > I'm following the instructions in the Download page to install from > the PPA > > > : > > > http://lttng.org/download/#ubuntu > > > > > This the error I'm getting. Thanks in advance for any help! > > > > > In file included from > > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/wrapper/page_alloc.h:28:0, > > > from > > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/lttng-events.c:27: > > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/wrapper/../lttng-kernel-version.h:60:57: > > > error: operator '+' has no right operand ((LINUX_VERSION_CODE * > > > 1000000ULL) > > > + DEBIAN_API_VERSION) > > > > I pushed the following fix into master and stable-2.6 branches > > of lttng-modules. Can you give it a try ? > > > > commit a748963b76f353d459a3faf85eecc96f52811eee > > Author: Mathieu Desnoyers > > Date: Thu May 14 09:13:49 2015 -0400 > > > > Fix: build against Ubuntu kernels > > > > Recent Ubuntu kernels appear to define DEBIAN_API_VERSION, but they > are > > not really a Debian kernel per-se: the abi-debian-version.sh cannot > find > > the expected Debian kernel version string layout. > > > > Therefore, change the conditional check to use directly the > > LTTNG_DEBIAN_VERSION_CODE define, which is defined only when the > > abi-debian-version.sh script figures out it builds against a Debian > > kernel. > > > > Signed-off-by: Mathieu Desnoyers > > I reverted this commit. DEBIAN_API_VERSION is actually > the define I use to communicate between the makefile > and the C code. It should work even if not defined > (see the check in LTTNG_DEBIAN_KERNEL_RANGE()). > > Hrm. But it appears that the operators generated by > those macros end up being invalid if DEBIAN_API_VERSION > is undefined. Will fix and push upstream. > > Thanks, > > Mathieu > > > > > Thanks, > > > > Mathieu > > > > > _______________________________________________ > > > lttng-dev mailing list > > > lttng-dev@lists.lttng.org > > > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > > > > -- > > > > -- > > Mathieu Desnoyers > > EfficiOS Inc. > > http://www.efficios.com > > > > _______________________________________________ > > lttng-dev mailing list > > lttng-dev@lists.lttng.org > > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > > > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com > --001a1134b02c98ab1305160db4be Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Mathieu! In the meantime I'm using 2.6.0 for th= e moment and will try your fix when it's ready.

On Thu, May 14, 2015 at 11:28 AM, M= athieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
----- Original Message -----
> ----- Original Message -----
>
> > Hello there. I was wondering if anybody knew what is causing this=
> > compilation
> > error I'm getting on a new Ubuntu 14.04 VM with a 3.13.0 kern= el. It does
> > not
> > find the DEBIAN_API_VERSION symbol. The use of that was introduce= d in 2.6.1
> > apparently:
>
> > http://fossies.org/diff= s/lttng-modules/2.6.0_vs_2.6.1/lttng-kernel-version.h-diff.html
>
> > I'm following the instructions in the Download page to instal= l from the PPA
> > :
> > h= ttp://lttng.org/download/#ubuntu
>
> > This the error I'm getting. Thanks in advance for any help! >
> > In file included from
> > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+2015042918= 01~ubuntu14.04.1/build/wrapper/page_alloc.h:28:0,
> >=C2=A0 =C2=A0 =C2=A0from
> > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+2015042918= 01~ubuntu14.04.1/build/lttng-events.c:27:
> >=C2=A0 =C2=A0 =C2=A0/var/lib/dkms/lttng-modules/2.6.x+stable+bzr72= 7+pack22+201504291801~ubuntu14.04.1/build/wrapper/../lttng-kernel-version.h= :60:57:
> > error: operator '+' has no right operand=C2=A0 =C2=A0 ((L= INUX_VERSION_CODE *
> > 1000000ULL)
> > + DEBIAN_API_VERSION)
>
> I pushed the following fix into master and stable-2.6 branches
> of lttng-modules. Can you give it a try ?
>
> commit a748963b76f353d459a3faf85eecc96f52811eee
> Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Date:=C2=A0 =C2=A0Thu May 14 09:13:49 2015 -0400
>
>=C2=A0 =C2=A0 =C2=A0Fix: build against Ubuntu kernels
>
>=C2=A0 =C2=A0 =C2=A0Recent Ubuntu kernels appear to define DEBIAN_API_V= ERSION, but they are
>=C2=A0 =C2=A0 =C2=A0not really a Debian kernel per-se: the abi-debian-v= ersion.sh cannot find
>=C2=A0 =C2=A0 =C2=A0the expected Debian kernel version string layout. >
>=C2=A0 =C2=A0 =C2=A0Therefore, change the conditional check to use dire= ctly the
>=C2=A0 =C2=A0 =C2=A0LTTNG_DEBIAN_VERSION_CODE define, which is defined = only when the
>=C2=A0 =C2=A0 =C2=A0abi-debian-version.sh script figures out it builds = against a Debian
>=C2=A0 =C2=A0 =C2=A0kernel.
>
>=C2=A0 =C2=A0 =C2=A0Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com><= br>
I reverted this commit. DEBIAN_API_VERSION is actually
the define I use to communicate between the makefile
and the C code. It should work even if not defined
(see the check in LTTNG_DEBIAN_KERNEL_RANGE()).

Hrm. But it appears that the operators generated by
those macros end up being invalid if DEBIAN_API_VERSION
is undefined. Will fix and push upstream.

Thanks,

Mathieu

>
> Thanks,
>
> Mathieu
>
> > _______________________________________________
> > lttng-dev mailing list
> > lttng-dev@lists.lttn= g.org
> > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttn= g-dev
>
> --
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.effic= ios.com
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org=
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev=
>

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.c= om

--001a1134b02c98ab1305160db4be-- --===============1013456068== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev --===============1013456068==--