From: Joel Stanley <joel@jms.id.au>
To: Peter Delevoryas <pdel@fb.com>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
"Peter Maydell" <peter.maydell@linaro.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"Cédric Le Goater" <clg@kaod.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type
Date: Tue, 14 Sep 2021 12:14:28 +0000 [thread overview]
Message-ID: <CACPK8Xdey9_x-ZN1JbgFyTrW59EapH4xcqYbyNQxyQ5t0uWPvw@mail.gmail.com> (raw)
In-Reply-To: <BBC4A4E0-651C-41DB-81DE-1F6D86AABAB1@fb.com>
On Tue, 14 Sept 2021 at 11:59, Peter Delevoryas <pdel@fb.com> wrote:
>
>
> > On Sep 14, 2021, at 3:56 AM, Cédric Le Goater <clg@kaod.org> wrote:
> >
> >
> > Hello Peter D,
> >
> >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data)
> >> +{
> >> + MachineClass *mc = MACHINE_CLASS(oc);
> >> + AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
> >> +
> >> + mc->desc = "Facebook Fuji BMC (Cortex-A7)";
> >> + amc->soc_name = "ast2600-a3";
> >> + amc->hw_strap1 = FUJI_BMC_HW_STRAP1;
> >> + amc->hw_strap2 = FUJI_BMC_HW_STRAP2;
> >> + amc->fmc_model = "mx66l1g45g";
> >> + amc->spi_model = "mx66l1g45g";
> >> + amc->num_cs = 2;
> >> + amc->macs_mask = ASPEED_MAC3_ON;
> >> + amc->i2c_init = fuji_bmc_i2c_init;
> >> + amc->uart_default = ASPEED_DEV_UART1;
> >> + mc->default_ram_size = 2 * GiB;
> >
> > Is that the default of the Fuji board ? This is causing an issue in our tests :
> >
> > qemu-system-aarch64: at most 2047 MB RAM can be simulated
> >
> > Could we lower it down to 1G ?
>
> Yikes, sorry about that. I thought it was 2G, but yeah let’s just lower it to 1G. I might be completely wrong anyways.
The upstream device tree uses 2G:
https://elixir.bootlin.com/linux/v5.15-rc1/source/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi#L20
It's unfortunate we limit the defaults given very few (no one?) is
using this model on a machine that is 32 bit.
OTOH, modelling 1G of RAM is useful for testing, so it's no great loss.
Cheers,
Joel
next prev parent reply other threads:[~2021-09-14 12:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 16:12 [PULL 00/14] aspeed queue Cédric Le Goater
2021-09-13 16:12 ` [PULL 01/14] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb Cédric Le Goater
2021-09-13 16:12 ` [PULL 02/14] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a Cédric Le Goater
2021-09-13 16:12 ` [PULL 03/14] watchdog: aspeed: Sanitize control register values Cédric Le Goater
2021-09-13 16:12 ` [PULL 04/14] watchdog: aspeed: Fix sequential control writes Cédric Le Goater
2021-09-13 16:12 ` [PULL 05/14] hw: aspeed_gpio: Simplify 1.8V defines Cédric Le Goater
2021-09-13 16:12 ` [PULL 06/14] hw: aspeed_gpio: Clarify GPIO controller name Cédric Le Goater
2021-09-13 16:12 ` [PULL 07/14] misc/pca9552: Fix LED status register indexing in pca955x_get_led() Cédric Le Goater
2021-09-13 16:12 ` [PULL 08/14] arm/aspeed: rainier: Add i2c eeproms and muxes Cédric Le Goater
2021-09-13 16:12 ` [PULL 09/14] aspeed: Emulate the AST2600A3 Cédric Le Goater
2021-09-13 16:13 ` [PULL 10/14] hw/misc: Add Infineon DPS310 sensor model Cédric Le Goater
2021-09-13 16:13 ` [PULL 11/14] arm/aspeed: Add DPS310 to Witherspoon and Rainier Cédric Le Goater
2021-09-13 16:13 ` [PULL 12/14] hw/arm/aspeed: Initialize AST2600 UART clock selection registers Cédric Le Goater
2021-09-13 16:13 ` [PULL 13/14] hw/arm/aspeed: Allow machine to set UART default Cédric Le Goater
2021-09-13 16:13 ` [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Cédric Le Goater
2021-09-14 10:56 ` Cédric Le Goater
2021-09-14 11:59 ` Peter Delevoryas
2021-09-14 12:14 ` Joel Stanley [this message]
2021-09-14 12:26 ` Peter Maydell
2021-09-14 15:22 ` Richard Henderson
2021-09-15 7:42 ` Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type) Thomas Huth
2021-09-15 7:54 ` Philippe Mathieu-Daudé
2021-09-15 8:37 ` Daniel P. Berrangé
2021-09-15 8:51 ` Philippe Mathieu-Daudé
2021-09-15 9:05 ` Daniel P. Berrangé
2021-09-16 12:29 ` [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Cédric Le Goater
2021-09-16 13:53 ` Philippe Mathieu-Daudé
2021-09-16 14:06 ` Cédric Le Goater
2021-09-16 14:07 ` Peter Maydell
2021-09-14 10:51 ` [PULL 00/14] aspeed queue Peter Maydell
2021-09-14 10:58 ` Cédric Le Goater
2021-09-14 11:38 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2021-09-20 8:09 Cédric Le Goater
2021-09-20 8:09 ` [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Cédric Le Goater
2021-09-03 19:40 [PULL 00/14] aspeed queue Cédric Le Goater
2021-09-03 19:41 ` [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Cédric Le Goater
2021-09-03 20:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xdey9_x-ZN1JbgFyTrW59EapH4xcqYbyNQxyQ5t0uWPvw@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=pdel@fb.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.