From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0521FCCA481 for ; Wed, 15 Jun 2022 13:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353645AbiFONtx (ORCPT ); Wed, 15 Jun 2022 09:49:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347269AbiFONts (ORCPT ); Wed, 15 Jun 2022 09:49:48 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8D73D490 for ; Wed, 15 Jun 2022 06:49:48 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id r3so20632735ybr.6 for ; Wed, 15 Jun 2022 06:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U88w6rJYcyJnx/PiUJFBepiomOwqP/IlAl1ZUElx+ME=; b=jJ3LLJifolkoYZ1YfbdVFN+8wHt8g2celG7g1c4F5G7jOrEHq/sEKBkogiMU+yAlmV 70E45k5zMfIX+LJr1FRtG2V9pWcgV1WU32SP6J18wKxMTBlt48cPYfehNldHyzZJzQGw dQ8C5Tv2EW0YMKanBUnNoreZDtTGDHPWZrhJk+bU25QQXgjhFy+E+C1DfBzjmHLPI+/E zyBjliyX6QovEvO9M9WVz/b/2yfiI3r/AWgyYoT6tYQRA4DKRFlQlpqPA5FSNIGxYZBd OuNZ3xqj8AUDtwNXaO3MLwy+Py19AxS+rU/cdpZ5XlMmsmp0qaPHeDxUORjE2mcPKTZ4 ulVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U88w6rJYcyJnx/PiUJFBepiomOwqP/IlAl1ZUElx+ME=; b=u9eM4B62IimonC/HHClmQ5fAghlxdPnqJktDXMNKo5LFrIstrerwvMdGg2rZ/d/Ohc vnffoR8+11ES5VMRG776Y2cpk+554RFj0xrs3xZ1A4YJqtZ9JenHOxxFXpNdVoZbHdAG nIdnwy790yUesf6d/Rg74JPY0L3DaPmkiQxy3w6tTfbjOOFD5BECNvMVs82kmr4uG5Qt KY140vGwO9C5PSJIDDKz0WDouSXry8R4XYsV+VJrFJdB7sjfl+oAzoOjt9EwSW+XR4hE a6SU2ROzwAeIBRwqYlFpagUPvyUATM0DRNzZUVbeNUhQx+lIWqqi2g5FRpZvpQnCHkME 778A== X-Gm-Message-State: AJIora/Gs0vIKn/qVxqi8y4aRrR/kYSaoLFFC6Z2xiq9Nvfvx/0Isnsr STLloIbycAigHemkNJaMuRlIjfwk4zKaVdxwNcEhKg== X-Google-Smtp-Source: AGRyM1uRGcS4u7CE8T+7q54IVeoVZ6QJLPafoXD4TtCs8MF/xkhyj+z422B9IZUbR9Pzir4GWckGrm2ekxu3ik3++Cw= X-Received: by 2002:a25:3417:0:b0:664:aab3:7c44 with SMTP id b23-20020a253417000000b00664aab37c44mr10357824yba.533.1655300987386; Wed, 15 Jun 2022 06:49:47 -0700 (PDT) MIME-Version: 1.0 References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-8-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220605160508.134075-8-krzysztof.kozlowski@linaro.org> From: Linus Walleij Date: Wed, 15 Jun 2022 15:49:35 +0200 Message-ID: Subject: Re: [PATCH v3 7/8] pinctrl: samsung: do not use bindings header with constants To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chanho Park Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, Jun 5, 2022 at 6:05 PM Krzysztof Kozlowski wrote: > The Samsung SoC pin controller driver uses only three defines from the > bindings header with pin configuration register values, which proves > the point that this header is not a proper bindings-type abstraction > layer with IDs. > > Define the needed register values directly in the driver and stop using > the bindings header. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Chanho Park Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA565C433EF for ; Wed, 15 Jun 2022 13:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Psvvvg8CZ+U4R+SKZz6ZahW5+qQaQ0dG0mTN7Jpj8rQ=; b=oFEfuS4gLh5Qo3 MIQ0zbIhIuqwEBH+E4HVat8qBIYUJOaoRKF2nuwoI4OzC3iwb5Z+HeewanGlrwuWSdWgl11x6i9pg IDhi5MxMt0yR7tn7k/5mnTix5l8kQSQO5YmI4wRLzG3eHVi5Vf+Q68hn4fG4LQ2FvYbQdn50ulV2J fNCV4TMPvKyxyHuDCVni3PhIL83Q6BNchqVPZHTRqODamcwoJx7caQvn5vZf+qV5v6Yl7jipVAjs1 AHX9YIOZuR+FWPVLO5ylrcqYzTNfzAm7AH88oOlXkoJ0KRuWwS3rTFyx31Vo+RREUVj9A8P8PfB9j nW4GCPG6h8eOQqyPmUqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1TP5-00EnDy-TE; Wed, 15 Jun 2022 13:49:52 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1TP2-00EnCt-5R for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 13:49:49 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id l204so20564438ybf.10 for ; Wed, 15 Jun 2022 06:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U88w6rJYcyJnx/PiUJFBepiomOwqP/IlAl1ZUElx+ME=; b=jJ3LLJifolkoYZ1YfbdVFN+8wHt8g2celG7g1c4F5G7jOrEHq/sEKBkogiMU+yAlmV 70E45k5zMfIX+LJr1FRtG2V9pWcgV1WU32SP6J18wKxMTBlt48cPYfehNldHyzZJzQGw dQ8C5Tv2EW0YMKanBUnNoreZDtTGDHPWZrhJk+bU25QQXgjhFy+E+C1DfBzjmHLPI+/E zyBjliyX6QovEvO9M9WVz/b/2yfiI3r/AWgyYoT6tYQRA4DKRFlQlpqPA5FSNIGxYZBd OuNZ3xqj8AUDtwNXaO3MLwy+Py19AxS+rU/cdpZ5XlMmsmp0qaPHeDxUORjE2mcPKTZ4 ulVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U88w6rJYcyJnx/PiUJFBepiomOwqP/IlAl1ZUElx+ME=; b=236vwzc3A0JRgQNdvbtGlRxHWzA8zlaJBsI4ddiH84v++ocy+S77dJqX/gzfbHfgGH jo5f34YgyrGYSo7vBrnY/dClK7mml2ldes1fDkfHXv6pbj8+xs2HH5rQR2EtwOMI3Sox Z9ZUv/N7/b9+fNOHrDSYm2T8r0DfkvcQw5B5Bl/y1o5t9fli3hUlhjXtSaeucNlTvtJO Oabl+Us6jc8Ij8+ArxFVhN/tYjm/4CRgV82QFQyuvtujjJaHIU9XM/+KMhpKTOTCqcb3 SP+mSANv3GgiO1SZ8uJKi0FmWvtGXUjzlsurW/ewGdUeXsL2JQeL37+qKV199JKIHTXF QoGQ== X-Gm-Message-State: AJIora+LCS9su99QrRiAjkuMiAl2/Ssp2fMogjZaP9Wa8oYyCJOx3gqe Yqr4eCaGgNM70dxtby4wGJFE1N/xl2CwqO0xEmJPbw== X-Google-Smtp-Source: AGRyM1uRGcS4u7CE8T+7q54IVeoVZ6QJLPafoXD4TtCs8MF/xkhyj+z422B9IZUbR9Pzir4GWckGrm2ekxu3ik3++Cw= X-Received: by 2002:a25:3417:0:b0:664:aab3:7c44 with SMTP id b23-20020a253417000000b00664aab37c44mr10357824yba.533.1655300987386; Wed, 15 Jun 2022 06:49:47 -0700 (PDT) MIME-Version: 1.0 References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-8-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220605160508.134075-8-krzysztof.kozlowski@linaro.org> From: Linus Walleij Date: Wed, 15 Jun 2022 15:49:35 +0200 Message-ID: Subject: Re: [PATCH v3 7/8] pinctrl: samsung: do not use bindings header with constants To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chanho Park X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_064948_246413_6321E856 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 5, 2022 at 6:05 PM Krzysztof Kozlowski wrote: > The Samsung SoC pin controller driver uses only three defines from the > bindings header with pin configuration register values, which proves > the point that this header is not a proper bindings-type abstraction > layer with IDs. > > Define the needed register values directly in the driver and stop using > the bindings header. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Chanho Park Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel